[ https://issues.apache.org/jira/browse/ISIS-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13695570#comment-13695570 ]
ASF subversion and git services commented on ISIS-449: ------------------------------------------------------ Commit 496c8ed97c00e661410d38024e191d1252086e50 in branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=496c8ed ] ISIS-449: improvements to transaction handling on abort. > Error handling when transaction aborted incorrect > ------------------------------------------------- > > Key: ISIS-449 > URL: https://issues.apache.org/jira/browse/ISIS-449 > Project: Isis > Issue Type: Bug > Components: Core, Viewer: Wicket > Affects Versions: viewer-wicket-1.2.0, core-1.2.0 > Reporter: Dan Haywood > Assignee: Dan Haywood > Priority: Minor > Fix For: viewer-wicket-1.3.0, core-1.3.0 > > > Situation was as follows: > - two edits made that would cause a unique index constraint violation in the > database, and the other that (due to a programming bug) would cause a null > pointer. > In IsisTransactionManager#endTransaction(), the abortCause gets set onto the > IsisTransaction because of the unique constraint, causing Isis to attempt > call abortTransaction(). However, there is no exception handling around this > method, and a subsequent NPE is not captured for rendering. > In addition, in the wicket viewer, whenever an exception does occur and the > transaction is aborted, the attempt to redirect to the error page will fail > if the page requires a transaction. A new transaction should therefore be > started. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira