[jira] Updated: (JCR-1091) more lenient behavior of Node#addMixin if mixin is already present

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1091: --- Attachment: JCR-1091.patch See the attached patch (JCR-1091.patch) for my take on the required changes

Re: synchronization issues

2007-12-18 Thread Padraic Hannon
I think it may be best to take a long look at the various *ItemStateManager classes in a holistic manner. It appears that these classes introduce a lot of the locking and synchronization issues (as would be expected from such a key group of classes). The movement towards using more fine gra

Re: synchronization issues

2007-12-18 Thread Jukka Zitting
Hi, On Dec 18, 2007 12:23 PM, Marcel Reutegger <[EMAIL PROTECTED]> wrote: > there are a number of synchronization issues I would like to resolve for the > 1.4 > release. +1, I'll hold off branching 1.4 until we get these issues resolved. > comments are welcome. See comments on the individual i

[jira] Updated: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1271: --- Attachment: JCR-1271.jz.patch Attached (JCR-1271.jz.patch) is a slight revision of your latest patch. T

[jira] Commented: (JCR-1148) NullPointerException in ItemState

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552810 ] Jukka Zitting commented on JCR-1148: Looks good enough, though I must admit I'm having a hard time understanding th

[jira] Updated: (JCR-1272) Property.getValue() throws RepositoryException with internal error

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1272: --- Attachment: JCR-1272.jz.patch The attached patch (JCR-1272.jz.patch) makes all type-specific getters an

[jira] Updated: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1271: -- Attachment: JCR-1271.patch This patch turns ItemStateReferenceCache into a thread-safe implementa

[jira] Updated: (JCR-1275) NullPointerException in AbstractVersionManager.createVersionHistory()

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1275: -- Attachment: JCR-1275.patch This is the best I can come up with. Not a nice solution but at least

[jira] Created: (JCR-1275) NullPointerException in AbstractVersionManager.createVersionHistory()

2007-12-18 Thread Marcel Reutegger (JIRA)
NullPointerException in AbstractVersionManager.createVersionHistory() - Key: JCR-1275 URL: https://issues.apache.org/jira/browse/JCR-1275 Project: Jackrabbit Issue Type: Bug

[jira] Commented: (JCR-1250) When adding a large (100MB) binary to the DbDataStore, it fails with an insufficient memory exception

2007-12-18 Thread Esteban Franqueiro (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552782 ] Esteban Franqueiro commented on JCR-1250: - >From jcr.log: [main] ConnectionRecoveryManager: Database: Microsoft

[jira] Commented: (JCR-1272) Property.getValue() throws RepositoryException with internal error

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552774 ] Marcel Reutegger commented on JCR-1272: --- You are right. The funny thing is getString() already uses getValue(). :

[jira] Commented: (JCR-1272) Property.getValue() throws RepositoryException with internal error

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552769 ] Jukka Zitting commented on JCR-1272: In fact there are tons of unguarded code that accesses the state variable. I'l

Re: synchronization issues

2007-12-18 Thread Marcel Reutegger
I forgot one issue: JCR-1148 - may happen with both ISMLocking implementations. the fix is IMO quite easy and low risk: move synchronization of mod count into copy(). regards marcel Marcel Reutegger wrote: hi all, there are a number of synchronization issues I would like to resolve for th

[jira] Commented: (JCR-1272) Property.getValue() throws RepositoryException with internal error

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552760 ] Jukka Zitting commented on JCR-1272: What about all the other value getters like getString()? I guess we should mak

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552755 ] Jukka Zitting commented on JCR-1271: Our codebase is already pretty complex, so avoiding an extra wrapper class and

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552746 ] Marcel Reutegger commented on JCR-1271: --- That would be an alternative, but as mentioned before there are use case

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552718 ] Jukka Zitting commented on JCR-1271: Could we not fix the problem at its source instead of in a synchronization wr

Re: Jack rabbit allows any virus check before uploading

2007-12-18 Thread kranti.infy
Is there any software which does this. Jukka Zitting wrote: > > Hi, > > On Dec 18, 2007 8:48 AM, kranti.infy <[EMAIL PROTECTED]> wrote: >> Does Jack Rabbit allows any Virus and other checks before uploading into >> the >> repository. > > No, you'll need to do that on the application leve

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552701 ] Marcel Reutegger commented on JCR-1271: --- AFAICS, the difference is minimal. Running times for tests only differ s

[jira] Resolved: (JCR-314) Fine grained locking in SharedItemStateManager

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-314. -- Resolution: Fixed Fix Version/s: 1.4 Committed ConfigurableISMLocking.patch in revision: 60

[jira] Resolved: (JCR-1273) Unnecessary parsing of Name value

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-1273. --- Resolution: Fixed Fix Version/s: 1.4 Applied patch in revision: 605171 > Unnecessary pa

synchronization issues

2007-12-18 Thread Marcel Reutegger
hi all, there are a number of synchronization issues I would like to resolve for the 1.4 release. some of them are related to using the new FineGrainedISMLocking but most of them are general synchronization issues that may happen with both DefaultISMLocking and FineGrainedISMLocking, though m

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Ard Schrijvers (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552682 ] Ard Schrijvers commented on JCR-1271: - :-) True, but if it is like a big difference, other options might be worth

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552678 ] Marcel Reutegger commented on JCR-1271: --- Well, as with any synchronization it will slow down execution. But if I

[jira] Commented: (JCR-935) ConcurrentModificationException during logout (cont'd)

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552673 ] Marcel Reutegger commented on JCR-935: -- This issue is related to JCR-1271. The cause is the same: LocalItemStateMa

[jira] Resolved: (JCR-1244) No need for NodeReferences in jcr2spi

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting resolved JCR-1244. Resolution: Fixed Fix Version/s: 1.4 Assignee: Jukka Zitting Patch applied in revisio

[jira] Commented: (JCR-1250) When adding a large (100MB) binary to the DbDataStore, it fails with an insufficient memory exception

2007-12-18 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552668 ] Thomas Mueller commented on JCR-1250: - Hi, I got this problem when using the old driver: in this case the property

[jira] Commented: (JCR-1154) Database Data Store

2007-12-18 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552664 ] Thomas Mueller commented on JCR-1154: - Hi, I have tested it again and my results are: When storing an object, a t

[jira] Resolved: (JCR-1182) Put everything in jackrabbit-spi-commons under org.apache.jackrabbit.spi.commons

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting resolved JCR-1182. Resolution: Fixed Packages moved in revision 605147. The dependent packages in trunk were also updat

[jira] Updated: (JCR-1182) Put everything in jackrabbit-spi-commons under org.apache.jackrabbit.spi.commons

2007-12-18 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1182: --- Component/s: jackrabbit-spi2jcr jackrabbit-jcr2spi jackrabbit-core

[jira] Resolved: (JCR-1209) NodeImpl.checkout() calls save() two times

2007-12-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-1209. --- Resolution: Fixed Thank you for reviewing. Committed patch in revision: 605134 > NodeImpl.che

[jira] Resolved: (JCR-1009) JCR2SPI: add JNDI support

2007-12-18 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-1009. - Resolution: Fixed Optional JNDI support has been implemented as proposed in then initial plan. >