[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-05 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r866419970 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -36,13 +36,15 @@ public class CommonOptions implements OptionsBean {

[GitHub] [jackrabbit-oak] FrancoisZhang commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-05 Thread GitBox
FrancoisZhang commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r866403745 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -36,13 +36,15 @@ public class CommonOptions implements

[GitHub] [jackrabbit-oak] Ewocker opened a new pull request, #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-05 Thread GitBox
Ewocker opened a new pull request, #561: URL: https://github.com/apache/jackrabbit-oak/pull/561 error out if `tika` dependencies are missing and improve logging to log warning instead of debug silently. > !! Feel free to come up with a better flag name and log message if you think

[GitHub] [jackrabbit-oak] tihom88 merged pull request #557: OAK-9753: ES connection parameters should be easily accessible from E…

2022-05-05 Thread GitBox
tihom88 merged PR #557: URL: https://github.com/apache/jackrabbit-oak/pull/557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] reschke commented on pull request #560: OAK-9757 : increased node name limit for mongo 4.2 version

2022-05-05 Thread GitBox
reschke commented on PR #560: URL: https://github.com/apache/jackrabbit-oak/pull/560#issuecomment-1118575244 Idea: Move (or copy) the util functions to the DocumentStore API, where they have access to metadata. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #557: OAK-9753: ES connection parameters should be easily accessible from E…

2022-05-05 Thread GitBox
tihom88 commented on code in PR #557: URL: https://github.com/apache/jackrabbit-oak/pull/557#discussion_r865707540 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java: ## @@ -83,33 +128,62 @@ public ElasticConnection

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #559: Oak-9729 | Improving ES test container creation for ES tests

2022-05-05 Thread GitBox
nit0906 commented on code in PR #559: URL: https://github.com/apache/jackrabbit-oak/pull/559#discussion_r865693948 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticTestServer.java: ## @@ -44,23 +44,32 @@ public class ElasticTestServer

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #559: Oak-9729 | Improving ES test container creation for ES tests

2022-05-05 Thread GitBox
tihom88 commented on code in PR #559: URL: https://github.com/apache/jackrabbit-oak/pull/559#discussion_r865684223 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticTestServer.java: ## @@ -44,23 +44,32 @@ public class ElasticTestServer

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #557: OAK-9753: ES connection parameters should be easily accessible from E…

2022-05-05 Thread GitBox
fabriziofortino commented on code in PR #557: URL: https://github.com/apache/jackrabbit-oak/pull/557#discussion_r865677625 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java: ## @@ -83,33 +128,62 @@ public

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #557: OAK-9753: ES connection parameters should be easily accessible from E…

2022-05-05 Thread GitBox
tihom88 commented on code in PR #557: URL: https://github.com/apache/jackrabbit-oak/pull/557#discussion_r865668475 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java: ## @@ -75,6 +80,46 @@ protected void after() {

[GitHub] [jackrabbit-oak] nit0906 opened a new pull request, #559: Oak-9729 | Improving ES test container creation for ES tests

2022-05-05 Thread GitBox
nit0906 opened a new pull request, #559: URL: https://github.com/apache/jackrabbit-oak/pull/559 * Adding retry mechanism while starting the testContainer docker * Handling singleton creation logic based on running state of ES container -- This is an automated message from the Apache

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #557: OAK-9753: ES connection parameters should be easily accessible from E…

2022-05-05 Thread GitBox
thomasmueller commented on code in PR #557: URL: https://github.com/apache/jackrabbit-oak/pull/557#discussion_r865642479 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java: ## @@ -75,6 +80,46 @@ protected void after()

[GitHub] [jackrabbit-oak] dependabot[bot] opened a new pull request, #558: Bump mina-core from 2.1.3 to 2.1.5 in /oak-auth-ldap

2022-05-05 Thread GitBox
dependabot[bot] opened a new pull request, #558: URL: https://github.com/apache/jackrabbit-oak/pull/558 Bumps [mina-core](https://github.com/apache/mina) from 2.1.3 to 2.1.5. Commits https://github.com/apache/mina/commit/bc9bb230f112f58854bf70660c443cfd52c2bcff;>bc9bb23

[GitHub] [jackrabbit-oak] tihom88 merged pull request #556: OAK-9750: oak-search-elastic: Add right tika dependency

2022-05-05 Thread GitBox
tihom88 merged PR #556: URL: https://github.com/apache/jackrabbit-oak/pull/556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] tihom88 commented on pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

2022-05-05 Thread GitBox
tihom88 commented on PR #552: URL: https://github.com/apache/jackrabbit-oak/pull/552#issuecomment-1118248152 Closing this... had conflicting changes in master. Created a new PR on latest code https://github.com/apache/jackrabbit-oak/pull/557 -- This is an automated message from the

[GitHub] [jackrabbit-oak] tihom88 closed pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

2022-05-05 Thread GitBox
tihom88 closed pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule URL: https://github.com/apache/jackrabbit-oak/pull/552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

2022-05-05 Thread GitBox
tihom88 commented on code in PR #552: URL: https://github.com/apache/jackrabbit-oak/pull/552#discussion_r865606574 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java: ## @@ -154,17 +203,45 @@ public ElasticConnection

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

2022-05-05 Thread GitBox
tihom88 commented on code in PR #552: URL: https://github.com/apache/jackrabbit-oak/pull/552#discussion_r865603623 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java: ## @@ -154,17 +203,45 @@ public ElasticConnection

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

2022-05-05 Thread GitBox
tihom88 commented on code in PR #552: URL: https://github.com/apache/jackrabbit-oak/pull/552#discussion_r865603102 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexCleanerTest.java: ## @@ -75,9 +75,9 @@ public void

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

2022-05-05 Thread GitBox
tihom88 commented on code in PR #552: URL: https://github.com/apache/jackrabbit-oak/pull/552#discussion_r865602808 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java: ## @@ -130,6 +139,46 @@ private void

[GitHub] [jackrabbit-oak] tihom88 opened a new pull request, #557: OAK-9753: ES connection parameters should be easily accessible from E…

2022-05-05 Thread GitBox
tihom88 opened a new pull request, #557: URL: https://github.com/apache/jackrabbit-oak/pull/557 …lasticConnectionRule -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To