rishabhdaim commented on PR #560:
URL: https://github.com/apache/jackrabbit-oak/pull/560#issuecomment-1120661592
@mreutegg
> To me it feels wrong that Utils.isLongPath() is currently responsible for
detecting when a node name is too long
Yes, I think it should be other way around i.e. **node name too long**
should check whether path is long or not.
I think, we should move out the logic to check **node name too long** to a
separate method and call `Utils.isLongPath()` from it since **node name too
long** make sense only for long paths.
`
/*** The maximum size a node name, in bytes. This is only a problem for long
path.*/
int NODE_NAME_LIMIT = Integer.getInteger("oak.nodeNameLimit",
150);
`
As mentioned by you, we should move whole logic for **node name too long**
here
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeState.java#L417
and then we should be able to reduce the number of changed files significantly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
