[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950144346 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #673: OAK-9879: CacheLIRS statistics may return incorrect load count

2022-08-19 Thread GitBox
thomasmueller merged PR #673: URL: https://github.com/apache/jackrabbit-oak/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-19 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r950319566 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -207,21 +222,57 @@ private static void

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950293058 ## oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexPathRestrictionCommonTest.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950292276 ## oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/FullTextIndexCommonTest.java: ## @@ -112,6 +113,67 @@ public void

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950291136 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticResponseHandler.java: ## @@ -41,14 +43,22 @@ public class

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-19 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r950282226 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -207,21 +222,57 @@ private static void

[GitHub] [jackrabbit-oak] Joscorbe commented on pull request #295: Support for Mongo Java Driver 4.2+

2022-08-19 Thread GitBox
Joscorbe commented on PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#issuecomment-1220665247 Hi @mreutegg, yes, the plan is to move to sync driver after the failing tests in this build are fixed. Apart from the documentation you have showed, I have this support case where

[GitHub] [jackrabbit-oak] Joscorbe commented on pull request #295: Support for Mongo Java Driver 4.2+

2022-08-19 Thread GitBox
Joscorbe commented on PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#issuecomment-1220645692 @mreutegg Yes, legacy driver is the one I'm using for these changes, you can see it here:

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950156675 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStoreThrottlingMetricsUpdater.java: ## @@ -0,0 +1,138 @@ +/*

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950144346 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950144346 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
fabriziofortino commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950028769 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticResponseHandler.java: ## @@ -41,14 +43,22 @@ public class

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
thomasmueller commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950112445 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticResponseHandler.java: ## @@ -41,14 +43,22 @@ public class

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #295: Support for Mongo Java Driver 4.2+

2022-08-19 Thread GitBox
mreutegg commented on PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#issuecomment-1220589503 @Joscorbe it seems to me only a few changes would be necessary to avoid use of the legacy driver, but I may be missing some less trivial changes.

[GitHub] [jackrabbit-oak] mreutegg closed pull request #652: OAK-9879: CacheLIRS statistics may return incorrect load count

2022-08-19 Thread GitBox
mreutegg closed pull request #652: OAK-9879: CacheLIRS statistics may return incorrect load count URL: https://github.com/apache/jackrabbit-oak/pull/652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #652: OAK-9879: CacheLIRS statistics may return incorrect load count

2022-08-19 Thread GitBox
mreutegg commented on PR #652: URL: https://github.com/apache/jackrabbit-oak/pull/652#issuecomment-1220568899 Closing this PR in favour of #673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [jackrabbit-oak] thomasmueller commented on pull request #652: OAK-9879: CacheLIRS statistics may return incorrect load count

2022-08-19 Thread GitBox
thomasmueller commented on PR #652: URL: https://github.com/apache/jackrabbit-oak/pull/652#issuecomment-1220508014 See alternative patch https://github.com/apache/jackrabbit-oak/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-oak] thomasmueller opened a new pull request, #673: OAK-9879: CacheLIRS statistics may return incorrect load count

2022-08-19 Thread GitBox
thomasmueller opened a new pull request, #673: URL: https://github.com/apache/jackrabbit-oak/pull/673 Alternative for https://github.com/apache/jackrabbit-oak/pull/652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] thomasmueller opened a new pull request, #672: OAK-9907 Allow comparing indexes in the same file

2022-08-19 Thread GitBox
thomasmueller opened a new pull request, #672: URL: https://github.com/apache/jackrabbit-oak/pull/672 Details see https://issues.apache.org/jira/browse/OAK-9907 ``` java -jar target/oak-run-1.45-SNAPSHOT.jar index-diff --compare target/temp/indexes.json --index1

[GitHub] [jackrabbit-oak] nit0906 opened a new pull request, #671: OAK-9903 | Improved use cases for path restriction and path transformation

2022-08-19 Thread GitBox
nit0906 opened a new pull request, #671: URL: https://github.com/apache/jackrabbit-oak/pull/671 * Modified existing lucene tests to have better assertions * Moved the existing tests to common format so that same base can be used for both elastic and lucene * Added new (high level)

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #662: OAK-9893 Prefetch for queries

2022-08-19 Thread GitBox
thomasmueller merged PR #662: URL: https://github.com/apache/jackrabbit-oak/pull/662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #670: OAK-9875-ut: full-text queries on date fields

2022-08-19 Thread GitBox
fabriziofortino commented on code in PR #670: URL: https://github.com/apache/jackrabbit-oak/pull/670#discussion_r949993389 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticAsyncQueryException.java: ## @@ -0,0 +1,42 @@ +/* +

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #670: OAK-9875-ut: full-text queries on date fields

2022-08-19 Thread GitBox
fabriziofortino commented on code in PR #670: URL: https://github.com/apache/jackrabbit-oak/pull/670#discussion_r949989809 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResultRowAsyncIterator.java: ## @@ -336,13 +336,10

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
mreutegg commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r949960318 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStoreThrottlingMetricsUpdaterTest.java: ## @@ -0,0 +1,108 @@ +/*

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
mreutegg commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r949948669 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStoreThrottlingMetricsUpdater.java: ## @@ -0,0 +1,138 @@ +/* + *

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
mreutegg commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r949938576 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #652: OAK-9879: CacheLIRS statistics may return incorrect load count

2022-08-19 Thread GitBox
thomasmueller commented on code in PR #652: URL: https://github.com/apache/jackrabbit-oak/pull/652#discussion_r949845232 ## oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java: ## @@ -1025,7 +1025,9 @@ V load(K key, int hash, Callable valueLoader) throws