[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-22 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r952106899 ## oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/FullTextIndexCommonTest.java: ## @@ -112,6 +113,67 @@ public void

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951598922 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDefinition.java: ## @@ -220,6 +222,35 @@ public String

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951563266 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticAbstractQueryTest.java: ## @@ -140,7 +145,7 @@ protected

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951560137 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResultRowAsyncIterator.java: ## @@ -341,8 +343,16 @@ public

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #675: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg commented on PR #675: URL: https://github.com/apache/jackrabbit-oak/pull/675#issuecomment-1222463330 @Joscorbe, can you please review as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #675: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg opened a new pull request, #675: URL: https://github.com/apache/jackrabbit-oak/pull/675 Ensure suspect documents are either up-to-date in the cache or invalidated Enable test -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-oak] mreutegg merged pull request #674: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg merged PR #674: URL: https://github.com/apache/jackrabbit-oak/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #674: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg commented on PR #674: URL: https://github.com/apache/jackrabbit-oak/pull/674#issuecomment-1222402640 Failure in oak-webapp looks unrelated to changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #672: OAK-9907 Allow comparing indexes in the same file

2022-08-22 Thread GitBox
thomasmueller merged PR #672: URL: https://github.com/apache/jackrabbit-oak/pull/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] jsedding merged pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding merged PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #674: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg opened a new pull request, #674: URL: https://github.com/apache/jackrabbit-oak/pull/674 Add ignored test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [jackrabbit-oak] mreutegg merged pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-22 Thread GitBox
mreutegg merged PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-22 Thread GitBox
mreutegg commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r951330598 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to

[GitHub] [jackrabbit-oak] jsedding commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951223721 ## oak-parent/pom.xml: ## @@ -1316,5 +1316,37 @@ + + intellij-build-workaround + + + Review Comment:

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
kwin commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951212776 ## oak-parent/pom.xml: ## @@ -1316,5 +1316,37 @@ + + intellij-build-workaround + + + Review Comment: this

[GitHub] [jackrabbit-oak] jsedding commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951208551 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: Thank you for the pointer!

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
kwin commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951194463 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: Just look at

[GitHub] [jackrabbit-oak] jsedding commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951185051 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: I agree with you in principle.

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
kwin commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951179536 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: I find it a bit nasty that this

OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread Julian Sedding
Hi I am having issues when running unit-tests within Intellij IDEA. I can work around the issue, but it's a bit cumbersome. Therefore I would like to apply the change proposed in PR #664 [0], which addresses OAK-9896 [1]. Do others experience the same problem running unit-tests in Intellij? Does

Plan to merge changes for OAK-9888 - Support more flexible SplitPersistence setups via OSGi

2022-08-22 Thread Julian Sedding
Hi I am planning to merge PR #663 [0] on Wednesday. The changes address OAK-9888 [1] and are intended to allow more flexibility when creating a SplitPersistence. They affect the segment-tar and the segment-azure modules. Please let me know if you see any issues with this change. Regards Julian

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951152234 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -207,21 +222,57 @@ private static void