[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #697: Oak-9917 | Better ES test coverage

2022-09-21 Thread GitBox
nit0906 commented on code in PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#discussion_r977142300 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexPlannerCommonTest.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

2022-09-21 Thread GitBox
stefan-egli commented on PR #690: URL: https://github.com/apache/jackrabbit-oak/pull/690#issuecomment-1254002255 Regarding the "two separate metrics" question: I think there's two different layers to this question: a code design and a metric design question. I've only had a quick look at

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-21 Thread GitBox
fabriziofortino commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r976628273 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexWriter.java: ## @@ -158,24 +159,23 @@ private void

[GitHub] [jackrabbit-oak] dependabot[bot] closed pull request #544: Bump jackson-databind from 2.10.5.1 to 2.12.6.1 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] closed pull request #544: Bump jackson-databind from 2.10.5.1 to 2.12.6.1 in /oak-parent URL: https://github.com/apache/jackrabbit-oak/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #544: Bump jackson-databind from 2.10.5.1 to 2.12.6.1 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] commented on PR #544: URL: https://github.com/apache/jackrabbit-oak/pull/544#issuecomment-1253828112 Looks like com.fasterxml.jackson.core:jackson-databind is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #712: OAK-9947: upgrade jackson (including databind) to 2.13.4

2022-09-21 Thread GitBox
fabriziofortino merged PR #712: URL: https://github.com/apache/jackrabbit-oak/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #697: Oak-9917 | Better ES test coverage

2022-09-21 Thread GitBox
nfsantos commented on code in PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#discussion_r976447576 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexPlannerCommonTest.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
fabriziofortino merged PR #713: URL: https://github.com/apache/jackrabbit-oak/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (JCRVLT-657) Export XmlAnalyser

2022-09-21 Thread Konrad Windszus (Jira)
Konrad Windszus created JCRVLT-657: -- Summary: Export XmlAnalyser Key: JCRVLT-657 URL: https://issues.apache.org/jira/browse/JCRVLT-657 Project: Jackrabbit FileVault Issue Type: Bug

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain commented on code in PR #715: URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r976324312 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java: ## @@ -265,6 +271,55 @@ public void reindex()

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #587: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain commented on code in PR #587: URL: https://github.com/apache/jackrabbit-oak/pull/587#discussion_r969237928 ## oak-run-commons/pom.xml: ## @@ -147,6 +147,11 @@ h2 ${h2.version} + +org.lz4 +lz4-java +

[GitHub] [jackrabbit-oak] amit-jain opened a new pull request, #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain opened a new pull request, #715: URL: https://github.com/apache/jackrabbit-oak/pull/715 - Parallel indexing enabled by splitting the FlatFileStore taking into account aggregation and then running multiple threads to do the indexing - LZ4 compression enabled Work over

[GitHub] [jackrabbit-oak] amit-jain commented on pull request #587: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain commented on PR #587: URL: https://github.com/apache/jackrabbit-oak/pull/587#issuecomment-1253484891 New PR which incorporates the review comments https://github.com/apache/jackrabbit-oak/pull/715 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] jelmini closed pull request #707: Add failFast option to ConsistencyChecker

2022-09-21 Thread GitBox
jelmini closed pull request #707: Add failFast option to ConsistencyChecker URL: https://github.com/apache/jackrabbit-oak/pull/707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jackrabbit-oak] nfsantos commented on pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
nfsantos commented on PR #713: URL: https://github.com/apache/jackrabbit-oak/pull/713#issuecomment-1253402399 > Where did you take these digests from? I take them from a run of the unit tests. I run the tests with a version of the Elastiknn for which I don't have the digest and copy

[GitHub] [jackrabbit-oak] joerghoh commented on pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
joerghoh commented on PR #713: URL: https://github.com/apache/jackrabbit-oak/pull/713#issuecomment-1253360241 Where did you take these digests from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] dependabot[bot] closed pull request #601: Bump mongo-java-driver from 3.12.7 to 3.12.8 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] closed pull request #601: Bump mongo-java-driver from 3.12.7 to 3.12.8 in /oak-parent URL: https://github.com/apache/jackrabbit-oak/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #601: Bump mongo-java-driver from 3.12.7 to 3.12.8 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] commented on PR #601: URL: https://github.com/apache/jackrabbit-oak/pull/601#issuecomment-1253335587 Looks like org.mongodb:mongo-java-driver is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] reschke merged pull request #695: OAK-9925: update MongoDB Java Driver dependency to 3.12.11

2022-09-21 Thread GitBox
reschke merged PR #695: URL: https://github.com/apache/jackrabbit-oak/pull/695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] jsedding merged pull request #676: OAK-9785 - Tar SegmentStore can be corrupted during compaction

2022-09-21 Thread GitBox
jsedding merged PR #676: URL: https://github.com/apache/jackrabbit-oak/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
nfsantos opened a new pull request, #713: URL: https://github.com/apache/jackrabbit-oak/pull/713 Add OOTB support for testing with Elasticsearch 8.3.3 and 8.4.1. Now it is enough to pass the property -DelasticDockerImageVersion=[8.3.3|8.4.4] to the Maven build. In more detail: the