[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-22 Thread GitBox
nit0906 commented on code in PR #715: URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r978288503 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileSplitter.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the

[GitHub] [jackrabbit-oak] nit0906 merged pull request #697: Oak-9917 | Better ES test coverage

2022-09-22 Thread GitBox
nit0906 merged PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #718: OAK-9930 - Thread leak in elastic index statistics module

2022-09-22 Thread GitBox
nfsantos opened a new pull request, #718: URL: https://github.com/apache/jackrabbit-oak/pull/718 Reuse a Thread pool to execute the requests to refresh the cache in the Elastic Index statistics instead of creating a new thread pool for every refresh operation (these thread pools were not

[GitHub] [jackrabbit-oak] nit0906 commented on pull request #697: Oak-9917 | Better ES test coverage

2022-09-22 Thread GitBox
nit0906 commented on PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#issuecomment-1254962360 > Is there a replacement for LuceneIndexDescendatSpellCheckTest? This file was removed, but I don't see a replacement. Or is it redundant with some other test? @nfsantos -

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

2022-09-22 Thread GitBox
nfsantos commented on code in PR #711: URL: https://github.com/apache/jackrabbit-oak/pull/711#discussion_r977598229 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -445,6 +445,12 @@ public

[GitHub] [jackrabbit] reschke commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-22 Thread GitBox
reschke commented on code in PR #128: URL: https://github.com/apache/jackrabbit/pull/128#discussion_r977595502 ## jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImpl.java: ## @@ -704,15 +701,10 @@ public LinkedEntries.LinkNode next() {

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #697: Oak-9917 | Better ES test coverage

2022-09-22 Thread GitBox
fabriziofortino commented on code in PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#discussion_r977560831 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexPlannerCommonTest.java: ## @@ -0,0 +1,233 @@ +/* + *

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #708: OAK-9946: Consistency check for versionable nodes

2022-09-22 Thread GitBox
rishabhdaim commented on code in PR #708: URL: https://github.com/apache/jackrabbit-oak/pull/708#discussion_r977515877 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/document/check/AsyncDocumentProcessor.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache

[GitHub] [jackrabbit] reschke commented on pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-22 Thread GitBox
reschke commented on PR #128: URL: https://github.com/apache/jackrabbit/pull/128#issuecomment-1254844749 can you try to rebase this based on what's currently in trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #708: OAK-9946: Consistency check for versionable nodes

2022-09-22 Thread GitBox
rishabhdaim commented on code in PR #708: URL: https://github.com/apache/jackrabbit-oak/pull/708#discussion_r977480174 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/document/check/AsyncNodeStateProcessor.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

2022-09-22 Thread GitBox
fabriziofortino commented on code in PR #711: URL: https://github.com/apache/jackrabbit-oak/pull/711#discussion_r977465765 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -445,6 +445,12 @@ public

[jira] [Commented] (JCR-4608) Upgrade to commons-collections4

2022-09-22 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608203#comment-17608203 ] Julian Reschke commented on JCR-4608: - The subtasks are new; I have decided to break this down into

[jira] [Comment Edited] (JCR-4608) Upgrade to commons-collections4

2022-09-22 Thread Roman Kovarik (Jira)
[ https://issues.apache.org/jira/browse/JCR-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608202#comment-17608202 ] Roman Kovarik edited comment on JCR-4608 at 9/22/22 10:14 AM: -- Hi [~reschke],

[jira] [Comment Edited] (JCR-4608) Upgrade to commons-collections4

2022-09-22 Thread Roman Kovarik (Jira)
[ https://issues.apache.org/jira/browse/JCR-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608202#comment-17608202 ] Roman Kovarik edited comment on JCR-4608 at 9/22/22 10:13 AM: -- Hi [~reschke],

[jira] [Commented] (JCR-4608) Upgrade to commons-collections4

2022-09-22 Thread Roman Kovarik (Jira)
[ https://issues.apache.org/jira/browse/JCR-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608202#comment-17608202 ] Roman Kovarik commented on JCR-4608: Hi [~reschke], I've missed the new subtasks, is that already in