[GitHub] [jackrabbit-filevault] adamcin commented on pull request #306: JCRVLT-683 expect import of principal-based Authz to obey acHandling

2023-07-11 Thread via GitHub
adamcin commented on PR #306: URL: https://github.com/apache/jackrabbit-filevault/pull/306#issuecomment-1631266075 @kwin looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [jackrabbit-filevault] kwin commented on pull request #306: JCRVLT-683 expect import of principal-based Authz to obey acHandling

2023-07-11 Thread via GitHub
kwin commented on PR #306: URL: https://github.com/apache/jackrabbit-filevault/pull/306#issuecomment-1631222787 @adamcin I rebased your PR from #297 and added some documentation on top. Please cross-check one last time. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [jackrabbit-filevault] kwin commented on pull request #294: Bugfix/jcrvlt 683

2023-07-11 Thread via GitHub
kwin commented on PR #294: URL: https://github.com/apache/jackrabbit-filevault/pull/294#issuecomment-1631220764 Superseded by #297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [jackrabbit-filevault] kwin closed pull request #294: Bugfix/jcrvlt 683

2023-07-11 Thread via GitHub
kwin closed pull request #294: Bugfix/jcrvlt 683 URL: https://github.com/apache/jackrabbit-filevault/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [jackrabbit-filevault] kwin closed pull request #297: JCRVLT-683 expect import of principal-based Authz to obey acHandling rules

2023-07-11 Thread via GitHub
kwin closed pull request #297: JCRVLT-683 expect import of principal-based Authz to obey acHandling rules URL: https://github.com/apache/jackrabbit-filevault/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [jackrabbit-filevault] kwin commented on pull request #297: JCRVLT-683 expect import of principal-based Authz to obey acHandling rules

2023-07-11 Thread via GitHub
kwin commented on PR #297: URL: https://github.com/apache/jackrabbit-filevault/pull/297#issuecomment-1631219943 Superseded by #306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #1012: OAK-10333 Improved logging for queries that that traverse 20'000 nodes

2023-07-11 Thread via GitHub
joerghoh commented on code in PR #1012: URL: https://github.com/apache/jackrabbit-oak/pull/1012#discussion_r1260025107 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/cursor/TraversingCursor.java: ## @@ -159,10 +159,15 @@ private void fetchNext() {

[GitHub] [jackrabbit-filevault] kwin opened a new pull request, #306: JCRVLT-683 expect import of principal-based Authz to obey acHandling

2023-07-11 Thread via GitHub
kwin opened a new pull request, #306: URL: https://github.com/apache/jackrabbit-filevault/pull/306 rules Optionally restore principal ACLs after import Introduced feature flag: vault.feature.stashPrincipalPolicies -- This is an automated message from the Apache Git Service. T

[jira] [Commented] (JCR-4942) spi-commons: bump minor version number of o.a.j.spi.commons.conversion

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742089#comment-17742089 ] Julian Reschke commented on JCR-4942: - trunk: [r1910940|http://svn.apache.org/r1910940]

[jira] [Updated] (JCR-4942) spi-commons: bump minor version number of o.a.j.spi.commons.conversion

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4942: Labels: candidate_jackrabbit_2_20 (was: ) > spi-commons: bump minor version number of o.a.j.spi.comm

[jira] [Resolved] (JCR-4942) spi-commons: bump minor version number of o.a.j.spi.commons.conversion

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4942. - Resolution: Fixed > spi-commons: bump minor version number of o.a.j.spi.commons.conversion > --

[jira] [Updated] (JCR-4942) spi-commons: bump minor version number of o.a.j.spi.commons.conversion

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4942: Fix Version/s: 2.21.17 Status: In Progress (was: Patch Available) > spi-commons: bump min

[jira] [Comment Edited] (JCR-4942) spi-commons: bump minor version number of o.a.j.spi.commons.conversion

2023-07-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCR-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742075#comment-17742075 ] Konrad Windszus edited comment on JCR-4942 at 7/11/23 3:29 PM: --

[jira] [Commented] (JCR-4942) spi-commons: bump minor version number of o.a.j.spi.commons.conversion

2023-07-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCR-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742075#comment-17742075 ] Konrad Windszus commented on JCR-4942: -- 2.5.0 please, as micro version increments like

[jira] [Commented] (JCR-4942) spi-commons: bump minor version number of o.a.j.spi.commons.conversion

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742071#comment-17742071 ] Julian Reschke commented on JCR-4942: - So should it be 2.4.1 or 2.5.0? Pick one :), [~k

[jira] [Resolved] (JCR-4937) jcr-tests: get rid of duplicate XMLChar class

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4937. - Resolution: Fixed > jcr-tests: get rid of duplicate XMLChar class > ---

[GitHub] [jackrabbit-oak] adamcin commented on pull request #1013: OAK-10335 TypeEditor misapplies default primary type of child node to its parent when the child primary type is not set

2023-07-11 Thread via GitHub
adamcin commented on PR #1013: URL: https://github.com/apache/jackrabbit-oak/pull/1013#issuecomment-1631038154 > @adamcin , please don't add unrelated changes to this PR like changing variable names. it makes it hard to identify the effective changes you are making. > > as far as the

[jira] [Commented] (JCR-4352) Update lucene-core dependency to 3.6.2

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742061#comment-17742061 ] Julian Reschke commented on JCR-4352: - trunk: [r1910939|http://svn.apache.org/r1910939]

[jira] [Resolved] (JCR-4352) Update lucene-core dependency to 3.6.2

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4352. - Fix Version/s: 2.22 2.21.17 Resolution: Fixed > Update lucene-core depend

[jira] [Assigned] (JCR-4352) Update lucene-core dependency to 3.6.2

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned JCR-4352: --- Assignee: Julian Reschke (was: Manfred Baedke) > Update lucene-core dependency to 3.6.2 > ---

[jira] [Updated] (JCR-4352) Update lucene-core dependency to 3.6.2

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4352: Status: In Progress (was: Patch Available) > Update lucene-core dependency to 3.6.2 > --

[jira] [Commented] (JCR-4570) WebdavRequestImpl does not check ETags if there is no resource or no exclusive write lock

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742024#comment-17742024 ] Julian Reschke commented on JCR-4570: - Did you run all tests...?   I'm seeing: {nofor

[GitHub] [jackrabbit-oak] kwin merged pull request #1014: OAK-10332 Allow reusing FilterProviderImpl outside OSGi context

2023-07-11 Thread via GitHub
kwin merged PR #1014: URL: https://github.com/apache/jackrabbit-oak/pull/1014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit

[GitHub] [jackrabbit-filevault] kwin commented on pull request #303: Bump h2 from 2.1.212 to 2.2.220 in /vault-core

2023-07-11 Thread via GitHub
kwin commented on PR #303: URL: https://github.com/apache/jackrabbit-filevault/pull/303#issuecomment-1630827258 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #1014: OAK-10332 Allow reusing FilterProviderImpl outside OSGi context

2023-07-11 Thread via GitHub
kwin commented on code in PR #1014: URL: https://github.com/apache/jackrabbit-oak/pull/1014#discussion_r1259713036 ## oak-authorization-principalbased/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/principalbased/impl/FilterProviderImpl.java: ## @@ -98,19 +10

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #1014: OAK-10332 Allow reusing FilterProviderImpl outside OSGi context

2023-07-11 Thread via GitHub
kwin commented on code in PR #1014: URL: https://github.com/apache/jackrabbit-oak/pull/1014#discussion_r1259711992 ## oak-authorization-principalbased/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/principalbased/impl/FilterProviderImpl.java: ## @@ -98,19 +10

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #1014: OAK-10332 Allow reusing FilterProviderImpl outside OSGi context

2023-07-11 Thread via GitHub
kwin commented on code in PR #1014: URL: https://github.com/apache/jackrabbit-oak/pull/1014#discussion_r1259710323 ## oak-authorization-principalbased/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/principalbased/impl/FilterProviderImpl.java: ## @@ -76,6 +76,

[jira] [Commented] (JCR-4945) Ensure OSGi-enabled Jackrabbit bundles deploy in environments featuring only Slf4j v2 or even Tika v2.8

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741992#comment-17741992 ] Julian Reschke commented on JCR-4945: - Yes, would be good to parametrize this. Will hav

[jira] [Commented] (JCR-4944) upgrade to Tomcat 9.x

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741986#comment-17741986 ] Julian Reschke commented on JCR-4944: - trunk: [r1910937|http://svn.apache.org/r1910937]

[jira] [Updated] (JCR-4944) upgrade to Tomcat 9.x

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4944: Fix Version/s: 2.22 2.21.17 Resolution: Fixed Status: Resolved (

[jira] [Updated] (JCR-4944) upgrade to Tomcat 9.x

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4944: Labels: candidate_jackrabbit_2_20 (was: ) > upgrade to Tomcat 9.x > - > >

[jira] [Assigned] (JCR-4944) upgrade to Tomcat 9.x

2023-07-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned JCR-4944: --- Assignee: Julian Reschke (was: Manfred Baedke) > upgrade to Tomcat 9.x >

[GitHub] [jackrabbit] dependabot[bot] commented on pull request #137: Bump h2 from 2.1.214 to 2.2.220 in /jackrabbit-core

2023-07-11 Thread via GitHub
dependabot[bot] commented on PR #137: URL: https://github.com/apache/jackrabbit/pull/137#issuecomment-1630753747 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, le

[GitHub] [jackrabbit] asfgit closed pull request #137: Bump h2 from 2.1.214 to 2.2.220 in /jackrabbit-core

2023-07-11 Thread via GitHub
asfgit closed pull request #137: Bump h2 from 2.1.214 to 2.2.220 in /jackrabbit-core URL: https://github.com/apache/jackrabbit/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #1011: OAK-10334: Node.addMixin() may overwrite existing mixins

2023-07-11 Thread via GitHub
anchela commented on code in PR #1011: URL: https://github.com/apache/jackrabbit-oak/pull/1011#discussion_r1259542606 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java: ## @@ -1015,6 +1015,9 @@ public void checkPreconditions() throws RepositoryExcepti

[GitHub] [jackrabbit-filevault] kwin merged pull request #305: Feature/fix sonarcloud

2023-07-11 Thread via GitHub
kwin merged PR #305: URL: https://github.com/apache/jackrabbit-filevault/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

[GitHub] [jackrabbit-filevault] kwin opened a new pull request, #305: Feature/fix sonarcloud

2023-07-11 Thread via GitHub
kwin opened a new pull request, #305: URL: https://github.com/apache/jackrabbit-filevault/pull/305 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #1014: OAK-10332 Allow reusing FilterProviderImpl outside OSGi context

2023-07-11 Thread via GitHub
anchela commented on code in PR #1014: URL: https://github.com/apache/jackrabbit-oak/pull/1014#discussion_r1259349658 ## oak-authorization-principalbased/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/principalbased/impl/FilterProviderImpl.java: ## @@ -98,19