[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #293: OAK-9436 clean transient session storage after exceptions during import

2023-08-31 Thread via GitHub
github-actions[bot] commented on PR #293: URL: https://github.com/apache/jackrabbit-oak/pull/293#issuecomment-1701996876 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] adamcin opened a new pull request, #1094: OAK-10424 add support for FASTSIZE query option and related JCR privilege

2023-08-31 Thread via GitHub
adamcin opened a new pull request, #1094: URL: https://github.com/apache/jackrabbit-oak/pull/1094 - add SQL2 query option FASTSIZE - if oak.fastQuerySize is not enabled globally, require privilege `rep:queryOptionFastSize` on repository root path -- This is an automated message from

Re: [VOTE] Release Apache Jackrabbit Oak 1.56.0

2023-08-31 Thread Jörg Hoh
+1 with [INFO] Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) [INFO] OS name: "mac os x", version: "13.5.1", arch: "x86_64", family: "mac" [INFO] Java version: 11.0.15, vendor: Eclipse Adoptium, runtime: /Users/joerg/java/jdk-11.0.15+10-amd64/Contents/Home [INFO] MAVEN_OPTS:

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #1042: OAK-10358 - Filter by path on MongoDB query when downloading repository in Indexing job

2023-08-31 Thread via GitHub
nfsantos commented on code in PR #1042: URL: https://github.com/apache/jackrabbit-oak/pull/1042#discussion_r1311791210 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/filter/PathFilter.java: ## @@ -108,8 +108,7 @@ public static PathFilter from(@NotNull NodeBuilder

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #1093: OAK-10423 - Improve logging of metrics in the indexing job

2023-08-31 Thread via GitHub
nfsantos opened a new pull request, #1093: URL: https://github.com/apache/jackrabbit-oak/pull/1093 For each phase/task of the indexing job, log messages at the start and end following a standard format. The messages at the end include metrics in JSON format. Example: ```

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #1011: OAK-10334: Node.addMixin() may overwrite existing mixins

2023-08-31 Thread via GitHub
mreutegg commented on PR #1011: URL: https://github.com/apache/jackrabbit-oak/pull/1011#issuecomment-1701139009 > It looks like NodeDelegate.removeMixin has some check to see if the to-be-removed mixin is actually part of the current mixin list - and that check is IIUC done with the

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #1086: OAK-10420 Tool to compare Lucene index content

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #1086: URL: https://github.com/apache/jackrabbit-oak/pull/1086#issuecomment-1701014802 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #1086: OAK-10420 Tool to compare Lucene index content

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #1086: URL: https://github.com/apache/jackrabbit-oak/pull/1086#issuecomment-1700999461 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png

[GitHub] [jackrabbit-oak] tihom88 commented on pull request #1091: OAK-10413: DocumentStoreIndexerIT hanging

2023-08-31 Thread via GitHub
tihom88 commented on PR #1091: URL: https://github.com/apache/jackrabbit-oak/pull/1091#issuecomment-1700966003 Reverted back old changes in abstract classes being used in various tests. And added an eventual assertion to check on lock -- This is an automated message from the Apache Git

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #1086: OAK-10420 Tool to compare Lucene index content

2023-08-31 Thread via GitHub
nfsantos commented on code in PR #1086: URL: https://github.com/apache/jackrabbit-oak/pull/1086#discussion_r1311543266 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/tools/IndexComparator.java: ## @@ -0,0 +1,247 @@ +/* Licensed to the Apache Software

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1086: OAK-10420 Tool to compare Lucene index content

2023-08-31 Thread via GitHub
thomasmueller commented on code in PR #1086: URL: https://github.com/apache/jackrabbit-oak/pull/1086#discussion_r1311534360 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/tools/IndexComparator.java: ## @@ -0,0 +1,230 @@ +/* Licensed to the Apache

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1086: OAK-10420 Tool to compare Lucene index content

2023-08-31 Thread via GitHub
thomasmueller commented on code in PR #1086: URL: https://github.com/apache/jackrabbit-oak/pull/1086#discussion_r1311532170 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/tools/IndexComparator.java: ## @@ -0,0 +1,230 @@ +/* Licensed to the Apache

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #1042: OAK-10358 - Filter by path on MongoDB query when downloading repository in Indexing job

2023-08-31 Thread via GitHub
fabriziofortino commented on code in PR #1042: URL: https://github.com/apache/jackrabbit-oak/pull/1042#discussion_r1311520804 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/filter/PathFilter.java: ## @@ -108,8 +108,7 @@ public static PathFilter from(@NotNull

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #1079: OAK-10378 : added metrics to collect detailedGC cycle & deleted properties data

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #1079: URL: https://github.com/apache/jackrabbit-oak/pull/1079#issuecomment-1700725917 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #1042: OAK-10358 - Filter by path on MongoDB query when downloading repository in Indexing job

2023-08-31 Thread via GitHub
nfsantos commented on code in PR #1042: URL: https://github.com/apache/jackrabbit-oak/pull/1042#discussion_r1311356431 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java: ## @@ -225,12 +282,96 @@

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #1042: OAK-10358 - Filter by path on MongoDB query when downloading repository in Indexing job

2023-08-31 Thread via GitHub
nfsantos commented on code in PR #1042: URL: https://github.com/apache/jackrabbit-oak/pull/1042#discussion_r1311353211 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedIT.java: ## @@ -66,52 +69,95 @@ public class

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1042: OAK-10358 - Filter by path on MongoDB query when downloading repository in Indexing job

2023-08-31 Thread via GitHub
thomasmueller commented on code in PR #1042: URL: https://github.com/apache/jackrabbit-oak/pull/1042#discussion_r1311341613 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java: ## @@ -225,12

[GitHub] [jackrabbit-oak] tihom88 opened a new pull request, #1092: Revert oak 10273 10381

2023-08-31 Thread via GitHub
tihom88 opened a new pull request, #1092: URL: https://github.com/apache/jackrabbit-oak/pull/1092 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [jackrabbit-oak] jsedding commented on pull request #161: Clarified a pitfall with --merge-paths

2023-08-31 Thread via GitHub
jsedding commented on PR #161: URL: https://github.com/apache/jackrabbit-oak/pull/161#issuecomment-1700518621 @stefan-egli yes, I think this is helpful information and should be applied! @sbluhm sorry this fell between the cracks! -- This is an automated message from the Apache Git

[GitHub] [jackrabbit-oak] tihom88 opened a new pull request, #1091: OAK-10413: DocumentStoreIndexerIT hanging

2023-08-31 Thread via GitHub
tihom88 opened a new pull request, #1091: URL: https://github.com/apache/jackrabbit-oak/pull/1091 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To