AW: [DISCUSS] RMI support in Jackrabbit

2023-09-18 Thread KÖLL Claus via dev
+1 on deprecating. our stopper of removing it is JCR-4954 greets claus

Re: [DISCUSS] RMI support in Jackrabbit

2023-09-18 Thread Woonsan Ko
On Mon, Sep 18, 2023 at 8:50 PM Julian Reschke wrote: > > To whom it may concern... > > Jackrabbit's RMI support has been essentially unmaintained for half a > decade now, and also does not support JCR 2.0. > > We recently had to go into emergence mode due to vulnerabilities of > components used b

[GitHub] [jackrabbit-oak] adamcin commented on pull request #1094: OAK-10424 add support for INSECURE RESULT SIZE and INSECURE FACETS query options and rep:insecureQueryOptions privilege

2023-09-18 Thread via GitHub
adamcin commented on PR #1094: URL: https://github.com/apache/jackrabbit-oak/pull/1094#issuecomment-1724298220 @thomasmueller I don't have commit rights, so if you are willing to merge it, please do. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #1094: OAK-10424 add support for INSECURE RESULT SIZE and INSECURE FACETS query options and rep:insecureQueryOptions privilege

2023-09-18 Thread via GitHub
nfsantos commented on code in PR #1094: URL: https://github.com/apache/jackrabbit-oak/pull/1094#discussion_r1329183290 ## oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/ResultSizeTest.java: ## @@ -126,5 +151,90 @@ private void doTestResultSize(boolean union, int ex

[GitHub] [jackrabbit-oak] adamcin commented on a diff in pull request #1094: OAK-10424 add support for INSECURE RESULT SIZE and INSECURE FACETS query options and rep:insecureQueryOptions privilege

2023-09-18 Thread via GitHub
adamcin commented on code in PR #1094: URL: https://github.com/apache/jackrabbit-oak/pull/1094#discussion_r1329116561 ## oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/ResultSizeTest.java: ## @@ -126,5 +151,90 @@ private void doTestResultSize(boolean union, int exp

[jira] [Updated] (JCR-4954) Problem with WebDav Client and Repository Server Deployment Model

2023-09-18 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4954: Fix Version/s: (was: 2.21.20) > Problem with WebDav Client and Repository Server Deployment Model

[jira] [Resolved] (JCR-4968) Release Jackrabbit 2.20.12

2023-09-18 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4968. - Resolution: Fixed > Release Jackrabbit 2.20.12 > -- > > Key

[jira] [Closed] (JCR-4968) Release Jackrabbit 2.20.12

2023-09-18 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke closed JCR-4968. --- > Release Jackrabbit 2.20.12 > -- > > Key: JCR-4968 >

[GitHub] [jackrabbit-oak] mbaedke commented on a diff in pull request #1051: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-18 Thread via GitHub
mbaedke commented on code in PR #1051: URL: https://github.com/apache/jackrabbit-oak/pull/1051#discussion_r1328738960 ## oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java: ## @@ -362,6 +363,68 @@ public void testIsCheckedOutOnNonAccessibleParent()

[GitHub] [jackrabbit-oak] mbaedke commented on a diff in pull request #1051: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-18 Thread via GitHub
mbaedke commented on code in PR #1051: URL: https://github.com/apache/jackrabbit-oak/pull/1051#discussion_r1328738094 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java: ## @@ -212,7 +212,7 @@ private boolean isLockProperty(PropertyState state

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
nit0906 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328611316 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStore.java: ## @@ -38,12 +38,13 @@ public class FlatFileStore

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
nit0906 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328610279 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalStore.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to

[DISCUSS] RMI support in Jackrabbit

2023-09-18 Thread Julian Reschke
To whom it may concern... Jackrabbit's RMI support has been essentially unmaintained for half a decade now, and also does not support JCR 2.0. We recently had to go into emergence mode due to vulnerabilities of components used by us when accessed over RMI (see https://nvd.nist.gov/vuln/detail/CV

[jira] [Created] (JCR-4973) Deprecate RMI support

2023-09-18 Thread Julian Reschke (Jira)
Julian Reschke created JCR-4973: --- Summary: Deprecate RMI support Key: JCR-4973 URL: https://issues.apache.org/jira/browse/JCR-4973 Project: Jackrabbit Content Repository Issue Type: Task

[jira] [Created] (JCR-4972) Remove RMI support

2023-09-18 Thread Julian Reschke (Jira)
Julian Reschke created JCR-4972: --- Summary: Remove RMI support Key: JCR-4972 URL: https://issues.apache.org/jira/browse/JCR-4972 Project: Jackrabbit Content Repository Issue Type: Task

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
thomasmueller commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328501037 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -244,73 +255,83 @@ public F

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
thomasmueller commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328488621 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public stati

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
thomasmueller commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328477148 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public stati

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
thomasmueller commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328464274 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public stati

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
thomasmueller commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328472985 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/MultithreadedTraverseWithSortStrategy.java: ## @@ -234,18 +230,4

[GitHub] [jackrabbit-oak] steffenvan commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
steffenvan commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328473625 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static S

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
thomasmueller commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328465143 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public stati

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
fabriziofortino commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328370222 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java: ## @@ -207,6 +211,30 @@ private List bu

[GitHub] [jackrabbit-oak] steffenvan commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
steffenvan commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328378793 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static S

[GitHub] [jackrabbit-oak] steffenvan commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
steffenvan commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328420664 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/MergeIncrementalFlatFileStore.java: ## @@ -0,0 +1,155 @@ +/

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #1051: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-18 Thread via GitHub
mreutegg commented on code in PR #1051: URL: https://github.com/apache/jackrabbit-oak/pull/1051#discussion_r1328414603 ## oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java: ## @@ -362,6 +363,68 @@ public void testIsCheckedOutOnNonAccessibleParent()

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #1051: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-18 Thread via GitHub
mreutegg commented on code in PR #1051: URL: https://github.com/apache/jackrabbit-oak/pull/1051#discussion_r1328398490 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java: ## @@ -212,7 +212,7 @@ private boolean isLockProperty(PropertyState stat

[GitHub] [jackrabbit-oak] steffenvan commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
steffenvan commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328378793 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static S

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
nit0906 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328366187 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static Stri

[GitHub] [jackrabbit-oak] steffenvan commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-18 Thread via GitHub
steffenvan commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328332017 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -244,73 +255,83 @@ public Flat