Re: [PR] OAK-10472 - Move ApproximateCounter from oak-core to a place where it… [jackrabbit-oak]

2023-10-06 Thread via GitHub
sonarcloud[bot] commented on PR #1139: URL: https://github.com/apache/jackrabbit-oak/pull/1139#issuecomment-1751108880 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Qual

[PR] OAK-10472 - Move ApproximateCounter from oak-core to a place where it… [jackrabbit-oak]

2023-10-06 Thread via GitHub
dulceanu opened a new pull request, #1139: URL: https://github.com/apache/jackrabbit-oak/pull/1139 … can be used by oak-segment-tar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] OAK-10463: Retrieve flatFileStore for indexing from baseFlatFileStore [jackrabbit-oak]

2023-10-06 Thread via GitHub
amit-jain commented on code in PR #1135: URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1348507719 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java: ## @@ -460,11 +603,20 @@ public static File sortAndSave(List tmplist,

Re: [PR] OAK-10463: Retrieve flatFileStore for indexing from baseFlatFileStore [jackrabbit-oak]

2023-10-06 Thread via GitHub
tihom88 commented on code in PR #1135: URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1348495689 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java: ## @@ -460,11 +602,21 @@ public static File sortAndSave(List tmplist,

Re: [PR] OAK-10451 UserPrincipalProvider may cause many conflicts when under load [jackrabbit-oak]

2023-10-06 Thread via GitHub
nscendoni commented on code in PR #1128: URL: https://github.com/apache/jackrabbit-oak/pull/1128#discussion_r1348475708 ## oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserPrincipalProviderCommitterProvider.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

Re: [VOTE] Release Apache Jackrabbit 2.21.20

2023-10-06 Thread Manfred Baedke
[X] +1 Release this package as Apache Jackrabbit 2.21.20 with [INFO] Apache Maven 3.9.2 (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c) [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" [INFO] Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: D:\java\jdk-8\jre

Re: [PR] OAK-10465 : backported changes to 1.22 branch [jackrabbit-oak]

2023-10-06 Thread via GitHub
rishabhdaim commented on PR #1138: URL: https://github.com/apache/jackrabbit-oak/pull/1138#issuecomment-1750115336 I created a separate PR because the changes are a bit different for the `1.22` branch. Maven scope is `compile` for `1.22` whereas it is provided for the `trunk`. -- This

Re: [VOTE] Release Apache Jackrabbit 2.21.20

2023-10-06 Thread Rishabh Daim
[X] +1 Release this package as Apache Jackrabbit 2.21.20 On Fri, Oct 6, 2023 at 10:03 AM Julian Reschke wrote: > On 06.10.2023 06:24, Julian Reschke wrote: > > ... > > [X] +1 Release this package as Apache Jackrabbit 2.21.20 > > ...where... > > > [INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50