[RESULT] [VOTE] Release Apache Jackrabbit 2.21.20

2023-10-10 Thread Julian Reschke
On 06.10.2023 06:24, Julian Reschke wrote: ... Hi there, The vote passes as follows: +1 Angela Schreiber via dev +1 Julian Reschke +1 Manfred Baedke +1 Rishabh Daim +1 Woonsan Ko Thanks for voting. I'll push the release out. Best regards, Julian

Re: [VOTE] Release Apache Jackrabbit 2.21.20

2023-10-10 Thread Woonsan Ko
[X] +1 Release this package as Apache Jackrabbit 2.21.20 ...where... [INFO] Apache Maven 3.9.2 (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c) [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" [INFO] Java version: 1.8.0_371, vendor: Oracle Corporation, runtime: C:\Java\jd

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352503502 ## oak-segment-azure/src/test/resources/logback-test.xml: ## @@ -21,11 +21,19 @@ %d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%

Re: [PR] OAK-10474: Release Oak 1.58.0 [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke merged PR #1145: URL: https://github.com/apache/jackrabbit-oak/pull/1145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-6760: Convert oak-blob-cloud to OSGi R6 annotations [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke commented on code in PR #1144: URL: https://github.com/apache/jackrabbit-oak/pull/1144#discussion_r1352434938 ## oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3DataStoreService.java: ## @@ -19,10 +19,23 @@ package org.apache.jackrabbit.oak.blob

Re: [PR] OAK-6760: Convert oak-blob-cloud to OSGi R6 annotations [jackrabbit-oak]

2023-10-10 Thread via GitHub
kwin commented on code in PR #1144: URL: https://github.com/apache/jackrabbit-oak/pull/1144#discussion_r1352423985 ## oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3DataStoreService.java: ## @@ -19,10 +19,23 @@ package org.apache.jackrabbit.oak.blob.cl

Re: [PR] OAK-10474: Release Oak 1.58.0 [jackrabbit-oak]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #1145: URL: https://github.com/apache/jackrabbit-oak/pull/1145#issuecomment-1755339607 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352344860 ## oak-lucene/pom.xml: ## @@ -471,5 +471,11 @@ 1.19.0 test + Review Comment: I was/am confused because I would have assumed that swit

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
t-rana commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352342828 ## oak-lucene/pom.xml: ## @@ -471,5 +471,11 @@ 1.19.0 test + Review Comment: No, testcontainers dependency is defined under dependency

Re: [PR] OAK-6760: Convert oak-blob-cloud to OSGi R6 annotations [jackrabbit-oak]

2023-10-10 Thread via GitHub
sonarcloud[bot] commented on PR #1144: URL: https://github.com/apache/jackrabbit-oak/pull/1144#issuecomment-1755239775 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Qual

[PR] OAK-10474: Release Oak 1.58.0 [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke opened a new pull request, #1145: URL: https://github.com/apache/jackrabbit-oak/pull/1145 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
t-rana commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352270547 ## oak-blob-cloud-azure/pom.xml: ## @@ -191,10 +191,10 @@ mockito-core test - -com.arakelian -

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
t-rana commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352268966 ## oak-segment-azure/src/test/resources/logback-test.xml: ## @@ -21,11 +21,19 @@ %d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n

[PR] OAK-6760: Convert oak-blob-cloud to OSGi R6 annotations [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke opened a new pull request, #1144: URL: https://github.com/apache/jackrabbit-oak/pull/1144 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352092119 ## oak-blob-cloud-azure/pom.xml: ## @@ -191,10 +191,10 @@ mockito-core test - -com.arakelian -

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352130678 ## oak-lucene/pom.xml: ## @@ -471,5 +471,11 @@ 1.19.0 test + Review Comment: But isn't that automatically inherited? -- This is a

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
t-rana commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352125451 ## oak-lucene/pom.xml: ## @@ -471,5 +471,11 @@ 1.19.0 test + Review Comment: oak-lucene uses the MongoConnectionFactory in IT(s) [htt

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
t-rana commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352125451 ## oak-lucene/pom.xml: ## @@ -471,5 +471,11 @@ 1.19.0 test + Review Comment: oak lucene uses the MongoConnectionFactory in IT(s) whic

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352117183 ## oak-segment-azure/src/test/resources/logback-test.xml: ## @@ -21,11 +21,19 @@ %d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
t-rana commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352111852 ## oak-segment-azure/src/test/resources/logback-test.xml: ## @@ -21,11 +21,19 @@ %d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n

Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
reschke commented on code in PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352093896 ## oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzuriteDockerRule.java: ## @@ -16,55 +16,88 @@ */ package org.apa

[PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]

2023-10-10 Thread via GitHub
t-rana opened a new pull request, #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] OAK-10475 - Expose the Mongo client connection in MongoDocumentNodeStoreBuilderBase [jackrabbit-oak]

2023-10-10 Thread via GitHub
thomasmueller merged PR #1142: URL: https://github.com/apache/jackrabbit-oak/pull/1142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@j

Re: [VOTE] Release Apache Jackrabbit 2.21.20

2023-10-10 Thread Angela Schreiber via dev
+1 thanks and kind regards angela From: Julian Reschke Sent: Friday, October 6, 2023 06:24 To: dev@jackrabbit.apache.org Subject: [VOTE] Release Apache Jackrabbit 2.21.20 EXTERNAL: Use caution when clicking on links or opening attachments. A candidate for the

Re: [PR] OAK-10475 - Expose the Mongo client connection in MongoDocumentNodeStoreBuilderBase [jackrabbit-oak]

2023-10-10 Thread via GitHub
nfsantos commented on code in PR #1142: URL: https://github.com/apache/jackrabbit-oak/pull/1142#discussion_r1351850691 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentNodeStoreBuilderBase.java: ## @@ -212,6 +213,15 @@ MongoStatus

Re: [PR] OAK-10475 - Expose the Mongo client connection in MongoDocumentNodeStoreBuilderBase [jackrabbit-oak]

2023-10-10 Thread via GitHub
thomasmueller commented on code in PR #1142: URL: https://github.com/apache/jackrabbit-oak/pull/1142#discussion_r1351793356 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentNodeStoreBuilderBase.java: ## @@ -212,6 +213,15 @@ MongoS

Re: [PR] OAK-10462: o.a.j.o.plugins.version.VersionEditor#propertyAdded() may … [jackrabbit-oak]

2023-10-10 Thread via GitHub
mbaedke commented on code in PR #1141: URL: https://github.com/apache/jackrabbit-oak/pull/1141#discussion_r1351745688 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java: ## @@ -108,9 +112,15 @@ public void propertyAdded(PropertyState after)

Re: [PR] OAK-10462: o.a.j.o.plugins.version.VersionEditor#propertyAdded() may … [jackrabbit-oak]

2023-10-10 Thread via GitHub
mbaedke commented on code in PR #1141: URL: https://github.com/apache/jackrabbit-oak/pull/1141#discussion_r1351745688 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java: ## @@ -108,9 +112,15 @@ public void propertyAdded(PropertyState after)

Re: [PR] OAK-10462: o.a.j.o.plugins.version.VersionEditor#propertyAdded() may … [jackrabbit-oak]

2023-10-10 Thread via GitHub
mbaedke commented on code in PR #1141: URL: https://github.com/apache/jackrabbit-oak/pull/1141#discussion_r1351745688 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java: ## @@ -108,9 +112,15 @@ public void propertyAdded(PropertyState after)

Re: [PR] OAK-10462: o.a.j.o.plugins.version.VersionEditor#propertyAdded() may … [jackrabbit-oak]

2023-10-10 Thread via GitHub
rishabhdaim commented on code in PR #1141: URL: https://github.com/apache/jackrabbit-oak/pull/1141#discussion_r1351719204 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java: ## @@ -108,9 +112,15 @@ public void propertyAdded(PropertyState after