Re: [PR] OAK-10375: remove binary data from logs [jackrabbit-oak]

2024-03-18 Thread via GitHub
steffenvan commented on PR #1353: URL: https://github.com/apache/jackrabbit-oak/pull/1353#issuecomment-2004305989 Hmm as long as it doesn't violate any privacy concerns, I guess so. @reschke -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] OAK-6766: Convert oak-lucene to OSGi R7 annotations [jackrabbit-oak]

2024-03-18 Thread via GitHub
mbaedke commented on code in PR #1352: URL: https://github.com/apache/jackrabbit-oak/pull/1352#discussion_r1528585246 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java: ## @@ -368,13 +349,19 @@ public class LuceneIndexProv

Re: [PR] OAK-6766: Convert oak-lucene to OSGi R7 annotations [jackrabbit-oak]

2024-03-18 Thread via GitHub
mbaedke commented on code in PR #1352: URL: https://github.com/apache/jackrabbit-oak/pull/1352#discussion_r1528579036 ## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java: ## @@ -104,201 +107,178 @@ import static org.apache