Re: [PR] OAK-10764 : speed up gap orphan detection by limiting it to only the direct child of the greatest existing ancestor [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim merged PR #1420: URL: https://github.com/apache/jackrabbit-oak/pull/1420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566254677 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract class

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057530328 With https://github.com/apache/jackrabbit-oak/pull/1421 PR, we are skipping the opportunity to clean other types of garbage. If we want to go via https://github.com/apache/j

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566221648 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract class

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057474619 also note my alternative PR suggestion at https://github.com/apache/jackrabbit-oak/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566077327 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract class

[PR] OAK-10751 : added compaction support in oak-run [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim opened a new pull request, #1419: URL: https://github.com/apache/jackrabbit-oak/pull/1419 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim opened a new pull request, #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418 …existing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566077327 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract class

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566049288 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract class

[PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim opened a new pull request, #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-10761 : start gap test after greatest existing ancestor [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli merged PR #1414: URL: https://github.com/apache/jackrabbit-oak/pull/1414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10761 : start gap test after greatest existing ancestor [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on PR #1414: URL: https://github.com/apache/jackrabbit-oak/pull/1414#issuecomment-2057091565 this test was known to fail in the branch and is thus not related to this PR: ``` [INFO] Running org.apache.jackrabbit.oak.plugins.document.NodeDocumentRevisionCleanerTest

[PR] OAK-10762: dynamic boosted tags need to specify extra parameters [jackrabbit-oak]

2024-04-15 Thread via GitHub
fabriziofortino opened a new pull request, #1416: URL: https://github.com/apache/jackrabbit-oak/pull/1416 Similar queries leveraging dynamic tags might not produce relevant results in Elasticsearch. This happens because the default minimum term frequency in mlt queries is 2 while usually si

[PR] OAK-6761: Convert oak-blob-plugins to OSGi R7 annotations [jackrabbit-oak]

2024-04-15 Thread via GitHub
mbaedke opened a new pull request, #1415: URL: https://github.com/apache/jackrabbit-oak/pull/1415 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] OAK-6762: Convert oak-blob to OSGi R7 annotations [jackrabbit-oak]

2024-04-15 Thread via GitHub
mbaedke opened a new pull request, #1413: URL: https://github.com/apache/jackrabbit-oak/pull/1413 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on code in PR #1409: URL: https://github.com/apache/jackrabbit-oak/pull/1409#discussion_r1565623561 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -867,6 +880,8 @@ && canUseModifiedTimeIdx