Re: [PR] OAK-10780: add azure access token refresh logic [jackrabbit-oak]

2024-05-16 Thread via GitHub
t-rana commented on code in PR #1441: URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604391789 ## oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java: ## @@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes, i

Re: [PR] OAK-10780: add azure access token refresh logic [jackrabbit-oak]

2024-05-16 Thread via GitHub
t-rana commented on code in PR #1441: URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604391435 ## oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java: ## @@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes, i

Re: [PR] OAK-10739 : revert unrelated or unnecessary changes [jackrabbit-oak]

2024-05-16 Thread via GitHub
stefan-egli merged PR #1467: URL: https://github.com/apache/jackrabbit-oak/pull/1467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

[PR] OAK-10739 : revert unrelated or unnecessary changes [jackrabbit-oak]

2024-05-16 Thread via GitHub
stefan-egli opened a new pull request, #1467: URL: https://github.com/apache/jackrabbit-oak/pull/1467 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

2024-05-16 Thread via GitHub
stefan-egli commented on PR #1465: URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115770736 I'm wondering if that wouldn't introduce a regression elsewhere .. there must have been a reason this was set to 0 for read-only? -- This is an automated message from the Apa

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

2024-05-16 Thread via GitHub
mbaedke commented on PR #1465: URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115695591 Potential fix: if in DocumentNodeStore#getMinExternalRevisions() we replace getClusterId() - which is 0 in readonly mode - with the configured cluster id, the problem disappears.

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

2024-05-16 Thread via GitHub
mbaedke commented on PR #1465: URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115387932 Preliminary test. Please review if it makes any sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

2024-05-16 Thread via GitHub
mbaedke opened a new pull request, #1465: URL: https://github.com/apache/jackrabbit-oak/pull/1465 …ect results in readonly mode Added test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] OAK-10804 - Optimize check for hidden paths and clear warnings in NodeStateUtils class. [jackrabbit-oak]

2024-05-16 Thread via GitHub
nfsantos merged PR #1461: URL: https://github.com/apache/jackrabbit-oak/pull/1461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-16 Thread via GitHub
stefan-egli commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1603281901 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/LoggingDocumentStoreWrapper.java: ## @@ -283,6 +283,7 @@ public T call()

Re: [PR] OAK-10810 - Remove redundant call to StringCache.get in Path.fromString. [jackrabbit-oak]

2024-05-16 Thread via GitHub
nfsantos merged PR #1464: URL: https://github.com/apache/jackrabbit-oak/pull/1464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

[PR] OAK-10810 - Remove redundant call to StringCache.get in Path.fromString. [jackrabbit-oak]

2024-05-16 Thread via GitHub
nfsantos opened a new pull request, #1464: URL: https://github.com/apache/jackrabbit-oak/pull/1464 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Commented] (JCRVLT-754) check-release does not work for filevault anymore

2024-05-16 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846886#comment-17846886 ] Julian Reschke commented on JCRVLT-754: --- For the basenames, can we switch it for fi

[jira] [Commented] (JCRVLT-754) check-release does not work for filevault anymore

2024-05-16 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846885#comment-17846885 ] Julian Reschke commented on JCRVLT-754: --- Yes. So for the SHA1, the options appear t

[jira] [Comment Edited] (JCRVLT-754) check-release does not work for filevault anymore

2024-05-16 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846885#comment-17846885 ] Julian Reschke edited comment on JCRVLT-754 at 5/16/24 9:12 AM: ---

Re: [PR] OAK-10780: add azure access token refresh logic [jackrabbit-oak]

2024-05-16 Thread via GitHub
rootpea commented on code in PR #1441: URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1602892162 ## oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java: ## @@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,

Re: [PR] OAK-10780: add azure access token refresh logic [jackrabbit-oak]

2024-05-16 Thread via GitHub
rootpea commented on code in PR #1441: URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1602891748 ## oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java: ## @@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,

Re: [PR] OAK-10808 - Skip test if Mongo is not available. [jackrabbit-oak]

2024-05-16 Thread via GitHub
nfsantos merged PR #1463: URL: https://github.com/apache/jackrabbit-oak/pull/1463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

[jira] [Commented] (JCRVLT-754) check-release does not work for filevault anymore

2024-05-16 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846855#comment-17846855 ] Konrad Windszus commented on JCRVLT-754: bq. no sha1 is generated anymore; howeve

[jira] [Commented] (JCRVLT-742) Stop generating MD5, SHA1 and SHA512 with Ant

2024-05-16 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846854#comment-17846854 ] Konrad Windszus commented on JCRVLT-742: FTR: The SHA1 is still generated and use

[jira] [Assigned] (JCRVLT-754) check-release does not work for filevault anymore

2024-05-16 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned JCRVLT-754: -- Assignee: Konrad Windszus > check-release does not work for filevault anymore > --

[jira] [Commented] (JCRVLT-753) FORCE_REMOVE_CONFLICTING_ID Strategy Causing Constraint Violation Exception in AEM Replication

2024-05-16 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846849#comment-17846849 ] Konrad Windszus commented on JCRVLT-753: We should at least clarify the javadoc o