Re: [PR] Issue/oak 8848 [jackrabbit-oak]

2024-05-29 Thread via GitHub
shodaaan commented on code in PR #1474: URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1619342145 ## oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/MoveVersionableNodeWithMemoryRepositoryTest.java: ## @@ -0,0 +1,26 @@ +package org.apache.jackrabbit.oak.

[PR] OAK-10837: Add documentation for UT/IT NodeStore fixtures [jackrabbit-oak]

2024-05-29 Thread via GitHub
adelina-marian opened a new pull request, #1493: URL: https://github.com/apache/jackrabbit-oak/pull/1493 Added a new page in the public documentation about different nsfixtures that are available when running unit and integration tests. https://github.com/apache/jackrabbit-oak/assets/169

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -216,7 +264,7 @@ static PropertyState readPrope

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -216,7 +264,7 @@ static PropertyState readPrope

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747131 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -227,8 +275,8 @@ PropertyState readArrayPropert

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -216,7 +264,7 @@ static PropertyState readPrope

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -216,7 +264,7 @@ static PropertyState readPrope

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747131 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -227,8 +275,8 @@ PropertyState readArrayPropert

Re: [PR] OAK-10812: DocumentNodeStore#diffManyChildren(...) may produce incorr… [jackrabbit-oak]

2024-05-29 Thread via GitHub
mbaedke commented on PR #1465: URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2137187902 @stefan-egli , see ticket for an explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618651613 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -75,10 +82,97 @@ public void multiValuedBin

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618648423 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -227,8 +275,8 @@ PropertyState readArrayPropert

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618648931 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -216,7 +264,7 @@ static PropertyState readPrope

[PR] OAK-10451 UserPrincipalProvider may cause many conflicts when under load [jackrabbit-oak]

2024-05-29 Thread via GitHub
nscendoni opened a new pull request, #1128: URL: https://github.com/apache/jackrabbit-oak/pull/1128 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
stefan-egli commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618588187 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -75,10 +82,97 @@ public void multiValued

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
stefan-egli commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618581875 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -216,7 +264,7 @@ static PropertyState readPr

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618377176 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +88,83 @@ public void multiValuedBina

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618376854 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -227,8 +275,8 @@ PropertyState readArrayPropert

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618376527 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -116,7 +155,20 @@ public int count() { */

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-29 Thread via GitHub
ionutzpi commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618372804 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +43,58 @@ import org.apache.jackrabbit.