Re: [VOTE] Release Apache Jackrabbit 2.22.0

2024-06-10 Thread Julian Reschke
On 11.06.2024 05:46, Julian Reschke wrote: [X] +1 Release this package as Apache Jackrabbit 2.22.0 ...where... [INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" [INFO] Java version:

[VOTE] Release Apache Jackrabbit 2.22.0

2024-06-10 Thread Julian Reschke
A candidate for the Jackrabbit 2.22.0 release is available at: https://dist.apache.org/repos/dist/dev/jackrabbit/2.22.0/ The release candidate is a zip archive of the sources in: https://github.com/apache/jackrabbit/tree/jackrabbit-2.22.0/ The SHA1 checksum of the archive is

Re: [PR] OAK-10873: store-spi: remove use of Guava CharMatcher in test case [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos commented on code in PR #1516: URL: https://github.com/apache/jackrabbit-oak/pull/1516#discussion_r1633795354 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/json/JsonDeserializer.java: ## @@ -240,9 +239,10 @@ boolean hasOrderableChildren(NodeBuilder builder)

[PR] OAK-10873: store-spi: remove use of Guava CharMatcher in test case [jackrabbit-oak]

2024-06-10 Thread via GitHub
reschke opened a new pull request, #1516: URL: https://github.com/apache/jackrabbit-oak/pull/1516 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10872 - Replace use of StringBuilder by string concatenation in PathUtils.concat(String,String) [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos merged PR #1515: URL: https://github.com/apache/jackrabbit-oak/pull/1515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10872 - Replace use of StringBuilder by string concatenation in PathUtils.concat(String,String) [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos opened a new pull request, #1515: URL: https://github.com/apache/jackrabbit-oak/pull/1515 Using String concatenation in this case is much faster, because the JVM will use invokedynamic to concatenate the Strings. The method `PathUtils.concat(String, String)` is heavily used by

[jira] [Commented] (JCR-5073) core: avoid varargs related compiler warnings in tests

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853690#comment-17853690 ] Julian Reschke commented on JCR-5073: - trunk:

[jira] [Updated] (JCR-5073) core: avoid varargs related compiler warnings in tests

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-5073: Labels: candidate_jackrabbit_2.22 (was: ) > core: avoid varargs related compiler warnings in tests

[jira] [Resolved] (JCR-5073) core: avoid varargs related compiler warnings in tests

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-5073. - Fix Version/s: 2.23.0 Assignee: Julian Reschke Resolution: Fixed > core: avoid

[jira] [Updated] (JCR-5073) core: avoid varargs related compiler warnings in tests

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-5073: Fix Version/s: 2.24 > core: avoid varargs related compiler warnings in tests >

[jira] [Created] (JCR-5073) core: avoid varargs related compiler warnings in tests

2024-06-10 Thread Julian Reschke (Jira)
Julian Reschke created JCR-5073: --- Summary: core: avoid varargs related compiler warnings in tests Key: JCR-5073 URL: https://issues.apache.org/jira/browse/JCR-5073 Project: Jackrabbit Content Repository

[PR] OAK-10870 : New oak-mongo.js methods for sizes of properties, counts … [jackrabbit-oak]

2024-06-10 Thread via GitHub
stefan-egli opened a new pull request, #1514: URL: https://github.com/apache/jackrabbit-oak/pull/1514 …by clusterId and unmerged branch commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (JCRVLT-755) All contents are deleted when a content package created from a folder is applied

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853663#comment-17853663 ] Julian Reschke commented on JCRVLT-755: --- Aha, I see. [~cschneider] - so do you actually see a

[jira] [Commented] (JCRVLT-755) All contents are deleted when a content package created from a folder is applied

2024-06-10 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853661#comment-17853661 ] Konrad Windszus commented on JCRVLT-755: bq. In that case I'd expect it to be replaced by an

[jira] [Commented] (JCRVLT-755) All contents are deleted when a content package created from a folder is applied

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853644#comment-17853644 ] Julian Reschke commented on JCRVLT-755: --- In that case I'd expect it to be replaced by an empty

[jira] [Comment Edited] (JCRVLT-755) All contents are deleted when a content package created from a folder is applied

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853634#comment-17853634 ] Julian Reschke edited comment on JCRVLT-755 at 6/10/24 12:33 PM: - In both

[jira] [Commented] (JCRVLT-755) All contents are deleted when a content package created from a folder is applied

2024-06-10 Thread Christian Schneider (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853643#comment-17853643 ] Christian Schneider commented on JCRVLT-755: Import mode is replace. As far as I can tell the

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos merged PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (JCRVLT-755) All contents are deleted when a content package created from a folder is applied

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853634#comment-17853634 ] Julian Reschke commented on JCRVLT-755: --- In both ZIPs I see "test4" as empty node. What is the

[PR] OAK-10867: add service principal support in oak-run commons [jackrabbit-oak]

2024-06-10 Thread via GitHub
t-rana opened a new pull request, #1513: URL: https://github.com/apache/jackrabbit-oak/pull/1513 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10868 - Use a constant to represent empty StringValue to avoid allocating new objects in this particular case [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos merged PR #1512: URL: https://github.com/apache/jackrabbit-oak/pull/1512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
reschke commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632871987 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -275,6 +278,34 @@ public static String encode(String s) {

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632869189 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -275,6 +278,34 @@ public static String encode(String s) {

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
reschke commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632861940 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -275,6 +278,34 @@ public static String encode(String s) {

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632857995 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -197,9 +197,11 @@ public JsopBuilder value(boolean value) { *

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632859435 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -275,6 +277,34 @@ public static String encode(String s) {

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
nfsantos commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632858732 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -275,6 +277,34 @@ public static String encode(String s) {

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
reschke commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632842172 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -197,9 +197,11 @@ public JsopBuilder value(boolean value) { *

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
reschke commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632840377 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -275,6 +277,34 @@ public static String encode(String s) {

Re: [PR] OAK-10866 - Avoid creating an intermediate String when appending a string value to a JsopBuilder. [jackrabbit-oak]

2024-06-10 Thread via GitHub
reschke commented on code in PR #1511: URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632839219 ## oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java: ## @@ -275,6 +277,34 @@ public static String encode(String s) {

Jackrabbit 2.22.0 Release Plan

2024-06-10 Thread Julian Reschke
Hi, I'm planning to cut Jackrabbit 2.22.0 tomorrow. Note that this will be the first release in the new Java 11 based maintenance branch. The list of open issues scheduled for 2.22.0 is empty:

[jira] [Updated] (JCR-4892) support the jakarta.servlet package name

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4892: Fix Version/s: 2.24 > support the jakarta.servlet package name >

[jira] [Updated] (JCR-3943) [jackrabbi-aws-ext] Data inconsistency due to race condition during async uploads

2024-06-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCR-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-3943: Fix Version/s: (was: 2.22) (was: 2.22.0) > [jackrabbi-aws-ext] Data

[jira] [Commented] (JCRVLT-755) All contents are deleted when a content package created from a folder is applied

2024-06-10 Thread Christian Schneider (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853571#comment-17853571 ] Christian Schneider commented on JCRVLT-755: [~kwin] [~julian.resc...@gmx.de] I am looking