[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-09-05 Thread GitBox
mreutegg commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r962907614 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1924,15 +1924,15 @@ public void

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-09-05 Thread GitBox
mreutegg commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r962886110 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongodProcessFactory.java: ## @@ -145,7 +147,8 @@ private void initRS(String

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-09-05 Thread GitBox
mreutegg commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r962881316 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoTestClient.java: ## @@ -16,31 +16,136 @@ */ package

[GitHub] [jackrabbit] ArunOnCloud opened a new pull request, #127: JCR-4837:Removal of version of a node should remove associated labels

2022-09-05 Thread GitBox
ArunOnCloud opened a new pull request, #127: URL: https://github.com/apache/jackrabbit/pull/127 …ociated labels -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [jackrabbit-oak] ArunOnCloud opened a new pull request, #688: Removal (purge) of version of a node does not remove associated labels

2022-09-05 Thread GitBox
ArunOnCloud opened a new pull request, #688: URL: https://github.com/apache/jackrabbit-oak/pull/688 pull request for issue : OAK-9891 mail thread link: https://lists.apache.org/thread/b1g2f3cxxfpfnqxzr3oz20lyp8676tnm -- This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-09-05 Thread GitBox
mreutegg commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r962869974 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreServiceTest.java: ## @@ -203,42 +189,6 @@ public void

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-09-05 Thread GitBox
mreutegg commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r962854092 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/MongoConnection.java: ## @@ -142,41 +153,53 @@ public void close() { *

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-09-05 Thread GitBox
mreutegg commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r962846775 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentNodeStoreBuilderBase.java: ## @@ -104,18 +103,11 @@ public T

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-09-05 Thread GitBox
mreutegg commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r962842807 ## oak-store-document/pom.xml: ## @@ -44,8 +44,8 @@ ${guava.osgi.import}, - com.mongodb*;version="[3.8,

[GitHub] [jackrabbit-filevault] kwin opened a new pull request, #244: JCRVLT-598: apply default id conflict policy as late as possible

2022-09-04 Thread GitBox
kwin opened a new pull request, #244: URL: https://github.com/apache/jackrabbit-filevault/pull/244 fix incorrect overwrite of explicit policy apply default also for FSPackages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [jackrabbit-oak] yesil closed pull request #40: Setting correct node types according Oak documentation.

2022-09-03 Thread GitBox
yesil closed pull request #40: Setting correct node types according Oak documentation. URL: https://github.com/apache/jackrabbit-oak/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] jsedding commented on pull request #685: OAK-9914 - Starting Oak with Azure persistence in read-only mode whil…

2022-09-02 Thread GitBox
jsedding commented on PR #685: URL: https://github.com/apache/jackrabbit-oak/pull/685#issuecomment-1235643641 Thanks @smiroslav! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jackrabbit-oak] jsedding merged pull request #685: OAK-9914 - Starting Oak with Azure persistence in read-only mode whil…

2022-09-02 Thread GitBox
jsedding merged PR #685: URL: https://github.com/apache/jackrabbit-oak/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-09-02 Thread GitBox
fabriziofortino merged PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] smiroslav closed pull request #686: OAK-9914 read-only mode for Azure segment store does not start recovery if archive is not closed

2022-09-02 Thread GitBox
smiroslav closed pull request #686: OAK-9914 read-only mode for Azure segment store does not start recovery if archive is not closed URL: https://github.com/apache/jackrabbit-oak/pull/686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [jackrabbit-oak] smiroslav commented on pull request #686: OAK-9914 read-only mode for Azure segment store does not start recovery if archive is not closed

2022-09-02 Thread GitBox
smiroslav commented on PR #686: URL: https://github.com/apache/jackrabbit-oak/pull/686#issuecomment-1235511076 Closing in favor of https://github.com/apache/jackrabbit-oak/pull/685/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-oak] dulceanu merged pull request #687: OAK-9920 - ExternalPrivateStoreIT.testSyncBigBlob failures

2022-09-02 Thread GitBox
dulceanu merged PR #687: URL: https://github.com/apache/jackrabbit-oak/pull/687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] dulceanu opened a new pull request, #687: OAK-9920 - ExternalPrivateStoreIT.testSyncBigBlob failures

2022-09-02 Thread GitBox
dulceanu opened a new pull request, #687: URL: https://github.com/apache/jackrabbit-oak/pull/687 Increased client read timeout to 4 mins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] smiroslav opened a new pull request, #686: OAK-9914 read-only mode for Azure segment store does not start recovery if archive is not closed

2022-09-02 Thread GitBox
smiroslav opened a new pull request, #686: URL: https://github.com/apache/jackrabbit-oak/pull/686 https://issues.apache.org/jira/browse/OAK-9914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-09-02 Thread GitBox
thomasmueller commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r961500375 ## oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneFacetCommonTest.java: ## @@ -46,13 +44,6 @@ protected Repository

[GitHub] [jackrabbit-filevault-package-maven-plugin] dependabot[bot] closed pull request #76: build(deps): bump jsoup from 1.10.3 to 1.14.2 in /src/test/resources/test-projects/manifest-generation/wit

2022-09-01 Thread GitBox
dependabot[bot] closed pull request #76: build(deps): bump jsoup from 1.10.3 to 1.14.2 in /src/test/resources/test-projects/manifest-generation/with-unused-parent-dependencies URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/76 -- This is an automated message

[GitHub] [jackrabbit-filevault-package-maven-plugin] dependabot[bot] commented on pull request #76: build(deps): bump jsoup from 1.10.3 to 1.14.2 in /src/test/resources/test-projects/manifest-generati

2022-09-01 Thread GitBox
dependabot[bot] commented on PR #76: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/76#issuecomment-1234852672 Superseded by #83. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-filevault-package-maven-plugin] dependabot[bot] opened a new pull request, #83: build(deps): bump jsoup from 1.10.3 to 1.15.3 in /src/test/resources/test-projects/manifest-generat

2022-09-01 Thread GitBox
dependabot[bot] opened a new pull request, #83: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/83 Bumps [jsoup](https://github.com/jhy/jsoup) from 1.10.3 to 1.15.3. Release notes Sourced from https://github.com/jhy/jsoup/releases;>jsoup's releases.

[GitHub] [jackrabbit-oak] jsedding commented on pull request #685: OAK-9914 - Starting Oak with Azure persistence in read-only mode whil…

2022-09-01 Thread GitBox
jsedding commented on PR #685: URL: https://github.com/apache/jackrabbit-oak/pull/685#issuecomment-1234512427 @smiroslav here's a PR with my proposal for OAK-9914. The test case was of course pulled from your patch on the JIRA. -- This is an automated message from the Apache Git Service.

[GitHub] [jackrabbit-oak] jsedding opened a new pull request, #685: OAK-9914 - Starting Oak with Azure persistence in read-only mode whil…

2022-09-01 Thread GitBox
jsedding opened a new pull request, #685: URL: https://github.com/apache/jackrabbit-oak/pull/685 …e another Oak process is running will initiate repo recovery -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-oak] gnaresh19 opened a new pull request, #684: [Oak 9919] Add support for zstd, zlib to document store with mongodb

2022-09-01 Thread GitBox
gnaresh19 opened a new pull request, #684: URL: https://github.com/apache/jackrabbit-oak/pull/684 - Provides support for other compression algorithms (zstd, zlib) besides default collection compressor (snappy) - These compressors are only valid for mongodb v4.2 and above. - These

[GitHub] [jackrabbit-oak] smiroslav commented on pull request #682: Azure archive recovery for read-only Oak process

2022-09-01 Thread GitBox
smiroslav commented on PR #682: URL: https://github.com/apache/jackrabbit-oak/pull/682#issuecomment-1234270085 @jsedding, thanks. Let's further discuss this in JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jackrabbit-oak] smiroslav closed pull request #682: Azure archive recovery for read-only Oak process

2022-09-01 Thread GitBox
smiroslav closed pull request #682: Azure archive recovery for read-only Oak process URL: https://github.com/apache/jackrabbit-oak/pull/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] reschke merged pull request #681: OAK-9916: remove jackrabbit-data dependency from oak-store-document

2022-09-01 Thread GitBox
reschke merged PR #681: URL: https://github.com/apache/jackrabbit-oak/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] smiroslav opened a new pull request, #682: Azure archive recovery for read-only Oak process

2022-09-01 Thread GitBox
smiroslav opened a new pull request, #682: URL: https://github.com/apache/jackrabbit-oak/pull/682 https://issues.apache.org/jira/browse/OAK-9914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [jackrabbit-oak] Joscorbe commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-08-31 Thread GitBox
Joscorbe commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r959877290 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/ReadPreferenceIT.java: ## @@ -116,10 +116,11 @@ public void

[GitHub] [jackrabbit-oak] Joscorbe commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-08-31 Thread GitBox
Joscorbe commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r959877112 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/ReadPreferenceIT.java: ## @@ -116,10 +116,11 @@ public void

[GitHub] [jackrabbit-oak] Joscorbe commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-08-31 Thread GitBox
Joscorbe commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r959875452 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoTestClient.java: ## @@ -16,31 +16,136 @@ */ package

[GitHub] [jackrabbit-oak] Joscorbe commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-08-31 Thread GitBox
Joscorbe commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r959871713 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/MongoConnection.java: ## @@ -142,41 +153,53 @@ public void close() { *

[GitHub] [jackrabbit-oak] Joscorbe commented on a diff in pull request #295: Support for Mongo Java Driver 4.7

2022-08-31 Thread GitBox
Joscorbe commented on code in PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r959867549 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -305,13 +303,12 @@ private void

[GitHub] [jackrabbit-oak] reschke merged pull request #680: OAK-9915: remove jackrabbit-data dependency from oak-core

2022-08-31 Thread GitBox
reschke merged PR #680: URL: https://github.com/apache/jackrabbit-oak/pull/680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-31 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r959344551 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -573,54 +575,53 @@ private List

[GitHub] [jackrabbit-oak] fabriziofortino closed pull request #548: OAK-9686 - Removing unnecessary overrides.

2022-08-30 Thread GitBox
fabriziofortino closed pull request #548: OAK-9686 - Removing unnecessary overrides. URL: https://github.com/apache/jackrabbit-oak/pull/548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] fabriziofortino commented on pull request #548: OAK-9686 - Removing unnecessary overrides.

2022-08-30 Thread GitBox
fabriziofortino commented on PR #548: URL: https://github.com/apache/jackrabbit-oak/pull/548#issuecomment-1231926977 Obsolete. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] fabriziofortino commented on pull request #670: OAK-9875-ut: full-text queries on date fields

2022-08-30 Thread GitBox
fabriziofortino commented on PR #670: URL: https://github.com/apache/jackrabbit-oak/pull/670#issuecomment-1231919019 changes integrated in #649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [jackrabbit-oak] fabriziofortino closed pull request #670: OAK-9875-ut: full-text queries on date fields

2022-08-30 Thread GitBox
fabriziofortino closed pull request #670: OAK-9875-ut: full-text queries on date fields URL: https://github.com/apache/jackrabbit-oak/pull/670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
fabriziofortino commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957131789 ## oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneFacetCommonTest.java: ## @@ -46,13 +44,6 @@ protected Repository

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
fabriziofortino commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957114359 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -573,54 +575,53 @@ private List

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
thomasmueller commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957081959 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java: ## @@ -53,7 +53,8 @@ protected

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957038958 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSpellcheckTest.java: ## @@ -1,238 +0,0 @@ -/* Review Comment: ah. ok

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
fabriziofortino commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957027701 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSpellcheckTest.java: ## @@ -1,238 +0,0 @@ -/* Review Comment:

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957008103 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSpellcheckTest.java: ## @@ -1,238 +0,0 @@ -/* Review Comment: Why

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957008103 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSpellcheckTest.java: ## @@ -1,238 +0,0 @@ -/* Review Comment: Why

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957000974 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -573,54 +575,53 @@ private List

[GitHub] [jackrabbit-oak] rishabhdaim commented on pull request #678: OAK-9909 : added feature toggle for mongo document store throttling f…

2022-08-26 Thread GitBox
rishabhdaim commented on PR #678: URL: https://github.com/apache/jackrabbit-oak/pull/678#issuecomment-1228593635 thanks, @mreutegg for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [jackrabbit-oak] mreutegg merged pull request #678: OAK-9909 : added feature toggle for mongo document store throttling f…

2022-08-26 Thread GitBox
mreutegg merged PR #678: URL: https://github.com/apache/jackrabbit-oak/pull/678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #678: OAK-9909 : added feature toggle for mongo document store throttling f…

2022-08-26 Thread GitBox
mreutegg commented on code in PR #678: URL: https://github.com/apache/jackrabbit-oak/pull/678#discussion_r956005176 ## oak-store-document/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [jackrabbit-oak] rishabhdaim opened a new pull request, #678: OAK-9909 : added feature toggle for mongo document store throttling f…

2022-08-26 Thread GitBox
rishabhdaim opened a new pull request, #678: URL: https://github.com/apache/jackrabbit-oak/pull/678 …eature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [jackrabbit-oak] mreutegg merged pull request #675: OAK-9908: Recovery may revert committed changes

2022-08-25 Thread GitBox
mreutegg merged PR #675: URL: https://github.com/apache/jackrabbit-oak/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] jsedding merged pull request #677: OAK-9911 - Resource leak in ChunkedBlobStream

2022-08-25 Thread GitBox
jsedding merged PR #677: URL: https://github.com/apache/jackrabbit-oak/pull/677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] jsedding commented on pull request #677: OAK-9911 - Resource leak in ChunkedBlobStream

2022-08-25 Thread GitBox
jsedding commented on PR #677: URL: https://github.com/apache/jackrabbit-oak/pull/677#issuecomment-1227273976 Thanks @dulceanu! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #675: OAK-9908: Recovery may revert committed changes

2022-08-25 Thread GitBox
mreutegg commented on PR #675: URL: https://github.com/apache/jackrabbit-oak/pull/675#issuecomment-1227023769 Thanks for the reviews. I added tests you suggested with https://github.com/apache/jackrabbit-oak/pull/675/commits/8a603d5f4e13304310aa619a56951109e373da4d -- This is an

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #651: OAK-9880 : simplify rgc query

2022-08-24 Thread GitBox
stefan-egli commented on PR #651: URL: https://github.com/apache/jackrabbit-oak/pull/651#issuecomment-1225957445 * added logic to avoid calling `deleteMany` for idle clusterNodeIds - plus tests for this * added a test for number of `deleteMany` calls for the above and some of the

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-24 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r953554846 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -194,6 +197,18 @@ private static void

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-24 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r953553188 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java: ## @@ -142,32 +148,39 @@ protected boolean

[GitHub] [jackrabbit-oak] jsedding merged pull request #663: OAK-9888 - Support more flexible SplitPersistence setups via OSGi

2022-08-24 Thread GitBox
jsedding merged PR #663: URL: https://github.com/apache/jackrabbit-oak/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] Joscorbe commented on pull request #295: Support for Mongo Java Driver 4.7

2022-08-23 Thread GitBox
Joscorbe commented on PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#issuecomment-1224011922 All checks have passed at this point, I will continue now the migration to sync driver in this same PR. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-23 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r952420041 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java: ## @@ -142,32 +148,39 @@ protected boolean

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-23 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r952418999 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java: ## @@ -142,32 +148,39 @@ protected boolean

[GitHub] [jackrabbit-oak] nit0906 merged pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-23 Thread GitBox
nit0906 merged PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-22 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r952106899 ## oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/FullTextIndexCommonTest.java: ## @@ -112,6 +113,67 @@ public void

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951598922 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDefinition.java: ## @@ -220,6 +222,35 @@ public String

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951563266 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticAbstractQueryTest.java: ## @@ -140,7 +145,7 @@ protected

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951560137 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResultRowAsyncIterator.java: ## @@ -341,8 +343,16 @@ public

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #675: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg commented on PR #675: URL: https://github.com/apache/jackrabbit-oak/pull/675#issuecomment-1222463330 @Joscorbe, can you please review as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #675: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg opened a new pull request, #675: URL: https://github.com/apache/jackrabbit-oak/pull/675 Ensure suspect documents are either up-to-date in the cache or invalidated Enable test -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-oak] mreutegg merged pull request #674: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg merged PR #674: URL: https://github.com/apache/jackrabbit-oak/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #674: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg commented on PR #674: URL: https://github.com/apache/jackrabbit-oak/pull/674#issuecomment-1222402640 Failure in oak-webapp looks unrelated to changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #672: OAK-9907 Allow comparing indexes in the same file

2022-08-22 Thread GitBox
thomasmueller merged PR #672: URL: https://github.com/apache/jackrabbit-oak/pull/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] jsedding merged pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding merged PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #674: OAK-9908: Recovery may revert committed changes

2022-08-22 Thread GitBox
mreutegg opened a new pull request, #674: URL: https://github.com/apache/jackrabbit-oak/pull/674 Add ignored test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [jackrabbit-oak] mreutegg merged pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-22 Thread GitBox
mreutegg merged PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-22 Thread GitBox
mreutegg commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r951330598 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to

[GitHub] [jackrabbit-oak] jsedding commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951223721 ## oak-parent/pom.xml: ## @@ -1316,5 +1316,37 @@ + + intellij-build-workaround + + + Review Comment:

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
kwin commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951212776 ## oak-parent/pom.xml: ## @@ -1316,5 +1316,37 @@ + + intellij-build-workaround + + + Review Comment: this

[GitHub] [jackrabbit-oak] jsedding commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951208551 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: Thank you for the pointer!

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
kwin commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951194463 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: Just look at

[GitHub] [jackrabbit-oak] jsedding commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
jsedding commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951185051 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: I agree with you in principle.

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #664: OAK-9896 - Running unit-tests in IntelliJ dos not work

2022-08-22 Thread GitBox
kwin commented on code in PR #664: URL: https://github.com/apache/jackrabbit-oak/pull/664#discussion_r951179536 ## oak-parent/pom.xml: ## @@ -1316,5 +1297,53 @@ + + intellij-build-workaround Review Comment: I find it a bit nasty that this

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-22 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r951152234 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -207,21 +222,57 @@ private static void

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950144346 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #673: OAK-9879: CacheLIRS statistics may return incorrect load count

2022-08-19 Thread GitBox
thomasmueller merged PR #673: URL: https://github.com/apache/jackrabbit-oak/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-19 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r950319566 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -207,21 +222,57 @@ private static void

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950293058 ## oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexPathRestrictionCommonTest.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950292276 ## oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/FullTextIndexCommonTest.java: ## @@ -112,6 +113,67 @@ public void

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
nit0906 commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950291136 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticResponseHandler.java: ## @@ -41,14 +43,22 @@ public class

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #649: OAK-9875 - Prefix query on a Long, analyzed field fails when executed over Elastic

2022-08-19 Thread GitBox
nfsantos commented on code in PR #649: URL: https://github.com/apache/jackrabbit-oak/pull/649#discussion_r950282226 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -207,21 +222,57 @@ private static void

[GitHub] [jackrabbit-oak] Joscorbe commented on pull request #295: Support for Mongo Java Driver 4.2+

2022-08-19 Thread GitBox
Joscorbe commented on PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#issuecomment-1220665247 Hi @mreutegg, yes, the plan is to move to sync driver after the failing tests in this build are fixed. Apart from the documentation you have showed, I have this support case where

[GitHub] [jackrabbit-oak] Joscorbe commented on pull request #295: Support for Mongo Java Driver 4.2+

2022-08-19 Thread GitBox
Joscorbe commented on PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#issuecomment-1220645692 @mreutegg Yes, legacy driver is the one I'm using for these changes, you can see it here:

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950156675 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStoreThrottlingMetricsUpdater.java: ## @@ -0,0 +1,138 @@ +/*

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950144346 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #635: OAK-9851 : added support for throttling in mongo oak client based on …

2022-08-19 Thread GitBox
rishabhdaim commented on code in PR #635: URL: https://github.com/apache/jackrabbit-oak/pull/635#discussion_r950144346 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ThrottlingDocumentStoreWrapper.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
fabriziofortino commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950028769 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticResponseHandler.java: ## @@ -41,14 +43,22 @@ public class

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #671: OAK-9903 | Improved test coverage for path restriction and path transformation

2022-08-19 Thread GitBox
thomasmueller commented on code in PR #671: URL: https://github.com/apache/jackrabbit-oak/pull/671#discussion_r950112445 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticResponseHandler.java: ## @@ -41,14 +43,22 @@ public class

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #295: Support for Mongo Java Driver 4.2+

2022-08-19 Thread GitBox
mreutegg commented on PR #295: URL: https://github.com/apache/jackrabbit-oak/pull/295#issuecomment-1220589503 @Joscorbe it seems to me only a few changes would be necessary to avoid use of the legacy driver, but I may be missing some less trivial changes.

<    6   7   8   9   10   11   12   13   14   15   >