sbluhm commented on pull request #161:
URL: https://github.com/apache/jackrabbit-oak/pull/161#issuecomment-885730752
@stefan-egli , any chance of merging this PR? It has been in my queue for a
while.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sbluhm closed pull request #116:
URL: https://github.com/apache/jackrabbit-oak/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
sbluhm closed pull request #113:
URL: https://github.com/apache/jackrabbit-oak/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
jsedding commented on pull request #161:
URL: https://github.com/apache/jackrabbit-oak/pull/161#issuecomment-886463392
@sbluhm I believe this pitfall is only true for referenceable nodes. Other
nodes don't have a UUID property, and thus are not subject to the same
uniqueness constraint. Ma
averma21 merged pull request #329:
URL: https://github.com/apache/jackrabbit-oak/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
wx930910 opened a new pull request #94:
URL: https://github.com/apache/jackrabbit/pull/94
Fixes [#1: Refactor DummyInternalVersion in VersionIteratorImplTest.java to
improve test logic](https://github.com/wx930910/jackrabbit/issues/1).
### Description
Refactor test class
wx930910 closed pull request #94:
URL: https://github.com/apache/jackrabbit/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
averma21 opened a new pull request #330:
URL: https://github.com/apache/jackrabbit-oak/pull/330
* Using constant for flat-file-store dir name and improving its test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
averma21 merged pull request #330:
URL: https://github.com/apache/jackrabbit-oak/pull/330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
averma21 opened a new pull request #331:
URL: https://github.com/apache/jackrabbit-oak/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
averma21 merged pull request #331:
URL: https://github.com/apache/jackrabbit-oak/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
mreutegg opened a new pull request #332:
URL: https://github.com/apache/jackrabbit-oak/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
fabriziofortino opened a new pull request #333:
URL: https://github.com/apache/jackrabbit-oak/pull/333
The `assertEventually` logic wrongly mixes seconds and milliseconds. We have
never had issues so far but this could result in flaky tests when async
indexing is enabled.
--
This is an
mreutegg merged pull request #332:
URL: https://github.com/apache/jackrabbit-oak/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
fabriziofortino merged pull request #333:
URL: https://github.com/apache/jackrabbit-oak/pull/333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: d
nit0906 opened a new pull request #334:
URL: https://github.com/apache/jackrabbit-oak/pull/334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev
nit0906 merged pull request #334:
URL: https://github.com/apache/jackrabbit-oak/pull/334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
nit0906 opened a new pull request #335:
URL: https://github.com/apache/jackrabbit-oak/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev
wx930910 opened a new pull request #95:
URL: https://github.com/apache/jackrabbit/pull/95
Fixes [#JCR-4710 Refactor DummyInternalVersion in
VersionIteratorImplTest.java to improve test
logic](https://issues.apache.org/jira/browse/JCR-4710).
### Description
Refactor test
nit0906 merged pull request #335:
URL: https://github.com/apache/jackrabbit-oak/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
thomasmueller opened a new pull request #336:
URL: https://github.com/apache/jackrabbit-oak/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
averma21 opened a new pull request #338:
URL: https://github.com/apache/jackrabbit-oak/pull/338
…ped) during indexing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
averma21 commented on a change in pull request #336:
URL: https://github.com/apache/jackrabbit-oak/pull/336#discussion_r683351322
##
File path:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexPathRestrictionTest.java
##
@@ -104,6 +105,53 @@ p
stefan-egli commented on a change in pull request #299:
URL: https://github.com/apache/jackrabbit-oak/pull/299#discussion_r683417839
##
File path:
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoVersionGCSupport.java
##
@@ -127,6 +128,13
thomasmueller commented on a change in pull request #338:
URL: https://github.com/apache/jackrabbit-oak/pull/338#discussion_r683408441
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/CompositeException.java
##
@@ -0,0 +1,41 @@
+/*
+
stefan-egli merged pull request #299:
URL: https://github.com/apache/jackrabbit-oak/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-u
averma21 commented on a change in pull request #338:
URL: https://github.com/apache/jackrabbit-oak/pull/338#discussion_r684000894
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/CompositeException.java
##
@@ -0,0 +1,41 @@
+/*
+ * Li
averma21 commented on a change in pull request #338:
URL: https://github.com/apache/jackrabbit-oak/pull/338#discussion_r684007897
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/MultithreadedTraverseWithSortStrategy.java
##
averma21 commented on a change in pull request #338:
URL: https://github.com/apache/jackrabbit-oak/pull/338#discussion_r684014120
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java
##
@@ -133,6 +135,52 @@
thomasmueller commented on a change in pull request #338:
URL: https://github.com/apache/jackrabbit-oak/pull/338#discussion_r684044859
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/CompositeException.java
##
@@ -0,0 +1,41 @@
+/*
+
thomasmueller commented on a change in pull request #336:
URL: https://github.com/apache/jackrabbit-oak/pull/336#discussion_r684099573
##
File path:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexPathRestrictionTest.java
##
@@ -104,6 +105,53
thomasmueller merged pull request #337:
URL: https://github.com/apache/jackrabbit-oak/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev
nit0906 opened a new pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339
…unning' should be info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
thomasmueller commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687437380
##
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##
@@ -501,9 +501,9 @@ private void runWhen
nit0906 commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687440796
##
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##
@@ -501,9 +501,9 @@ private void runWhenPermit
thomasmueller commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687626561
##
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##
@@ -1050,6 +1051,7 @@ public void done(S
thomasmueller merged pull request #336:
URL: https://github.com/apache/jackrabbit-oak/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev
nit0906 commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687632433
##
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##
@@ -1050,6 +1051,7 @@ public void done(String
nit0906 commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687635478
##
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##
@@ -1066,13 +1068,21 @@ public void failed(Exc
nit0906 commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687632433
##
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##
@@ -1050,6 +1051,7 @@ public void done(String
nit0906 merged pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
averma21 merged pull request #338:
URL: https://github.com/apache/jackrabbit-oak/pull/338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
tihom88 opened a new pull request #341:
URL: https://github.com/apache/jackrabbit-oak/pull/341
…/CoreParser.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
thomasmueller commented on a change in pull request #340:
URL: https://github.com/apache/jackrabbit-oak/pull/340#discussion_r691891231
##
File path:
oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java
##
@@ -38,6 +39,7 @@
import org.apache.j
nit0906 commented on a change in pull request #340:
URL: https://github.com/apache/jackrabbit-oak/pull/340#discussion_r691920036
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/async/AsyncIndexerBase.java
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the
nit0906 commented on a change in pull request #340:
URL: https://github.com/apache/jackrabbit-oak/pull/340#discussion_r691920135
##
File path:
oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java
##
@@ -38,6 +39,7 @@
import org.apache.jackrab
fabriziofortino commented on a change in pull request #340:
URL: https://github.com/apache/jackrabbit-oak/pull/340#discussion_r691954951
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/async/AsyncIndexerBase.java
##
@@ -0,0 +1,110 @@
+/*
+ * License
mohammadMahdavi opened a new pull request #342:
URL: https://github.com/apache/jackrabbit-oak/pull/342
This commit solve the problem that I described in
[OAK-9310](https://issues.apache.org/jira/browse/OAK-9310). The problem depends
on the query plan of execution and in some situations it
ArunOnCloud opened a new pull request #345:
URL: https://github.com/apache/jackrabbit-oak/pull/345
upgrading netty dependency to 4.1.66.final version jira OAK-9539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
kwin commented on pull request #343:
URL: https://github.com/apache/jackrabbit-oak/pull/343#issuecomment-902015844
According to
https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/SerializationT
kwin edited a comment on pull request #343:
URL: https://github.com/apache/jackrabbit-oak/pull/343#issuecomment-902015844
According to
https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/Seriali
kwin removed a comment on pull request #343:
URL: https://github.com/apache/jackrabbit-oak/pull/343#issuecomment-902015844
According to
https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/Serial
nit0906 commented on pull request #340:
URL: https://github.com/apache/jackrabbit-oak/pull/340#issuecomment-902403445
> LGTM. A few minors
@fabriziofortino thanks. I have incorporated the suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the m
nit0906 merged pull request #340:
URL: https://github.com/apache/jackrabbit-oak/pull/340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
kwin commented on pull request #347:
URL: https://github.com/apache/jackrabbit-oak/pull/347#issuecomment-902662979
@mreutegg Any idea why the query in
https://github.com/apache/jackrabbit-oak/blob/4dfed10836051aab6d12cd0dc1b022c0745ae8de/oak-core/src/main/java/org/apache/jackrabbit/oak/plug
adamcin opened a new pull request #348:
URL: https://github.com/apache/jackrabbit-oak/pull/348
Azurite, the local nodejs-based Azure Storage Simulator, uses case-sensitive
parameter matching when performing lookups based on autogen OpenAPI specs. This
change will make it possible to use Az
nit0906 opened a new pull request #349:
URL: https://github.com/apache/jackrabbit-oak/pull/349
…-elastic with the one created in assembly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
sbluhm commented on pull request #161:
URL: https://github.com/apache/jackrabbit-oak/pull/161#issuecomment-903157591
@jsedding , thank you for your pointer. This indeed applies only to UUIDs. I
just verified it. Let me update my statement and re-submit.
--
This is an automated message fr
sbluhm edited a comment on pull request #161:
URL: https://github.com/apache/jackrabbit-oak/pull/161#issuecomment-903157591
@jsedding , thank you for your pointer. This indeed applies only to UUIDs. I
just verified it. I have revised the statement and re-submitted.
--
This is an automate
tihom88 merged pull request #341:
URL: https://github.com/apache/jackrabbit-oak/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
ArunOnCloud opened a new pull request #350:
URL: https://github.com/apache/jackrabbit-oak/pull/350
Bump netty dependency from 4.1.52.Final to 4.1.66.Final
branch : 1.22
jira : https://issues.apache.org/jira/browse/OAK-9539
--
This is an automated message from the Apache Git Servic
tihom88 commented on pull request #351:
URL: https://github.com/apache/jackrabbit-oak/pull/351#issuecomment-903626775
In this change we are not logging invalid index-definitions in "sync lucene"
index
--
This is an automated message from the Apache Git Service.
To respond to the message,
kwin opened a new pull request #159:
URL: https://github.com/apache/jackrabbit-filevault/pull/159
add additional import options to tweak UUID collision behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tripodsan commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694535900
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void
nit0906 merged pull request #349:
URL: https://github.com/apache/jackrabbit-oak/pull/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
kwin commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694557448
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void hand
kwin commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694557448
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void hand
kwin commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694557448
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void hand
tripodsan commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694565566
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void
kwin commented on pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#issuecomment-904384391
The default behaviour changed:
https://github.com/apache/jackrabbit-filevault/pull/159/files#diff-805491a0bcebe271c6e12fa9b2a97e452effc7963d619203e2e2cc616d954639.
Bu
kwin commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694566705
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void hand
kwin commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694566705
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void hand
kwin commented on a change in pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#discussion_r694567558
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##
@@ -809,89 +813,47 @@ private void hand
sonarcloud[bot] commented on pull request #159:
URL:
https://github.com/apache/jackrabbit-filevault/pull/159#issuecomment-904410481
SonarCloud Quality Gate failed. 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
tihom88 merged pull request #352:
URL: https://github.com/apache/jackrabbit-oak/pull/352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
DominikSuess opened a new pull request #160:
URL: https://github.com/apache/jackrabbit-filevault/pull/160
…mportProtectedProperties()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kwin closed pull request #160:
URL: https://github.com/apache/jackrabbit-filevault/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
kwin commented on pull request #160:
URL:
https://github.com/apache/jackrabbit-filevault/pull/160#issuecomment-907107793
@DominikSuess Thanks for the test case, I integrated this together with a
fix in #161. Please have a look.
--
This is an automated message from the Apache Git Service
sonarcloud[bot] commented on pull request #161:
URL:
https://github.com/apache/jackrabbit-filevault/pull/161#issuecomment-907193844
Kudos, SonarCloud Quality Gate passed! 