sonarcloud[bot] commented on PR #814:
URL: https://github.com/apache/jackrabbit-oak/pull/814#issuecomment-1373531366
Kudos, SonarCloud Quality Gate passed! [ for the modified classes. For example Sonar considers that
`AbstractRemoteSegmentArchiveWriter`
sonarcloud[bot] commented on PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#issuecomment-1361699722
SonarCloud Quality Gate failed. [; // or some other better name ;)
> ```
Yep,
kwin commented on code in PR #808:
URL: https://github.com/apache/jackrabbit-oak/pull/808#discussion_r1053498706
##
oak-parent/pom.xml:
##
@@ -276,36 +269,32 @@
gmavenplus-plugin
1.13.1
+
Review Comment:
duplicates lines 268ff
--
reschke opened a new pull request, #808:
URL: https://github.com/apache/jackrabbit-oak/pull/808
(based on @kwin's work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin commented on PR #260:
URL:
https://github.com/apache/jackrabbit-filevault/pull/260#issuecomment-1359622814
Merged a slightly modified version in
https://github.com/apache/jackrabbit-filevault/commit/1442a06b288b0f90f3e78ccd5ad0291f977675bb.
@stoerr Thanks for the efforts.
--
This
kwin closed pull request #260: JCRVLT-672 use mavens ComparableVersion for
package Version compareTo
URL: https://github.com/apache/jackrabbit-filevault/pull/260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kwin merged PR #264:
URL: https://github.com/apache/jackrabbit-filevault/pull/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smiroslav commented on PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#issuecomment-1359477688
@jelmini @ahanikel how about declaring method in SegmentArchiveWriter
```
public boolean isRemoteStoreWriter()
```
And use it in
smiroslav commented on code in PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1053340481
##
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tar/TarWriter.java:
##
@@ -183,7 +183,14 @@ void flush() throws IOException {
smiroslav commented on code in PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1053340481
##
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tar/TarWriter.java:
##
@@ -183,7 +183,14 @@ void flush() throws IOException {
smiroslav commented on code in PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1053340481
##
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tar/TarWriter.java:
##
@@ -183,7 +183,14 @@ void flush() throws IOException {
sonarcloud[bot] commented on PR #807:
URL: https://github.com/apache/jackrabbit-oak/pull/807#issuecomment-1359334475
Kudos, SonarCloud Quality Gate passed! [ {
}
reschke closed pull request #261: JCRVLT-670: remove use String cache, getting
rid of commons-collections dependency
URL: https://github.com/apache/jackrabbit-filevault/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
reschke merged PR #259:
URL: https://github.com/apache/jackrabbit-filevault/pull/259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke commented on PR #259:
URL:
https://github.com/apache/jackrabbit-filevault/pull/259#issuecomment-1359130803
OK - I'll go ahead then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
reschke commented on PR #259:
URL:
https://github.com/apache/jackrabbit-filevault/pull/259#issuecomment-1359020573
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ahanikel commented on PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#issuecomment-1359013262
@smiroslav I think there's a potential problem here: tar archives are
append-only, so if we write the references after each flush, we will produce a
lot of waste. That isn't a
kwin commented on PR #259:
URL:
https://github.com/apache/jackrabbit-filevault/pull/259#issuecomment-1358993165
@reschke Can you rebase to make the ASF Jenkins build succeed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
reschke commented on PR #259:
URL:
https://github.com/apache/jackrabbit-filevault/pull/259#issuecomment-1358985323
@kwin - this passes tests, and it has shown a good improvement in out
production use case. Could you please review?
--
This is an automated message from the Apache Git
github-actions[bot] commented on PR #122:
URL: https://github.com/apache/jackrabbit-oak/pull/122#issuecomment-1358728169
This PR is stale because it has been open 24 months with no activity. Remove
stale label or comment or this will be closed in 30 days.
--
This is an automated message
sonarcloud[bot] commented on PR #805:
URL: https://github.com/apache/jackrabbit-oak/pull/805#issuecomment-1358171378
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
kwin commented on PR #260:
URL:
https://github.com/apache/jackrabbit-filevault/pull/260#issuecomment-1358105973
Build failed due to invalid javadoc:
`[ERROR]
reschke merged PR #805:
URL: https://github.com/apache/jackrabbit-oak/pull/805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stoerr commented on PR #260:
URL:
https://github.com/apache/jackrabbit-filevault/pull/260#issuecomment-1358061722
@kwin Puzzling. The build worked after the rebase, but after the review
changes it doesn't work, again. And it still shows "1 change requested"
although all review comments
jelmini commented on code in PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1052445924
##
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tar/TarWriter.java:
##
@@ -183,7 +183,14 @@ void flush() throws IOException {
sonarcloud[bot] commented on PR #804:
URL: https://github.com/apache/jackrabbit-oak/pull/804#issuecomment-1357972064
Kudos, SonarCloud Quality Gate passed! [
jelmini commented on code in PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1052432848
##
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tar/TarWriter.java:
##
@@ -183,7 +183,14 @@ void flush() throws IOException {
sonarcloud[bot] commented on PR #803:
URL: https://github.com/apache/jackrabbit-oak/pull/803#issuecomment-1357942686
Kudos, SonarCloud Quality Gate passed! [ throws IOException {
reschke merged PR #804:
URL: https://github.com/apache/jackrabbit-oak/pull/804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #802:
URL: https://github.com/apache/jackrabbit-oak/pull/802#issuecomment-1357875912
Kudos, SonarCloud Quality Gate passed! [ {
}
reschke merged PR #801:
URL: https://github.com/apache/jackrabbit-oak/pull/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #799:
URL: https://github.com/apache/jackrabbit-oak/pull/799#issuecomment-1357639391
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kwin commented on code in PR #260:
URL:
https://github.com/apache/jackrabbit-filevault/pull/260#discussion_r1051910062
##
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/Version.java:
##
@@ -135,44 +136,40 @@ public String[] getNormalizedSegments() {
}
mreutegg commented on code in PR #796:
URL: https://github.com/apache/jackrabbit-oak/pull/796#discussion_r1051894822
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java:
##
@@ -563,67 +565,81 @@ public boolean
github-actions[bot] commented on PR #123:
URL: https://github.com/apache/jackrabbit-oak/pull/123#issuecomment-1356976746
This PR is stale because it has been open 24 months with no activity. Remove
stale label or comment or this will be closed in 30 days.
--
This is an automated message
github-actions[bot] commented on PR #124:
URL: https://github.com/apache/jackrabbit-oak/pull/124#issuecomment-1356976713
This PR is stale because it has been open 24 months with no activity. Remove
stale label or comment or this will be closed in 30 days.
--
This is an automated message
dependabot[bot] commented on PR #252:
URL:
https://github.com/apache/jackrabbit-filevault/pull/252#issuecomment-1356850178
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
401 - 500 of 4444 matches
Mail list logo
