sonarcloud[bot] removed a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828774044
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828778432
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
[](htt
kwin commented on a change in pull request #291:
URL: https://github.com/apache/jackrabbit-oak/pull/291#discussion_r622564087
##
File path: oak-doc/src/site/markdown/differences.md
##
@@ -316,6 +318,19 @@ Node Name Length Limit
With the document storage backend (MongoDB, RDB
kwin commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828940621
Any reason why lazy loading was not used in the other constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
tripodsan commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828945781
> Any reason why lazy loading was not used in the other constructor?
which other constructor?
--
This is an automated message from the Apache Git Service.
kwin commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828965967
> which other constructor?
https://github.com/apache/jackrabbit-filevault/blob/7eb85af4e8a1072c1c0a72f90c59d67310d7b102/vault-core/src/main/java/org/apache/jackra
stoerr commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828974792
I did consider getting rid of lazy loading completely when doing #135 , but
I'm afraid the original author might have had a good reason to do it. The
problem is that
stoerr commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622768174
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##
@@ -185,6 +182,7 @@ publi
stoerr commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622768989
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSInstallState.java
##
@@ -417,4 +422,84 @@ public
kwin commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828976836
I just checked again and the default timeout in Felix SCR for activate
methods is 5 seconds
(https://github.com/apache/felix-dev/blob/3e5671ae7e5107f4f849ef9d5f0a89b1ba
stoerr commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622772747
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSInstallState.java
##
@@ -417,4 +422,84 @@ public
stoerr commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828984976
While we're at it: there are some log messages in FSPackageRegistry that
could log the file / package they apply to to make it easier to find which of
the potentially
anchela commented on a change in pull request #291:
URL: https://github.com/apache/jackrabbit-oak/pull/291#discussion_r622779758
##
File path:
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java
##
@@ -248,11 +249,15 @@ public String getUserID() {
stoerr edited a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828974792
I did consider getting rid of lazy loading completely when doing #135 , but
I was afraid the original author might have had a good reason to do it. The
problem
DominikSuess commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622786889
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##
@@ -185,6 +182,7 @@
DominikSuess commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622793377
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##
@@ -185,6 +182,7 @@
kwin commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622850545
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##
@@ -185,6 +182,7 @@ public
kwin commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622850545
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##
@@ -185,6 +182,7 @@ public
kwin closed pull request #291:
URL: https://github.com/apache/jackrabbit-oak/pull/291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
kwin commented on pull request #291:
URL: https://github.com/apache/jackrabbit-oak/pull/291#issuecomment-829156910
Merged in
https://github.com/apache/jackrabbit-oak/commit/cde907088a5c460178fd714cb4edc141cd45e23d.
--
This is an automated message from the Apache Git Service.
To respond t
kwin opened a new pull request #54:
URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
sonarcloud[bot] commented on pull request #54:
URL:
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/54#issuecomment-831183102
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pullReque
sonarcloud[bot] commented on pull request #54:
URL:
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/54#issuecomment-831301964
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&pullReque
sonarcloud[bot] removed a comment on pull request #54:
URL:
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/54#issuecomment-831275359
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin&p
kwin merged pull request #54:
URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
sonarcloud[bot] removed a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828778432
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831862939
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
[](htt
sonarcloud[bot] commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831876363
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831862939
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831879255
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831876363
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] removed a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831879255
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831879951
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
[](htt
sonarcloud[bot] edited a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831879951
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] removed a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831879951
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831894312
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-831894312
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-832050779
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=136&resolved=false&types=BUG)
[](htt
kwin merged pull request #136:
URL: https://github.com/apache/jackrabbit-filevault/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
mreutegg commented on a change in pull request #289:
URL: https://github.com/apache/jackrabbit-oak/pull/289#discussion_r627567459
##
File path:
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/RecoveryLockTest.java
##
@@ -182,6 +185,49 @@ public void
mreutegg commented on pull request #289:
URL: https://github.com/apache/jackrabbit-oak/pull/289#issuecomment-833652073
There also another suggestion I have, though it is unrelated to the issue.
The executor service should be stopped, otherwise its pooled threads will
linger around an
kwin opened a new pull request #137:
URL: https://github.com/apache/jackrabbit-filevault/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
kwin closed pull request #135:
URL: https://github.com/apache/jackrabbit-filevault/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
kwin commented on pull request #135:
URL:
https://github.com/apache/jackrabbit-filevault/pull/135#issuecomment-834348974
Now that #136 has been merged this should have been solved. @stoerr Thanks
for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the
Joscorbe commented on pull request #289:
URL: https://github.com/apache/jackrabbit-oak/pull/289#issuecomment-834376813
Thank you for reviewing @mreutegg, I have applied all the proposed changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-835184878
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-839545225
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-835184878
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
kwin commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-839625746
@tripodsan Can you have a look? This is a delicate topic but hopefully the
new ImportModes make FileVault behave much more consistent...
--
This is an automated messa
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-839545225
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-839665707
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
karlpauls opened a new pull request #138:
URL: https://github.com/apache/jackrabbit-filevault/pull/138
…erty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
kwin merged pull request #138:
URL: https://github.com/apache/jackrabbit-filevault/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
kwin opened a new pull request #139:
URL: https://github.com/apache/jackrabbit-filevault/pull/139
Services 1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
kwin commented on a change in pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#discussion_r631284284
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java
##
@@ -257,7 +250,9 @@ public ImportInfoI
sonarcloud[bot] commented on pull request #139:
URL:
https://github.com/apache/jackrabbit-filevault/pull/139#issuecomment-839989153
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=139&resolved=false&types=BUG)
kwin opened a new pull request #140:
URL: https://github.com/apache/jackrabbit-filevault/pull/140
This makes it easier to generate the site including (aggregate) javadoc
in one command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sonarcloud[bot] commented on pull request #140:
URL:
https://github.com/apache/jackrabbit-filevault/pull/140#issuecomment-840498563
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=140&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #140:
URL:
https://github.com/apache/jackrabbit-filevault/pull/140#issuecomment-840499409
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=140&resolved=false&types=BUG)
sonarcloud[bot] removed a comment on pull request #140:
URL:
https://github.com/apache/jackrabbit-filevault/pull/140#issuecomment-840498563
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=140&resolved=false&typ
sonarcloud[bot] commented on pull request #140:
URL:
https://github.com/apache/jackrabbit-filevault/pull/140#issuecomment-840531998
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=140&resolved=false&types=BUG)
sonarcloud[bot] removed a comment on pull request #140:
URL:
https://github.com/apache/jackrabbit-filevault/pull/140#issuecomment-840499409
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=140&resolved=false&typ
sonarcloud[bot] commented on pull request #140:
URL:
https://github.com/apache/jackrabbit-filevault/pull/140#issuecomment-840565196
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=140&resolved=false&types=BUG)
sonarcloud[bot] removed a comment on pull request #140:
URL:
https://github.com/apache/jackrabbit-filevault/pull/140#issuecomment-840531998
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=140&resolved=false&typ
kwin merged pull request #140:
URL: https://github.com/apache/jackrabbit-filevault/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
mreutegg opened a new pull request #292:
URL: https://github.com/apache/jackrabbit-oak/pull/292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this ser
reschke commented on a change in pull request #139:
URL:
https://github.com/apache/jackrabbit-filevault/pull/139#discussion_r632500033
##
File path: parent/pom.xml
##
@@ -517,12 +517,12 @@ Bundle-Category: jackrabbit
org.apache.commons
reschke commented on a change in pull request #139:
URL:
https://github.com/apache/jackrabbit-filevault/pull/139#discussion_r632503293
##
File path: parent/pom.xml
##
@@ -532,12 +532,12 @@ Bundle-Category: jackrabbit
org.apache.httpcomponents
kwin commented on a change in pull request #139:
URL:
https://github.com/apache/jackrabbit-filevault/pull/139#discussion_r632534675
##
File path: parent/pom.xml
##
@@ -517,12 +517,12 @@ Bundle-Category: jackrabbit
org.apache.commons
kwin commented on a change in pull request #139:
URL:
https://github.com/apache/jackrabbit-filevault/pull/139#discussion_r632534827
##
File path: parent/pom.xml
##
@@ -532,12 +532,12 @@ Bundle-Category: jackrabbit
org.apache.httpcomponents
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-839665707
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842053906
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
tripodsan commented on a change in pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#discussion_r633274636
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java
##
@@ -257,7 +250,9 @@ public Import
kwin commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842071672
There is a desperate need for having proper merge import modes which work on
all node structures. I therefore added new ImportModes. The idea is that the
old ones work
tripodsan commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842073806
> Do you see any places where this PR broke backwards-compatibility?
I can't judge :-) maybe @DominikSuess or @reschke can run it through the
AEM smoke test
stefan-egli commented on pull request #292:
URL: https://github.com/apache/jackrabbit-oak/pull/292#issuecomment-842075499
+1, agree it should be invisible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kwin commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842092471
TBH: Every relevant test for content packages should rather be in this repo
and not somewhere else...
I haven't found much ITs for the ImportMode behaviour unfortunat
kwin commented on a change in pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#discussion_r61995
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java
##
@@ -218,29 +220,20 @@ public ImportInf
kwin closed pull request #287:
URL: https://github.com/apache/jackrabbit-oak/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
kwin commented on pull request #287:
URL: https://github.com/apache/jackrabbit-oak/pull/287#issuecomment-842259289
Due to concerns raised in JIRA I close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
kwin opened a new pull request #293:
URL: https://github.com/apache/jackrabbit-oak/pull/293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
tripodsan commented on a change in pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#discussion_r633274636
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java
##
@@ -257,7 +250,9 @@ public Import
kwin commented on a change in pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#discussion_r61995
##
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java
##
@@ -218,29 +220,20 @@ public ImportInf
kwin commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842071672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Fo
kwin closed pull request #287:
URL: https://github.com/apache/jackrabbit-oak/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
kwin commented on pull request #287:
URL: https://github.com/apache/jackrabbit-oak/pull/287#issuecomment-842259289
Due to concerns raised in JIRA I close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842053906
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
stefan-egli commented on pull request #292:
URL: https://github.com/apache/jackrabbit-oak/pull/292#issuecomment-842075499
+1, agree it should be invisible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-839665707
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
tripodsan commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842073806
> Do you see any places where this PR broke backwards-compatibility?
I can't judge :-) maybe @DominikSuess or @reschke can run it through the
AEM smoke test
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842928800
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842053906
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-843231323
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-842928800
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-843252087
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-843231323
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-843252087
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-843257890
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
sonarcloud[bot] removed a comment on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-843257890
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#issuecomment-843277808
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault&pullRequest=137&resolved=false&types=BUG)
[](htt
701 - 800 of 1077 matches
Mail list logo