nfsantos commented on code in PR #1511:
URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632858732
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java:
##
@@ -275,6 +277,34 @@ public static String encode(String s) {
reschke commented on code in PR #1511:
URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632842172
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java:
##
@@ -197,9 +197,11 @@ public JsopBuilder value(boolean value) {
*
reschke commented on code in PR #1511:
URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632840377
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java:
##
@@ -275,6 +277,34 @@ public static String encode(String s) {
reschke commented on code in PR #1511:
URL: https://github.com/apache/jackrabbit-oak/pull/1511#discussion_r1632839219
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java:
##
@@ -275,6 +277,34 @@ public static String encode(String s) {
nfsantos opened a new pull request, #1511:
URL: https://github.com/apache/jackrabbit-oak/pull/1511
Microbenchmarks:
Adapted from JsopStreamTest:
```
public static void main(String... args) {
for (int k = 0; k < 5; k++) {
String s = "Hello \"World\" Hello
dulceanu merged PR #1508:
URL: https://github.com/apache/jackrabbit-oak/pull/1508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1630786177
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +44,58 @@
import
stefan-egli commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2152945186
PS:
[commented](https://issues.apache.org/jira/browse/OAK-10812?focusedCommentId=17852849=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17852849)
on
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1629695860
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +44,58 @@
import
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1629470940
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -160,14 +161,14 @@ String getValue() {
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1629427035
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -160,14 +161,14 @@ String getValue() {
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1629381461
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -33,11 +37,16 @@
import static
stefan-egli merged PR #1493:
URL: https://github.com/apache/jackrabbit-oak/pull/1493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke commented on code in PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1629067216
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java:
##
@@ -145,27 +146,73 @@ public void propertyChanged(PropertyState
reschke commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1628995615
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -160,14 +161,14 @@ String getValue() {
reschke commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1628992660
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -33,11 +37,16 @@
import static
adelina-marian commented on PR #1493:
URL: https://github.com/apache/jackrabbit-oak/pull/1493#issuecomment-2151575017
> It looks good to me, but I'm not sure if under `Getting started` is the
best place to add it.
>
> Maybe we could have a new section for Testing, and eventually add
adelina-marian commented on code in PR #1493:
URL: https://github.com/apache/jackrabbit-oak/pull/1493#discussion_r1628895275
##
oak-doc/src/site/site.xml:
##
@@ -152,10 +152,12 @@ under the License.
-
+
+
+
+
Review
adelina-marian commented on code in PR #1493:
URL: https://github.com/apache/jackrabbit-oak/pull/1493#discussion_r1628893648
##
oak-doc/src/site/markdown/development/nodestore-fixtures.md:
##
@@ -0,0 +1,44 @@
+
+
+Testing using different NodeStore fixtures
+---
+
ionutzpi commented on PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#issuecomment-2149520736
Hi @reschke , @Joscorbe, @stefan-egli could we close this PR? @reschke it
need only your approval. Thanks
--
This is an automated message from the Apache Git Service.
To
reschke merged PR #1510:
URL: https://github.com/apache/jackrabbit-oak/pull/1510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1510:
URL: https://github.com/apache/jackrabbit-oak/pull/1510
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
anchela commented on PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#issuecomment-2149051571
@mreutegg , since you were the author of the initial proposal, I would like
to get another review from your side to see if the refactoring I made last
week, still meets your
reschke merged PR #1509:
URL: https://github.com/apache/jackrabbit-oak/pull/1509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1509:
URL: https://github.com/apache/jackrabbit-oak/pull/1509
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli commented on PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#issuecomment-2147389103
Regarding the refactoring of `propertyChanged` : so far I am not seeing the
advantage of the refactoring. That code isn't reused elsewhere, it is merely
cutting a larger
stefan-egli commented on code in PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1625889552
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java:
##
@@ -152,20 +153,37 @@ public void propertyChanged(PropertyState
stefan-egli commented on code in PR #1493:
URL: https://github.com/apache/jackrabbit-oak/pull/1493#discussion_r1625869390
##
oak-doc/src/site/site.xml:
##
@@ -152,10 +152,12 @@ under the License.
-
+
+
+
+
Review Comment:
dulceanu opened a new pull request, #1508:
URL: https://github.com/apache/jackrabbit-oak/pull/1508
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli merged PR #1507:
URL: https://github.com/apache/jackrabbit-oak/pull/1507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli opened a new pull request, #1507:
URL: https://github.com/apache/jackrabbit-oak/pull/1507
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1506:
URL: https://github.com/apache/jackrabbit-oak/pull/1506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1506:
URL: https://github.com/apache/jackrabbit-oak/pull/1506
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1505:
URL: https://github.com/apache/jackrabbit-oak/pull/1505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1505:
URL: https://github.com/apache/jackrabbit-oak/pull/1505
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli merged PR #1504:
URL: https://github.com/apache/jackrabbit-oak/pull/1504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shodaaan commented on code in PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1624611555
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java:
##
@@ -152,20 +153,37 @@ public void propertyChanged(PropertyState
stefan-egli opened a new pull request, #1504:
URL: https://github.com/apache/jackrabbit-oak/pull/1504
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Joscorbe merged PR #1503:
URL: https://github.com/apache/jackrabbit-oak/pull/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Joscorbe commented on PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#issuecomment-2145265372
+1 from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
nfsantos merged PR #1501:
URL: https://github.com/apache/jackrabbit-oak/pull/1501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Joscorbe opened a new pull request, #1503:
URL: https://github.com/apache/jackrabbit-oak/pull/1503
This adds a new optional argument to `oak.findOne` method to oak-mongo.js.
This new parameter allows to control if the find should be extended to long
paths.
If the second parameter is
stefan-egli commented on code in PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1624467573
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java:
##
@@ -152,20 +153,37 @@ public void propertyChanged(PropertyState
stefan-egli merged PR #1502:
URL: https://github.com/apache/jackrabbit-oak/pull/1502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli opened a new pull request, #1502:
URL: https://github.com/apache/jackrabbit-oak/pull/1502
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli commented on PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#issuecomment-2144993219
@shodaaan `MoveVersionableNodeWithNodeRepositoryTest` is missing the license
header
--
This is an automated message from the Apache Git Service.
To respond to the message,
nfsantos opened a new pull request, #1501:
URL: https://github.com/apache/jackrabbit-oak/pull/1501
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ionutzpi commented on PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#issuecomment-2144652941
Hi @Joscorbe and @reschke could you please check the PR and approve it if
is fine?
--
This is an automated message from the Apache Git Service.
To respond to the message,
github-actions[bot] commented on PR #567:
URL: https://github.com/apache/jackrabbit-oak/pull/567#issuecomment-2144136858
This PR is stale because it has been open 24 months with no activity. Remove
stale label or comment or this will be closed in 30 days.
--
This is an automated message
github-actions[bot] closed pull request #555: Fix indeterminate map ordering
that may causes Sweep2Test to fail
URL: https://github.com/apache/jackrabbit-oak/pull/555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
anchela commented on PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#issuecomment-2142532334
@nscendoni , i had another look at the patch and tried to address the TODO.
lets set aside some time to go over the changes again, review if my updates are
reasonable, working and
reschke opened a new pull request, #1500:
URL: https://github.com/apache/jackrabbit-oak/pull/1500
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1500:
URL: https://github.com/apache/jackrabbit-oak/pull/1500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fabriziofortino merged PR #1492:
URL: https://github.com/apache/jackrabbit-oak/pull/1492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli merged PR #1499:
URL: https://github.com/apache/jackrabbit-oak/pull/1499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli opened a new pull request, #1499:
URL: https://github.com/apache/jackrabbit-oak/pull/1499
…a thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli commented on code in PR #1498:
URL: https://github.com/apache/jackrabbit-oak/pull/1498#discussion_r1620890209
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -270,7 +270,7 @@ public void tearDown()
stefan-egli merged PR #1498:
URL: https://github.com/apache/jackrabbit-oak/pull/1498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke commented on code in PR #1498:
URL: https://github.com/apache/jackrabbit-oak/pull/1498#discussion_r1620849115
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -270,7 +270,7 @@ public void tearDown()
stefan-egli opened a new pull request, #1498:
URL: https://github.com/apache/jackrabbit-oak/pull/1498
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli merged PR #1497:
URL: https://github.com/apache/jackrabbit-oak/pull/1497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli opened a new pull request, #1497:
URL: https://github.com/apache/jackrabbit-oak/pull/1497
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dulceanu merged PR #1496:
URL: https://github.com/apache/jackrabbit-oak/pull/1496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dulceanu opened a new pull request, #1496:
URL: https://github.com/apache/jackrabbit-oak/pull/1496
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli merged PR #1494:
URL: https://github.com/apache/jackrabbit-oak/pull/1494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
amit-jain opened a new pull request, #1495:
URL: https://github.com/apache/jackrabbit-oak/pull/1495
…dy running'
Minor: Changed message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
stefan-egli opened a new pull request, #1494:
URL: https://github.com/apache/jackrabbit-oak/pull/1494
…p narrow down where time is spent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shodaaan commented on code in PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1619342145
##
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/MoveVersionableNodeWithMemoryRepositoryTest.java:
##
@@ -0,0 +1,26 @@
+package
adelina-marian opened a new pull request, #1493:
URL: https://github.com/apache/jackrabbit-oak/pull/1493
Added a new page in the public documentation about different nsfixtures that
are available when running unit and integration tests.
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -216,7 +264,7 @@ static PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -216,7 +264,7 @@ static PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747131
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -227,8 +275,8 @@ PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -216,7 +264,7 @@ static PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747446
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -216,7 +264,7 @@ static PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618747131
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -227,8 +275,8 @@ PropertyState
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2137187902
@stefan-egli , see ticket for an explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618651613
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -75,10 +82,97 @@ public void
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618648423
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -227,8 +275,8 @@ PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618648931
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -216,7 +264,7 @@ static PropertyState
nscendoni opened a new pull request, #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618588187
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -75,10 +82,97 @@ public void
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618581875
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -216,7 +264,7 @@ static PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618377176
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -81,4 +88,83 @@ public void
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618376854
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -227,8 +275,8 @@ PropertyState
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618376527
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -116,7 +155,20 @@ public int count() {
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618372804
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +43,58 @@
import
ionutzpi commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1618298493
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -160,14 +161,14 @@ String getValue() {
reschke commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1617352712
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -160,14 +161,14 @@ String getValue() {
Joscorbe merged PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fabriziofortino opened a new pull request, #1492:
URL: https://github.com/apache/jackrabbit-oak/pull/1492
When ES cannot process a query, the generic message `all shards failed` is
printed in the logs. Adding the error cause in case of
`ElasticsearchException`s.
--
This is an automated
dulceanu merged PR #1485:
URL: https://github.com/apache/jackrabbit-oak/pull/1485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2135150432
@Joscorbe I see
NodeDocumentRevisionCleanerTest.testRecentRevisionsArePreserved failing - would
it be much effort to fix that before the merge?
--
This is an automated
mbaedke merged PR #1415:
URL: https://github.com/apache/jackrabbit-oak/pull/1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke merged PR #1491:
URL: https://github.com/apache/jackrabbit-oak/pull/1491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1491:
URL: https://github.com/apache/jackrabbit-oak/pull/1491
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke commented on code in PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1613082105
##
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/MoveVersionableNodeWithMemoryRepositoryTest.java:
##
@@ -0,0 +1,26 @@
+package
reschke commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1616858582
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +43,58 @@
import
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1616856073
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -81,4 +88,83 @@ public void
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1616853051
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -75,10 +82,97 @@ public void
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1616850420
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -116,7 +155,20 @@ public int count() {
301 - 400 of 3892 matches
Mail list logo
