stefan-egli commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2122879506
(maybe we could add a test case to reproduce real being different than
configured id - and then the result might be two additional properties would be
required, real and
rishabhdaim commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122821951
> @mbaedke yea I had second thought there as well. I'm fine with squeeze as
well. @rishabhdaim , @Joscorbe ?
I am fine with squashing too.
--
This is an automated
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122797901
@mbaedke yea I had second thought there as well. I'm fine with squeeze as
well. @rishabhdaim , @Joscorbe ?
--
This is an automated message from the Apache Git Service.
To
rishabhdaim commented on PR #1475:
URL: https://github.com/apache/jackrabbit-oak/pull/1475#issuecomment-2122780018
> +1, I think we could also do it for
rishabhdaim commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1608435082
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -38,6 +39,19 @@
public class
rishabhdaim commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1608433713
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##
@@ -38,6 +39,19 @@
public class
mbaedke commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122739659
@stefan-egli, is it really a good idea to do a merge commit? These are 160
commits and I would assume that many of them are intermediate changes or even
reverted later. If we do
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1608383806
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +43,52 @@
import
rishabhdaim opened a new pull request, #1475:
URL: https://github.com/apache/jackrabbit-oak/pull/1475
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mbaedke commented on PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2122526235
@jsedding Re removal of the pid field: AFAIU the Felix SCM plugin just
creates this explicitly with the default value. I have never seen that it
causes problems to drop that.
--
mbaedke commented on PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2122512332
@anchela I only tested with a local QS build. I don't even know if I can
easily access testing platforms for AEMaaCS deployments as an external dev.
--
This is an automated
rishabhdaim commented on PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#issuecomment-2122253471
@ionutzpi could you please add test cases for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ahanikel commented on PR #1427:
URL: https://github.com/apache/jackrabbit-oak/pull/1427#issuecomment-2122246769
@smiroslav Could you have another look at this one so we can also have it in
the 1.64 release?
--
This is an automated message from the Apache Git Service.
To respond to the
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122108802
I believe most of the cosmetic changes have been reverted and the PR is
ready for review again.
--
This is an automated message from the Apache Git Service.
To respond to
shodaaan commented on PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#issuecomment-2121908591
- included the unit test created by Adelina Marian, which reproduces the bug
- added a fix to VersionEditor that allows a node with mix:versionable to be
moved over a deleted
shodaaan opened a new pull request, #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rishabhdaim commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1606849052
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +43,59 @@
import
ionutzpi opened a new pull request, #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473
Added compression for values in DocumentPropertyState
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reschke merged PR #1472:
URL: https://github.com/apache/jackrabbit-oak/pull/1472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1472:
URL: https://github.com/apache/jackrabbit-oak/pull/1472
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1471:
URL: https://github.com/apache/jackrabbit-oak/pull/1471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1471:
URL: https://github.com/apache/jackrabbit-oak/pull/1471
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1470:
URL: https://github.com/apache/jackrabbit-oak/pull/1470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1470:
URL: https://github.com/apache/jackrabbit-oak/pull/1470
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1447:
URL: https://github.com/apache/jackrabbit-oak/pull/1447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1469:
URL: https://github.com/apache/jackrabbit-oak/pull/1469
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1469:
URL: https://github.com/apache/jackrabbit-oak/pull/1469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smiroslav merged PR #1468:
URL: https://github.com/apache/jackrabbit-oak/pull/1468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rootpea commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604916308
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
rootpea commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604916308
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
rootpea commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604916308
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
rootpea commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604794648
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
t-rana commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604654469
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
t-rana commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604654469
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
jsedding commented on PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2116952625
> [...] i am not sure that the new diff is actually good or still needs some
work.
@anchela At the risk of explaining things you already know, here I go. Most
remaining
rootpea commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604489667
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2116946297
@stefan-egli , I understood that it's not supposed to collide with a
simultaneously running read-write node. The proposal is not to change the
cluster id, but to add an additional
jsedding commented on code in PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#discussion_r1604478097
##
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactory.java:
##
@@ -45,100 +37,123
t-rana commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604391789
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
t-rana commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1604391435
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
stefan-egli merged PR #1467:
URL: https://github.com/apache/jackrabbit-oak/pull/1467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli opened a new pull request, #1467:
URL: https://github.com/apache/jackrabbit-oak/pull/1467
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115770736
I'm wondering if that wouldn't introduce a regression elsewhere .. there
must have been a reason this was set to 0 for read-only?
--
This is an automated message from the
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115695591
Potential fix: if in DocumentNodeStore#getMinExternalRevisions() we replace
getClusterId() - which is 0 in readonly mode - with the configured cluster id,
the problem disappears.
mbaedke commented on PR #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465#issuecomment-2115387932
Preliminary test. Please review if it makes any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mbaedke opened a new pull request, #1465:
URL: https://github.com/apache/jackrabbit-oak/pull/1465
…ect results in readonly mode
Added test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nfsantos merged PR #1461:
URL: https://github.com/apache/jackrabbit-oak/pull/1461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1603281901
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/LoggingDocumentStoreWrapper.java:
##
@@ -283,6 +283,7 @@ public T call()
nfsantos merged PR #1464:
URL: https://github.com/apache/jackrabbit-oak/pull/1464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos opened a new pull request, #1464:
URL: https://github.com/apache/jackrabbit-oak/pull/1464
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rootpea commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1602892162
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
rootpea commented on code in PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1602891748
##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,
nfsantos merged PR #1463:
URL: https://github.com/apache/jackrabbit-oak/pull/1463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos commented on code in PR #1461:
URL: https://github.com/apache/jackrabbit-oak/pull/1461#discussion_r1602707774
##
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java:
##
@@ -53,12 +52,7 @@ public static boolean isHidden(@NotNull String
nfsantos opened a new pull request, #1463:
URL: https://github.com/apache/jackrabbit-oak/pull/1463
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1443:
URL: https://github.com/apache/jackrabbit-oak/pull/1443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nit0906 commented on code in PR #1461:
URL: https://github.com/apache/jackrabbit-oak/pull/1461#discussion_r1602563040
##
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java:
##
@@ -53,12 +52,7 @@ public static boolean isHidden(@NotNull String
nit0906 commented on code in PR #1461:
URL: https://github.com/apache/jackrabbit-oak/pull/1461#discussion_r1602563040
##
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java:
##
@@ -53,12 +52,7 @@ public static boolean isHidden(@NotNull String
anchela commented on code in PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#discussion_r1601919321
##
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactory.java:
##
@@ -45,100 +37,123 @@
anchela commented on PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2112949606
@jsedding , thanks but honestly i am not sure that the new diff is
actually good or still needs some work.
--
This is an automated message from the Apache Git Service.
To
rishabhdaim merged PR #1462:
URL: https://github.com/apache/jackrabbit-oak/pull/1462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1601419791
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/LoggingDocumentStoreWrapper.java:
##
@@ -283,6 +283,7 @@ public T call()
rishabhdaim opened a new pull request, #1462:
URL: https://github.com/apache/jackrabbit-oak/pull/1462
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rishabhdaim merged PR #1460:
URL: https://github.com/apache/jackrabbit-oak/pull/1460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos merged PR #1456:
URL: https://github.com/apache/jackrabbit-oak/pull/1456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
t-rana commented on code in PR #1385:
URL: https://github.com/apache/jackrabbit-oak/pull/1385#discussion_r1601300901
##
oak-blob-cloud-azure/pom.xml:
##
@@ -50,8 +69,23 @@
azure-storage,
rishabhdaim opened a new pull request, #1460:
URL: https://github.com/apache/jackrabbit-oak/pull/1460
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
fabriziofortino merged PR #1450:
URL: https://github.com/apache/jackrabbit-oak/pull/1450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos commented on code in PR #1450:
URL: https://github.com/apache/jackrabbit-oak/pull/1450#discussion_r1601135655
##
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticCustomAnalyzerMappings.java:
##
@@ -112,78 +112,30 @@
nfsantos commented on code in PR #1456:
URL: https://github.com/apache/jackrabbit-oak/pull/1456#discussion_r1601044885
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedStrategy.java:
##
@@ -545,16 +540,32 @@ public
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600319735
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -290,6 +294,25 @@ public boolean
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600320404
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGCSupportTest.java:
##
@@ -18,42 +18,54 @@
*/
package
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600318877
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600318149
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/Utils.java:
##
@@ -178,7 +183,7 @@ public static NodeStore bootstrapNodeStore(NodeStoreOptions
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600317368
##
oak-pojosr/pom.xml:
##
@@ -365,5 +365,11 @@
testcontainers
test
+
+ org.testcontainers
+ testcontainers
+
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600316926
##
oak-jcr/pom.xml:
##
@@ -530,5 +530,11 @@
testcontainers
test
+
Review Comment:
removed in
stefan-egli merged PR #1459:
URL: https://github.com/apache/jackrabbit-oak/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2110630437
covered the first few comments (more of same kind will still be required
though) in https://github.com/apache/jackrabbit-oak/pull/1459
--
This is an automated message from
stefan-egli opened a new pull request, #1459:
URL: https://github.com/apache/jackrabbit-oak/pull/1459
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin commented on code in PR #1385:
URL: https://github.com/apache/jackrabbit-oak/pull/1385#discussion_r1600308692
##
oak-blob-cloud-azure/pom.xml:
##
@@ -50,8 +69,23 @@
azure-storage,
reschke commented on code in PR #1385:
URL: https://github.com/apache/jackrabbit-oak/pull/1385#discussion_r1600277450
##
oak-blob-cloud-azure/pom.xml:
##
@@ -50,8 +69,23 @@
azure-storage,
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2110560837
Agree, I think we started letting some minor, unrelated improvements slip
in, and we shouldn't have. I'm +1 for removing them.
--
This is an automated message from the
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600260838
##
oak-jcr/pom.xml:
##
@@ -530,5 +530,11 @@
testcontainers
test
+
Review Comment:
agree, looks unnecessary
--
This is an
reschke commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2110549414
I started to read, and it's a big change.
Without knowing the details of the design beforehand, it's hard to
understand what it does (but that's just a consequence of the
reschke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600226769
##
oak-jcr/pom.xml:
##
@@ -530,5 +530,11 @@
testcontainers
test
+
Review Comment:
This looks weird; why do we need the duplicate
stefan-egli merged PR #1458:
URL: https://github.com/apache/jackrabbit-oak/pull/1458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli commented on PR #1458:
URL: https://github.com/apache/jackrabbit-oak/pull/1458#issuecomment-211058
ok, let's do them as they come.. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rishabhdaim commented on PR #1458:
URL: https://github.com/apache/jackrabbit-oak/pull/1458#issuecomment-2110503398
@stefan-egli there are a couple more places in the VersionGarbageCollector
class inside JavaDocs & loggers where we are still using `Detailed` instead of
`Full`.
--
This is
rishabhdaim commented on code in PR #1456:
URL: https://github.com/apache/jackrabbit-oak/pull/1456#discussion_r1600227031
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedStrategy.java:
##
@@ -545,16 +540,32 @@ public
stefan-egli opened a new pull request, #1458:
URL: https://github.com/apache/jackrabbit-oak/pull/1458
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli commented on PR #1440:
URL: https://github.com/apache/jackrabbit-oak/pull/1440#issuecomment-2110436858
@daniancu , FTR, we should prefix the commit message with the jira ticket
(agreed upon practice, helps navigate commits)
--
This is an automated message from the Apache Git
reschke merged PR #1452:
URL: https://github.com/apache/jackrabbit-oak/pull/1452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli merged PR #1455:
URL: https://github.com/apache/jackrabbit-oak/pull/1455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos commented on code in PR #1456:
URL: https://github.com/apache/jackrabbit-oak/pull/1456#discussion_r1599889479
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -441,23 +441,24 @@
rishabhdaim commented on code in PR #1456:
URL: https://github.com/apache/jackrabbit-oak/pull/1456#discussion_r1599864900
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -441,23 +441,24
rishabhdaim commented on code in PR #1456:
URL: https://github.com/apache/jackrabbit-oak/pull/1456#discussion_r1599864900
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -441,23 +441,24
rishabhdaim opened a new pull request, #1455:
URL: https://github.com/apache/jackrabbit-oak/pull/1455
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nfsantos opened a new pull request, #1456:
URL: https://github.com/apache/jackrabbit-oak/pull/1456
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2109872762
Also note that this PR brings in the fullGC functionality completely
disabled by default. There will still be more hardening time needed - during
which this feature is
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2109862913
Note that the plan is to do a "merge commit" for this (i.e. _not_ via
squash), as it has a lot of useful commit history.
--
This is an automated message from the Apache Git
501 - 600 of 3892 matches
Mail list logo
