kwin commented on a change in pull request #110:
URL:
https://github.com/apache/jackrabbit-filevault/pull/110#discussion_r537551806
##########
File path:
vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/spi/impl/nodetype/JcrNodeTypeMetaDataImpl.java
##########
@@ -89,6 +89,9 @@
private static final Collection<Name> ALLOWED_PROTECTED_PROPERTIES =
Arrays.asList(NameConstants.JCR_PRIMARYTYPE,
NameConstants.JCR_MIXINTYPES);
+ // ignore mandatory protected properties from mix:versionable, they are
handled specifically in filevault (JCRVLT-485)
Review comment:
Probably we should exclude all properties listed in
https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L921
from both the mandatory check as well as the protected check. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
