[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #258: JCRVLT-670: Upgrade to commons-collections4

2022-12-13 Thread GitBox
kwin commented on code in PR #258: URL: https://github.com/apache/jackrabbit-filevault/pull/258#discussion_r1047461668 ## parent/pom.xml: ## @@ -502,7 +502,7 @@ Bundle-Category: jackrabbit org.apache.commons commons-collections4 -

[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #258: JCRVLT-670: Upgrade to commons-collections4

2022-12-13 Thread GitBox
kwin commented on code in PR #258: URL: https://github.com/apache/jackrabbit-filevault/pull/258#discussion_r1047467951 ## vault-core/pom.xml: ## @@ -182,6 +182,11 @@ org.osgi.framework provided + Review Comment: Having this depend

[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #258: JCRVLT-670: Upgrade to commons-collections4

2022-12-13 Thread GitBox
kwin commented on code in PR #258: URL: https://github.com/apache/jackrabbit-filevault/pull/258#discussion_r1047473081 ## vault-validation/pom.xml: ## @@ -124,6 +124,12 @@ ${project.version} compile + +org.apache.commons +

[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #258: JCRVLT-670: Upgrade to commons-collections4

2022-12-13 Thread GitBox
kwin commented on code in PR #258: URL: https://github.com/apache/jackrabbit-filevault/pull/258#discussion_r1047524811 ## parent/pom.xml: ## @@ -502,7 +502,7 @@ Bundle-Category: jackrabbit org.apache.commons commons-collections4 -

[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #258: JCRVLT-670: Upgrade to commons-collections4

2022-12-13 Thread GitBox
kwin commented on code in PR #258: URL: https://github.com/apache/jackrabbit-filevault/pull/258#discussion_r1047543525 ## parent/pom.xml: ## @@ -502,7 +502,7 @@ Bundle-Category: jackrabbit org.apache.commons commons-collections4 -