[GitHub] [jackrabbit-oak] kwin commented on pull request #794: OAK-10032 get rid of m-antrun-p to replace the main artifact

2022-12-16 Thread GitBox
kwin commented on PR #794: URL: https://github.com/apache/jackrabbit-oak/pull/794#issuecomment-1354711570 For me these changes can and should be applied independently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] kwin commented on pull request #794: OAK-10032 get rid of m-antrun-p to replace the main artifact

2022-12-16 Thread GitBox
kwin commented on PR #794: URL: https://github.com/apache/jackrabbit-oak/pull/794#issuecomment-1354628347 The same fix has to applied to that module (i.e. remove antrun there and create primary artifact with m-assembly-p) -- This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-oak] kwin commented on pull request #794: OAK-10032 get rid of m-antrun-p to replace the main artifact

2022-12-15 Thread GitBox
kwin commented on PR #794: URL: https://github.com/apache/jackrabbit-oak/pull/794#issuecomment-1354334231 > I continue to believe that we should not make too many changes at once in a single commit, as it makes it harder to to track why something changed, what ticket it is related to do,