mreutegg commented on code in PR #750:
URL: https://github.com/apache/jackrabbit-oak/pull/750#discussion_r1021632581
##########
oak-run/src/main/js/oak-mongo.js:
##########
@@ -433,6 +437,9 @@ var oak = (function(global){
unset["_collisions." + r] = "";
num++;
}
+ if (num >= limit) {
+ break;
Review Comment:
Hmm, not sure this is useful. The default limit is very high an unlikely to
be hit. When you give it a limit, then you know it may not clean up everything
and you have to run the command again. If there is nothing to clean up then
there is a message that says: "No collisions found for clusterId X".
Maybe rather a log message in any case that tells how many were removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
