[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-31 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r959344551 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -573,54 +575,53 @@ private List

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957038958 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSpellcheckTest.java: ## @@ -1,238 +0,0 @@ -/* Review Comment: ah. ok

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957008103 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSpellcheckTest.java: ## @@ -1,238 +0,0 @@ -/* Review Comment: Why

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957008103 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSpellcheckTest.java: ## @@ -1,238 +0,0 @@ -/* Review Comment: Why

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #679: OAK-9912: elastic spellcheck query with no descendants returns incorrect number of results

2022-08-29 Thread GitBox
nit0906 commented on code in PR #679: URL: https://github.com/apache/jackrabbit-oak/pull/679#discussion_r957000974 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -573,54 +575,53 @@ private List