Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke merged PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1481411760 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

kwin commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1480551675 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1480001891 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1480001891 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

kwin commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1479975009 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1479796001 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1479715212 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1479700535 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

kwin commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1463074893 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#issuecomment-1893857187 @kwin - please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

kwin commented on PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#issuecomment-1893722954 Just add it there, I probably just forgot to add such a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#issuecomment-1893716772 I had a look at ReferenceableIdentifiersImportIT, and the "parent node not found" case does not occur in these tests. Would you be ok i just adding all of the new test class

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#issuecomment-1893590618 Ack, will review. Maybe in the end this turns out to be an empty PR :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

kwin commented on PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#issuecomment-1893589005 There is ITs for all policies already in the aforementioned class! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke commented on PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#issuecomment-1893584257 I have added tests for the remaining policies and also added test expectations based on what filevault currently does. @kwin - will look into moving the tests next.

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

kwin commented on PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#issuecomment-1887362554 Can we add this to `ReferenceableIdentifiersImportIT`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] JCRVLT-737: test case [jackrabbit-filevault]

reschke opened a new pull request, #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To