Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541089542 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2022690091 > BranchCommitGCTest now fail due to using the new mode by default - requires fixing first before merging this will be handled in OAK-10726 now (to not block this PR)

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli merged PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541044437 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
stefan-egli commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541043816 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
rishabhdaim commented on PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2022597351 PR approved with a minor review comment that can be handled later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
rishabhdaim commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1540970470 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-27 Thread via GitHub
rishabhdaim commented on code in PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1540970470 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1007,6 +1008,10 @@ public void collectGar

Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-26 Thread via GitHub
stefan-egli commented on PR #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2021043000 BranchCommitGCTest now fail due to using the new mode by default - requires fixing first before merging this -- This is an automated message from the Apache Git Service. To r

[PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]

2024-03-26 Thread via GitHub
stefan-egli opened a new pull request, #1383: URL: https://github.com/apache/jackrabbit-oak/pull/1383 … and deleted properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment