Joscorbe merged PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackra
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2135150432
@Joscorbe I see
NodeDocumentRevisionCleanerTest.testRecentRevisionsArePreserved failing - would
it be much effort to fix that before the merge?
--
This is an automated messa
Joscorbe commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2133112904
I'm fine with squashing too @stefan-egli @rishabhdaim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611700150
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilder.java:
##
@@ -26,6 +26,8 @@
import org.apache.
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611669404
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -167,6 +169,8 @@ public class DocumentNodeSto
reschke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611566538
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilder.java:
##
@@ -26,6 +26,8 @@
import org.apache.jack
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611564170
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -167,6 +169,8 @@ public class DocumentNod
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611419373
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -167,6 +169,8 @@ public class DocumentNodeSto
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611354102
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -167,6 +169,8 @@ public class DocumentNod
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611352766
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -324,6 +346,11 @@ public T setNoChildOrde
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611352478
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -225,6 +236,8 @@ static DocumentStoreType
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611228918
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -225,6 +236,8 @@ static DocumentStoreType
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609854378
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -225,6 +236,8 @@ static DocumentStoreType fro
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609854378
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -225,6 +236,8 @@ static DocumentStoreType fro
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609851349
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -167,6 +169,8 @@ public class DocumentNodeSto
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609849335
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -324,6 +346,11 @@ public T setNoChildOrderCle
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122919624
previous, direct commit was just a fix for a previous revert - aka a detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
rishabhdaim commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122821951
> @mbaedke yea I had second thought there as well. I'm fine with squeeze as
well. @rishabhdaim , @Joscorbe ?
I am fine with squashing too.
--
This is an automated mess
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122797901
@mbaedke yea I had second thought there as well. I'm fine with squeeze as
well. @rishabhdaim , @Joscorbe ?
--
This is an automated message from the Apache Git Service.
To re
mbaedke commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122739659
@stefan-egli, is it really a good idea to do a merge commit? These are 160
commits and I would assume that many of them are intermediate changes or even
reverted later. If we do no
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122108802
I believe most of the cosmetic changes have been reverted and the PR is
ready for review again.
--
This is an automated message from the Apache Git Service.
To respond to the
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1603281901
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/LoggingDocumentStoreWrapper.java:
##
@@ -283,6 +283,7 @@ public T call()
rishabhdaim commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1601419791
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/LoggingDocumentStoreWrapper.java:
##
@@ -283,6 +283,7 @@ public T call()
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600319735
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -290,6 +294,25 @@ public boolean isThrott
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600320404
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGCSupportTest.java:
##
@@ -18,42 +18,54 @@
*/
package org.apache.jac
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600318877
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} - %
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600318149
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/Utils.java:
##
@@ -178,7 +183,7 @@ public static NodeStore bootstrapNodeStore(NodeStoreOptions
option
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600317368
##
oak-pojosr/pom.xml:
##
@@ -365,5 +365,11 @@
testcontainers
test
+
+ org.testcontainers
+ testcontainers
+ ${testcon
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600316926
##
oak-jcr/pom.xml:
##
@@ -530,5 +530,11 @@
testcontainers
test
+
Review Comment:
removed in https://github.com/apache/jackrabbit
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2110630437
covered the first few comments (more of same kind will still be required
though) in https://github.com/apache/jackrabbit-oak/pull/1459
--
This is an automated message from th
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2110560837
Agree, I think we started letting some minor, unrelated improvements slip
in, and we shouldn't have. I'm +1 for removing them.
--
This is an automated message from the Apache
stefan-egli commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600260838
##
oak-jcr/pom.xml:
##
@@ -530,5 +530,11 @@
testcontainers
test
+
Review Comment:
agree, looks unnecessary
--
This is an auto
reschke commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2110549414
I started to read, and it's a big change.
Without knowing the details of the design beforehand, it's hard to
understand what it does (but that's just a consequence of the com
reschke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1600226769
##
oak-jcr/pom.xml:
##
@@ -530,5 +530,11 @@
testcontainers
test
+
Review Comment:
This looks weird; why do we need the duplicate depe
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2109872762
Also note that this PR brings in the fullGC functionality completely
disabled by default. There will still be more hardening time needed - during
which this feature is disabled
stefan-egli commented on PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2109862913
Note that the plan is to do a "merge commit" for this (i.e. _not_ via
squash), as it has a lot of useful commit history.
--
This is an automated message from the Apache Git S
36 matches
Mail list logo
