Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim closed pull request #1418: OAK-10763 : fixed the skipping of orphan nodes in case parent is not … URL: https://github.com/apache/jackrabbit-oak/pull/1418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2058580981 As discussed offline I'd argue that an orphan node should be removed entirely - if a gc mode prevents that, it should be skipped. That makes verification stronger and keeps the

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057530328 With https://github.com/apache/jackrabbit-oak/pull/1421 PR, we are skipping the opportunity to clean other types of garbage. If we want to go via https://github.com/apache/j

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057474619 also note my alternative PR suggestion at https://github.com/apache/jackrabbit-oak/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the me

[PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim opened a new pull request, #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418 …existing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri