[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271254#comment-13271254
]
Jukka Zitting commented on OAK-89:
--
bq. precedence to using assertions instead
OK by me.
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271223#comment-13271223
]
Michael Dürig commented on OAK-89:
--
bq. Here's how I'd define the error-handling for the
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271266#comment-13271266
]
Michael Dürig commented on OAK-89:
--
bq. The trouble with this approach is that the NameMapper
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271321#comment-13271321
]
Julian Reschke commented on OAK-89:
---
bq. Sounds like a good idea to me.
I'll try the latest
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271390#comment-13271390
]
Michael Dürig commented on OAK-89:
--
bq. Constructing an exception can be time-consuming,...
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271408#comment-13271408
]
Jukka Zitting commented on OAK-89:
--
OK. I went ahead and dcommitted all these changes in
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270297#comment-13270297
]
Thomas Mueller commented on OAK-89:
---
I have the same concerns as Michael. I believe if we
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270308#comment-13270308
]
Jukka Zitting commented on OAK-89:
--
bq. I would make OakException which extends from
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270312#comment-13270312
]
Thomas Mueller commented on OAK-89:
---
Yes, it makes sense to wait until we have real cases.
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270346#comment-13270346
]
Michael Dürig commented on OAK-89:
--
Thinking a bit more about this, I'm fine with using
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270401#comment-13270401
]
Michael Dürig commented on OAK-89:
--
The attached patch exemplifies what I meant with my last
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270454#comment-13270454
]
Jukka Zitting commented on OAK-89:
--
In the patch I see two places where the
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270550#comment-13270550
]
Michael Dürig commented on OAK-89:
--
Why {{AbstractNameMapper.getJcrName()}} should throw a
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270016#comment-13270016
]
Jukka Zitting commented on OAK-89:
--
bq. What do you do when you need to implement
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269905#comment-13269905
]
Jukka Zitting commented on OAK-89:
--
-1 to {{extends RuntimeException}}
In cases where we
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269918#comment-13269918
]
Julian Reschke commented on OAK-89:
---
When I proposed this I was under the assumption that
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270024#comment-13270024
]
Michael Dürig commented on OAK-89:
--
bq. Do we have a particular case where the first two
17 matches
Mail list logo
