Hi Jukka.
> Esteban, since this issue has already been closed for 1.4, it would be better
> if you created new
> Jira issues for any improvements or other changes. That would make it much
> easier to track which
> changes are being included in which release.
Sorry, I'll consider this next tim
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569215#action_12569215
]
Jukka Zitting commented on JCR-1154:
Esteban, since this issue has already been closed fo
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566057#action_12566057
]
Thomas Mueller commented on JCR-1154:
-
Javadoc comment fixed in revision 618935
> Databa
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565754#action_12565754
]
Esteban Franqueiro commented on JCR-1154:
-
The following javadoc comment should be re
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552664
]
Thomas Mueller commented on JCR-1154:
-
Hi,
I have tested it again and my results are:
When storing an object, a t
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552534
]
Esteban Franqueiro commented on JCR-1154:
-
Thomas, with the test I posted in JCR-1250 I see that there's still
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551547
]
Esteban Franqueiro commented on JCR-1154:
-
Really interesting. Have you thought about the use case of the GC ru
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551546
]
Thomas Mueller commented on JCR-1154:
-
Hi,
The solution I am working on right now is: add a method
public Garbage
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551541
]
Esteban Franqueiro commented on JCR-1154:
-
Stefan,
> the said method is not public since it returns *all* work
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551512
]
Esteban Franqueiro commented on JCR-1154:
-
> Do you still need this?
Yes.
> FileDataRecord is now protected,
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551502
]
Thomas Mueller commented on JCR-1154:
-
> FileDataRecord class should be public, and the DataRecord interface should
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551495
]
Thomas Mueller commented on JCR-1154:
-
Stefan, I don't think we are talking about the same issue. It was never the
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551448
]
Stefan Guggisberg commented on JCR-1154:
> Esteban Franqueiro commented on JCR-1154:
>
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_1255
]
Esteban Franqueiro commented on JCR-1154:
-
Hi Thomas.
I noticed that you made the FileDataRecord public, but it
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550996
]
Esteban Franqueiro commented on JCR-1154:
-
I see you have updated the impl. I'm checkin it out right now. I hav
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550108
]
Esteban Franqueiro commented on JCR-1154:
-
Also, I think DataRecord class should be public, and have a getLastM
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550104
]
Thomas Mueller commented on JCR-1154:
-
The original message may not be very helpful. I think it's better to add as
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550099
]
Esteban Franqueiro commented on JCR-1154:
-
Why have to write
catch (SomeException e) {
throw new DataStoreE
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550094
]
Thomas Mueller commented on JCR-1154:
-
There is: "public DataStoreException(String message, Throwable cause)". Is t
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550093
]
Esteban Franqueiro commented on JCR-1154:
-
Shouldn't the DataStoreException (as well as every exception, actual
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539555
]
Thomas Mueller commented on JCR-1154:
-
In revision 591286, the DataStore throws DataStoreException instead of
IOEx
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539451
]
Esteban Franqueiro commented on JCR-1154:
-
See
http://www.nabble.com/Re%3A--jira--Commented%3A-%28JCR-1154%29-
Hi Thomas.
> - please use spaces, not tabs (Jackrabbit consistently uses spaces)
> - please don't use import ...*
> - byte b[] > byte[] b
> - public is not required in interfaces
> - return does not require (..)
>
> To fix such problems, I use Checkstyle. If you like I can post the
> configuratio
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539341
]
Thomas Mueller commented on JCR-1154:
-
Hi,
Thanks again for the patch! And sorry for the delay. I have a few remar
Hi,
Sorry, not yet... I will work on it again in a day or two.
Thanks,
Thomas
On 10/25/07, Esteban Franqueiro <[EMAIL PROTECTED]> wrote:
> Hi Thomas.
> Do you have a patch that could be applied to trunk in order to begin
> testing our newest code and phase out 1.3.*?
> Thanks a lot.
> Regards,
>
Hi Thomas.
Do you have a patch that could be applied to trunk in order to begin
testing our newest code and phase out 1.3.*?
Thanks a lot.
Regards,
Esteban Franqueiro
[EMAIL PROTECTED]
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., i
[
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534308
]
Thomas Mueller commented on JCR-1154:
-
Thanks a lot for your help Esteban!
I'm currently trying to integrate this
27 matches
Mail list logo
