[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-26 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545383 ] Thomas Mueller commented on JCR-1232: - Both patches have their own disadvantages: - Jukka's patch is slower (more

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545081 ] Thomas Mueller commented on JCR-1232: - > ItemId extends Serializable Yes, sorry, I forgot that. Also I didn't test

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Esteban Franqueiro (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545070 ] Esteban Franqueiro commented on JCR-1232: - To cope with the existing code, shouldn't be public interface ItemId

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545067 ] Thomas Mueller commented on JCR-1232: - sorry I named my patch the same as you did. Mine is the shorter one. > Merg

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Stefan Guggisberg (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545042 ] Stefan Guggisberg commented on JCR-1232: while i do share tom's concerns regarding code duplication in general

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Esteban Franqueiro (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545041 ] Esteban Franqueiro commented on JCR-1232: - If getUUID() is used by applications, then I would say a behavior li

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545031 ] Thomas Mueller commented on JCR-1232: - In my view duplicating source code is worse than adding an interface, but N

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545020 ] Marcel Reutegger commented on JCR-1232: --- > public class UUIDNodeId extends UUID implements NodeId { ... } I don

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545015 ] Thomas Mueller commented on JCR-1232: - > public class UUIDNodeId extends UUID implements NodeId { ... } Cool! (Or

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545009 ] Jukka Zitting commented on JCR-1232: Hmm, a nice alternative: We should in fact be making NodeId an interface and

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544996 ] Jukka Zitting commented on JCR-1232: > Sorry, I really prefer having only one copy of the UUID code. It doesn't >

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544990 ] Thomas Mueller commented on JCR-1232: - > public UUID getUUID() { return new UUID(msb, lsb); } That would be a sol

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Stefan Guggisberg (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544988 ] Stefan Guggisberg commented on JCR-1232: nice! +1 for jukka's patch > Merge UUID to NodeId > -

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544985 ] Jukka Zitting commented on JCR-1232: If needed, we could keep the getUUID() method around as a deprecated one for

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544984 ] Jukka Zitting commented on JCR-1232: Thomas: > Create a interface UUID a interface I like the idea, but it would

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544980 ] Thomas Mueller commented on JCR-1232: - The name 'UUID' is currently used by some central components (for example p

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544975 ] Marcel Reutegger commented on JCR-1232: --- +1 > Merge UUID to NodeId > > > Ke