[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12738363#action_12738363
]
Jukka Zitting commented on JCR-1972:
One more thing... Your patch referenced a
[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12738544#action_12738544
]
Paco Avila commented on JCR-1972:
-
Sorry for the missing test class. I did no review of the
[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732525#action_12732525
]
Jukka Zitting commented on JCR-1972:
Thanks for the update! Still more comments:
* It
[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12730818#action_12730818
]
Jukka Zitting commented on JCR-1972:
The patch is creating lots of duplicate code in the
[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12730304#action_12730304
]
Paco Avila commented on JCR-1972:
-
In 1.x branch, the class
[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729069#action_12729069
]
Paco Avila commented on JCR-1972:
-
As I wrote some time ago, these modifications make two
[
https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671808#action_12671808
]
Alexander Klimetschek commented on JCR-1972:
Could you provide the diff in a
