Re: [jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-17 Thread Padraic Hannon
Looking briefly at the code, it doesn't look like having a single instance of a persistence manager would cause too many issues given the datasourcepersistence manager as I implemented it. I do not have any class level variables that would be used to do work in multiple threads (ie no connectio

Re: [jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-17 Thread Padraic Hannon
I completely agree with that approach (TDD). I think examining how systems like hibernate and toplink handle session/connection relationships would point us in the right direction. Since jackrabbit is seen as something embedded within the servlet container using an embedded db I see the reason

Re: [jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-16 Thread Thomas Mueller
Hi, Currently Jackrabbit uses one persistence manager per workspace, and one for versioning. That means the same persistence manager is used for all sessions (in a workspace). > there should be a new manager per session, ie per usage thread. While the current architecture has advantages, the app

Re: [jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-16 Thread Padraic I. Hannon
I think at the core I am thinking that the persistence manager need not be a single threaded mechanism for accessing the database. If a connection manager is a singleton I can see the argument for thread safety, however, I do not see why these would have to be singletons, I'll look more into ho

Re: [jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-09 Thread Thomas Mueller
Hi, > I am not suggesting this be the only driver, just that the JNDI drive should > be built in such a way as to make use of the facilities provided by JEE > containers (datasources, jta, etc). I think using JNDI as an alternative way to get the connection is fine. > > Do you suggest to creat

Re: [jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-07 Thread hannonpi
See reply threaded below. Perhaps this should be moved into the Jira ticket? -paddy Thomas Mueller-6 wrote: > > Hi, > > I'm not sure if I understand this request for improvement. > >> Using datasources > > So you suggest to use DataSource.getConnection(..) instead of > DriverManager.getConn

Re: [jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-02 Thread Thomas Mueller
Hi, I'm not sure if I understand this request for improvement. > Using datasources So you suggest to use DataSource.getConnection(..) instead of DriverManager.getConnection(..)? How do you get / create the datasource object, using JNDI? What about embedded applications where JNDI is not availabl

[jira] Created: (JCR-1050) Remove synchronization from JNDI data sources

2007-08-01 Thread Padraic Hannon (JIRA)
Remove synchronization from JNDI data sources - Key: JCR-1050 URL: https://issues.apache.org/jira/browse/JCR-1050 Project: Jackrabbit Issue Type: Improvement Components: core Affects