[ 
https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger reopened JCR-1209:
-----------------------------------


> There is no need to save them individually because checked in node must not 
> have pending changes ...

I'm not sure this is really the case. While fixing JCR-975 I was tempted to 
also change the checkout method. I then realized there is no 
InvalidItemStateException on the checkout method. Jackrabbit also does not 
check whether there are pending changes on the session if checkout is called.

With your patch it may happen that pending changes on a checked out versionable 
child node are saved on checkout of the current node.

> NodeImpl.checkot() calls save() two times
> -----------------------------------------
>
>                 Key: JCR-1209
>                 URL: https://issues.apache.org/jira/browse/JCR-1209
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: versioning
>    Affects Versions: 1.3.3, 1.4
>            Reporter: Przemo Pakulski
>            Priority: Minor
>             Fix For: 1.4
>
>
> Similar to JCR-975, The version related properties on a versionable node that 
> is checked out are saved individually. There is no need to save them 
> individually because checkd in node must not have pending changes and save() 
> can be called safely on the node itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to