UserManager API strangeness

2010-03-11 Thread Felix Meschberger
Hi, Forgive me if this has been discussed before (yes, I know I should RTFM and list archives). I see the UserManager interface has an autoSave(boolean) method, which must be called to have the user manager persist any created users and groups immediately after creation. The setup can also be

UserManager API strangeness (II)

2010-03-11 Thread Felix Meschberger
Hi another thing striked me looking at the UserManager API: there are 4 create methods: createGroup(Principal); createGroup(Principal, String); createUser(String userID, String password, Principal principal, String intermediatePath); createUser(String userID,

Re: UserManager API strangeness (II)

2010-03-11 Thread Angela Schreiber
Felix Meschberger wrote: Hi another thing striked me looking at the UserManager API: there are 4 create methods: createGroup(Principal); createGroup(Principal, String); createUser(String userID, String password, Principal principal, String intermediatePath);

Re: UserManager API strangeness

2010-03-11 Thread Angela Schreiber
hi What strikes me is, that to actually persist changes made by the UserManager, the Session.save() method must be called. IMHO for a proper level of alignment, the UserManager should probably be extended with save() and rollback() methods. i don't think this is required. JSR 283 defines

Re: UserManager API strangeness

2010-03-11 Thread Felix Meschberger
Hi, On 11.03.2010 12:14, Angela Schreiber wrote: hi What strikes me is, that to actually persist changes made by the UserManager, the Session.save() method must be called. IMHO for a proper level of alignment, the UserManager should probably be extended with save() and rollback() methods.

Re: UserManager API strangeness (II)

2010-03-11 Thread Felix Meschberger
I created JCR-2563 [1] with a proposed patch adding said createGroup(String) method. Anyway opposed to me applying this patch ? Regards Felix [1] https://issues.apache.org/jira/browse/JCR-2563 On 11.03.2010 12:38, Felix Meschberger wrote: Hi, On 11.03.2010 12:06, Angela Schreiber wrote: