averma21 merged pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r740121152
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseAndSortTask.java
##
@@ -263,15 +269,2
thomasmueller commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r737417571
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseAndSortTask.java
##
@@ -172,22 +
fabriziofortino commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r735771546
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java
##
@@ -5
fabriziofortino commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r735765174
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java
##
@@ -71,7 +71,7
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r735546985
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseAndSortTask.java
##
@@ -239,7 +246,9
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r735532339
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/DefaultMemoryManager.java
##
@@ -109,7 +110,8
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r735292431
##
File path:
oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStoreTest.java
##
@@ -348,11 +349,12
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r735291500
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseAndSortTask.java
##
@@ -172,14 +173,2
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r727798177
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/StoreAndSortStrategy.java
##
@@ -62,8 +63,12
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r727903237
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/DefaultMemoryManager.java
##
@@ -209,11 +211,
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r727805233
##
File path:
oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStoreTest.java
##
@@ -294,7 +295,7 @@
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r727804054
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseAndSortTask.java
##
@@ -172,14 +173,2
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r727803822
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/StoreAndSortStrategy.java
##
@@ -62,8 +63,12
averma21 commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r727798177
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/StoreAndSortStrategy.java
##
@@ -62,8 +63,12
thomasmueller commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r724034175
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/DefaultMemoryManager.java
##
@@ -209,11
thomasmueller commented on a change in pull request #383:
URL: https://github.com/apache/jackrabbit-oak/pull/383#discussion_r724034175
##
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/DefaultMemoryManager.java
##
@@ -209,11
Hi Padraic,
Padraic Hannon wrote:
in terms of where threads lock, and I have tons of
thread dumps showing this under load
did you create jira issues for the deadlocks you encountered? There are a number
of issues we fixed in trunk and the 1.3 branch but if you still see deadlocks
please repo
I think it may be best to take a long look at the various
*ItemStateManager classes in a holistic manner. It appears that these
classes introduce a lot of the locking and synchronization issues (as
would be expected from such a key group of classes). The movement
towards using more fine
Hi,
On Dec 18, 2007 12:23 PM, Marcel Reutegger <[EMAIL PROTECTED]> wrote:
> there are a number of synchronization issues I would like to resolve for the
> 1.4
> release.
+1, I'll hold off branching 1.4 until we get these issues resolved.
> comments are welcome.
See com
I forgot one issue:
JCR-1148 - may happen with both ISMLocking implementations. the fix is IMO quite
easy and low risk: move synchronization of mod count into copy().
regards
marcel
Marcel Reutegger wrote:
hi all,
there are a number of synchronization issues I would like to resolve for
hi all,
there are a number of synchronization issues I would like to resolve for the 1.4
release. some of them are related to using the new FineGrainedISMLocking but
most of them are general synchronization issues that may happen with both
DefaultISMLocking and FineGrainedISMLocking, though
22 matches
Mail list logo
