tmaret commented on PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#issuecomment-2086372403
> So that would indicate that ExportOptions.setRootPath(...) should rather
expect repo format and escape to platform format within FileVault code, right.
That way only
[
https://issues.apache.org/jira/browse/JCRVLT-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-751:
---
Fix Version/s: 3.7.4
> ExportOptions.rootPath not properly converted to platform name format
[
https://issues.apache.org/jira/browse/JCRVLT-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-751:
---
Summary: ExportOptions.rootPath not properly converted to platform name
format (was:
[
https://issues.apache.org/jira/browse/JCRVLT-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-751:
---
Assignee: Konrad Windszus
Status: Patch Available (was: Open)
>
kwin commented on PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#issuecomment-2085643579
> Both modules would need to be patched which is manageable
So that would indicate that `ExportOptions.setRootPath(...)` should rather
expect repo format and escape to
tmaret commented on PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#issuecomment-2085581517
Good point
Adobe has only one user synchronisation feature that relies on
`ExportOptions#setRootPath`.
Apache Sling Content Distribution [also relies on that
kwin commented on PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#issuecomment-2085455751
@tmaret Maybe you can quickly check the AEM code base for usages of
ExportOptions.setRootPath() to see how it was used?
--
This is an automated message from the Apache Git
tmaret commented on PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#issuecomment-2085451871
Thank you @kwin ! For me either way is fine, we could escape the path in our
code with PlatformNameFormat or have FV escape. I agree that we should aim for
the option that is
kwin commented on code in PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#discussion_r1584902674
##
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/ExportOptions.java:
##
@@ -102,15 +103,15 @@ public String getRootPath() {
* generate
[
https://issues.apache.org/jira/browse/JCRVLT-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-751:
---
Summary: ExportOptions.rootPath not properly unescaped during filter rule
mapping (was:
kwin closed pull request #326: JCRVLT-737 failing testcase
URL: https://github.com/apache/jackrabbit-filevault/pull/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin commented on PR #326:
URL:
https://github.com/apache/jackrabbit-filevault/pull/326#issuecomment-2085431923
Superseded by #328.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kwin commented on code in PR #334:
URL:
https://github.com/apache/jackrabbit-filevault/pull/334#discussion_r1584893635
##
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/UserExportIT.java:
##
@@ -0,0 +1,148 @@
+/*
+ *
kwin commented on PR #334:
URL:
https://github.com/apache/jackrabbit-filevault/pull/334#issuecomment-2085429128
Superseded by #336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kwin closed pull request #334: JCRVLT-751 - Add a test that demonstrates the
issue
URL: https://github.com/apache/jackrabbit-filevault/pull/334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kwin commented on code in PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#discussion_r1584891662
##
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/UserContentPackageIT.java:
##
@@ -105,6 +105,15
kwin commented on PR #336:
URL:
https://github.com/apache/jackrabbit-filevault/pull/336#issuecomment-2084765626
@tmaret Please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kwin opened a new pull request, #336:
URL: https://github.com/apache/jackrabbit-filevault/pull/336
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
18 matches
Mail list logo
