nfsantos commented on code in PR #1159:
URL: https://github.com/apache/jackrabbit-oak/pull/1159#discussion_r1361924260
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java:
##
@@ -86,10 +86,6 @@ public String
reschke commented on code in PR #1146:
URL: https://github.com/apache/jackrabbit-oak/pull/1146#discussion_r1361934632
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionableState.java:
##
@@ -285,8 +287,32 @@ private void restoreFrozen(@NotNull
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1361878571
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
thomasmueller commented on PR #1159:
URL: https://github.com/apache/jackrabbit-oak/pull/1159#issuecomment-1766130468
Micro-benchmark and results:
```
package org.apache.jackrabbit.oak.index.indexer.document.flatfile;
import java.util.ArrayList;
import
nfsantos commented on PR #1159:
URL: https://github.com/apache/jackrabbit-oak/pull/1159#issuecomment-1766166956
I rerun the tests with 20 properties per node and with larger values in the
property, which I think is a more realistic scenario. The sorted version is
slower, around 15% slower.
nit0906 commented on PR #1158:
URL: https://github.com/apache/jackrabbit-oak/pull/1158#issuecomment-1766200177
imo, we could actually hold off on this change and simply handle in the
client verification script instead.
Changing the behaviour of the public asJson method doesn’t seem
nit0906 closed pull request #1158: Oak-10497 | Properties order in FFS can be
different across runs
URL: https://github.com/apache/jackrabbit-oak/pull/1158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sonarcloud[bot] commented on PR #1159:
URL: https://github.com/apache/jackrabbit-oak/pull/1159#issuecomment-1766461047
Kudos, SonarCloud Quality Gate passed! [ the IndexName class to oak-core, and deprecated the
old class.
--
This is an automated message from the Apache Git Service.
anchela commented on code in PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#discussion_r1371690609
##
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserPrincipalProvider.java:
##
@@ -209,6 +203,21 @@ public Iterator findPrincipals(int
anchela commented on code in PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#discussion_r1371688768
##
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserPrincipalProvider.java:
##
@@ -209,6 +203,21 @@ public Iterator findPrincipals(int
anchela commented on code in PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#discussion_r1371646420
##
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserPrincipalProvider.java:
##
@@ -209,6 +203,21 @@ public Iterator findPrincipals(int
anchela commented on code in PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#discussion_r1371652407
##
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupMembershipReader.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software
sii74826 opened a new pull request, #1179:
URL: https://github.com/apache/jackrabbit-oak/pull/1179
Draft PR just to see branch health
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sonarcloud[bot] commented on PR #1180:
URL: https://github.com/apache/jackrabbit-oak/pull/1180#issuecomment-1779582381
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #1175:
URL: https://github.com/apache/jackrabbit-oak/pull/1175#issuecomment-1771493255
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
amit-jain commented on code in PR #1155:
URL: https://github.com/apache/jackrabbit-oak/pull/1155#discussion_r1374372767
##
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/CachingDataStoreTest.java:
##
@@ -638,4 +644,41 @@ private void waitFinish() {
nfsantos opened a new pull request, #1182:
URL: https://github.com/apache/jackrabbit-oak/pull/1182
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mbaedke closed pull request #1146: OAK-9459: ConstraintViolationException in
VersionManagerImplRestore w…
URL: https://github.com/apache/jackrabbit-oak/pull/1146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mbaedke commented on PR #1146:
URL: https://github.com/apache/jackrabbit-oak/pull/1146#issuecomment-1782651244
Replaced by https://github.com/apache/jackrabbit-oak/pull/1183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
fabriziofortino merged PR #1161:
URL: https://github.com/apache/jackrabbit-oak/pull/1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #317:
URL: https://github.com/apache/jackrabbit-filevault/pull/317
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mbaedke merged PR #1183:
URL: https://github.com/apache/jackrabbit-oak/pull/1183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ahanikel commented on PR #1171:
URL: https://github.com/apache/jackrabbit-oak/pull/1171#issuecomment-1788677393
@smiroslav @dulceanu Could you have a look when you have time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jochen-a-klein opened a new pull request, #318:
URL: https://github.com/apache/jackrabbit-filevault/pull/318
Improve the platform exporter:
- Pruning
keep track of the used directories and delete unused directories when
pruning
- Tracking
Track file creation with the correct
reschke opened a new pull request, #319:
URL: https://github.com/apache/jackrabbit-filevault/pull/319
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin commented on code in PR #319:
URL:
https://github.com/apache/jackrabbit-filevault/pull/319#discussion_r1376744943
##
RELEASE-NOTES.txt:
##
@@ -9,6 +9,28 @@ create portable packages of repository content.
The Vault Command Line Interface aka "vlt" provides a subversion
fabriziofortino commented on code in PR #1086:
URL: https://github.com/apache/jackrabbit-oak/pull/1086#discussion_r1379040534
##
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/tools/IndexComparator.java:
##
@@ -0,0 +1,247 @@
+/* Licensed to the Apache
sonarcloud[bot] commented on PR #1181:
URL: https://github.com/apache/jackrabbit-oak/pull/1181#issuecomment-1789288262
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke opened a new pull request, #320:
URL: https://github.com/apache/jackrabbit-filevault/pull/320
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
anchela commented on PR #1181:
URL: https://github.com/apache/jackrabbit-oak/pull/1181#issuecomment-1789158279
@nscendoni , as discussed in private i corrected the misleading comment in
testDefaultSyncClearsDynamicProperties... the usual
copy-paste-and-forget-to-adjust
--
This is an
reschke closed pull request #320: JCR-4985: incorrect path in release
instructions
URL: https://github.com/apache/jackrabbit-filevault/pull/320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
anchela merged PR #1181:
URL: https://github.com/apache/jackrabbit-oak/pull/1181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #321:
URL: https://github.com/apache/jackrabbit-filevault/pull/321
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mreutegg opened a new pull request, #1185:
URL: https://github.com/apache/jackrabbit-oak/pull/1185
Suggested changes to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ahanikel commented on code in PR #1155:
URL: https://github.com/apache/jackrabbit-oak/pull/1155#discussion_r1380451285
##
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/CachingDataStoreTest.java:
##
@@ -638,4 +643,34 @@ private void waitFinish() {
stefan-egli commented on PR #1184:
URL: https://github.com/apache/jackrabbit-oak/pull/1184#issuecomment-1790709799
Merged #1185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ahanikel commented on code in PR #1155:
URL: https://github.com/apache/jackrabbit-oak/pull/1155#discussion_r1380152396
##
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/CachingDataStoreTest.java:
##
@@ -638,4 +643,34 @@ private void waitFinish() {
mreutegg commented on PR #1185:
URL: https://github.com/apache/jackrabbit-oak/pull/1185#issuecomment-1790623844
> Question regarding the move of the checkpoint creation back 1 week : what
is the idea / reasoning of that?
It is easier for me to understand what the test is doing and as
amit-jain commented on code in PR #1155:
URL: https://github.com/apache/jackrabbit-oak/pull/1155#discussion_r1380003902
##
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/CachingDataStoreTest.java:
##
@@ -638,4 +644,41 @@ private void waitFinish() {
stefan-egli merged PR #1185:
URL: https://github.com/apache/jackrabbit-oak/pull/1185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1184:
URL: https://github.com/apache/jackrabbit-oak/pull/1184#issuecomment-1790854985
Kudos, SonarCloud Quality Gate passed! [ {
amit-jain commented on code in PR #1155:
URL: https://github.com/apache/jackrabbit-oak/pull/1155#discussion_r1380002103
##
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/CachingDataStoreTest.java:
##
@@ -638,4 +643,34 @@ private void waitFinish() {
reschke opened a new pull request, #1186:
URL: https://github.com/apache/jackrabbit-oak/pull/1186
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #1186:
URL: https://github.com/apache/jackrabbit-oak/pull/1186#issuecomment-1791383731
Kudos, SonarCloud Quality Gate passed! [ on
implementation details.
Even thought this would be a good idea, I did not switch to Json output so
far,
mbaedke merged PR #1141:
URL: https://github.com/apache/jackrabbit-oak/pull/1141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1381485102
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
thomasmueller commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1381541629
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
reschke merged PR #1188:
URL: https://github.com/apache/jackrabbit-oak/pull/1188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fabriziofortino commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1381806891
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java:
##
@@ -427,10 +426,14 @@ public String getPlan(NodeState rootState) {
amit-jain commented on code in PR #1155:
URL: https://github.com/apache/jackrabbit-oak/pull/1155#discussion_r1381605405
##
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/CachingDataStoreTest.java:
##
@@ -638,4 +643,35 @@ private void waitFinish() {
reschke opened a new pull request, #1188:
URL: https://github.com/apache/jackrabbit-oak/pull/1188
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
thomasmueller commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1381690261
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
fabriziofortino commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1381788455
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/nodetype/NodeTypeIndex.java:
##
@@ -102,7 +102,10 @@ public Cursor query(Filter
thomasmueller commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1381541629
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
sonarcloud[bot] commented on PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#issuecomment-1792355532
SonarCloud Quality Gate failed. [ {
nfsantos commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1381748274
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mbaedke merged PR #1186:
URL: https://github.com/apache/jackrabbit-oak/pull/1186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#issuecomment-1792588693
SonarCloud Quality Gate failed. [ {
sonarcloud[bot] commented on PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#issuecomment-1792674489
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #1191:
URL: https://github.com/apache/jackrabbit-oak/pull/1191#issuecomment-1797044874
SonarCloud Quality Gate failed. [ {
dulceanu merged PR #1171:
URL: https://github.com/apache/jackrabbit-oak/pull/1171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
thomasmueller commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1384539736
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation
thomasmueller commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1384455460
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation
thomasmueller commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1384457402
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation
thomasmueller commented on code in PR #1187:
URL: https://github.com/apache/jackrabbit-oak/pull/1187#discussion_r1384457402
##
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryFormatter.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation
ahanikel commented on PR #1171:
URL: https://github.com/apache/jackrabbit-oak/pull/1171#issuecomment-1798180621
@dulceanu Thanks for the approval! Could you also merge the PR? I don't have
the rights to do that.
--
This is an automated message from the Apache Git Service.
To respond to
sonarcloud[bot] commented on PR #1086:
URL: https://github.com/apache/jackrabbit-oak/pull/1086#issuecomment-1798306885
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1192:
URL: https://github.com/apache/jackrabbit-oak/pull/1192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1086:
URL: https://github.com/apache/jackrabbit-oak/pull/1086#issuecomment-1798272480
SonarCloud Quality Gate failed. [