[jclouds-labs] Cloudsigma v2 API Pagination (#35)

I'll squash the commits after you consider code is ready to be merged. You can merge this Pull Request by running: git pull https://github.com/cloudsigma/jclouds-labs cloudsigma2-api-pagination Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pul

[jclouds-examples] JCLOUDS-215 Add autoscale examples (#24)

You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-examples autoscale-examples Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-examples/pull/24 -- Commit Summary -- * JCLOUDS-215 Add autoscale examples --

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

@sallum could you change the style so the code is indented with 3 spaces? Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28339955

Re: PATCH requests

This is great news Ignacio. Thanks for contributing! I see you already created a JIRA issue for adding PATCH [1]. Could you please also add a JIRA issue for the OpenStack Glance work you're doing? Something similar to the JIRA issue I created for OpenStack Marconi [2]. I've also added you to th

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

[jclouds-java-7-pull-requests #853](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/853/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/202#issuecomment-28315114

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

[jclouds-pull-requests #390](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/390/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/202#issuecomment-28315059

[jclouds] jclouds-331 - imageChooser function backport (#202)

You can merge this Pull Request by running: git pull https://github.com/ahgittin/jclouds feature/1.6.x/jclouds-331 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/202 -- Commit Summary -- * JCLOUDS-331 - support specifying an imageChooser f

Re: [jclouds-labs] backport of jclouds-372 fix from jclouds-labs-google (oauth cache expiry... (#34)

[jclouds-labs-pull-requests #86](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/86/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/34#issuecomment-28312808

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

thanks @demobox - opened https://github.com/jclouds/jclouds-labs/pull/34 for 1.6.x --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/14#issuecomment-28312376

[jclouds-labs] backport of jclouds-372 fix from jclouds-labs-google (oauth cache expiry... (#34)

... minutes/seconds bug) You can merge this Pull Request by running: git pull https://github.com/ahgittin/jclouds-labs fix/1.6.3/jclouds-372 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/34 -- Commit Summary -- * backport of jclouds-3

Jenkins build is back to normal : jclouds-karaf-1.6.x-branch #134

See

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds » jclouds #605](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/605/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment

Jenkins build is back to normal : jclouds » jclouds #605

See

Build failed in Jenkins: jclouds-karaf-1.6.x-branch #133

See -- [...truncated 2378 lines...] Downloading: https://oss.sonatype.org/content/repositories/releases/org/apache/jclouds/provider/rackspace-clouddns-us/1.6.3-SNAPSHOT/maven-metadata.xm

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-java-7-pull-requests #852](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/852/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28303950

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-pull-requests #389](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/389/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28303976

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-java-7-pull-requests #851](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/851/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28303126

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-pull-requests #388](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/388/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28303120

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-pull-requests #387](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/387/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28302478

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-java-7-pull-requests #850](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/850/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28302460

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

Sure! I will do that and repush, thanks for the feedback :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28301461

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

This looks good @sallum, thanks! One last thing: in jclouds we use a 3 space indent and a 120 line length. Could you apply this to your changes to follow our code style? As soon as this is done and we have feedback from the CI system about the tests, I will merge the PR. --- Reply to this emai

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

Thanks for your comments! I fixed them in the new push --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28300802

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

> + ListenableFuture method(); > + } > + > + @Test > + public void testPATCHAnnotation() { > + HttpResponse response = > HttpResponse.builder().statusCode(200).build(); > + TestPATCHAnnotationApi tes

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

> @@ -0,0 +1,69 @@ > +package org.jclouds.rest; Move this test to the `org.jclouds.rest.annotationparsing` package. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201/files#r7594178

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

> + * @author Ignacio Mulas > + */ > +@Test(groups = "unit", testName = "PATCHAnnotationExpectTest") > +public class PATCHAnnotationExpectTest extends > + > BaseRestClientExpectTest { > + > + interface TestPATCHAnnotationApi extends Closeable { > + HttpResponse metho

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds » jclouds #604](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/604/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-pull-requests #386](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/386/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28299528

Build failed in Jenkins: jclouds » jclouds #604

See -- [...truncated 3397 lines...] [pool-95-thread-2] Test testFromCallerWhenNextMarkerPresentWithArgsMarkerToNextForArg0ParamIsPresent(org.jclouds.collect.internal.Arg0ToPagedIterableTest) su

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-java-7-pull-requests #849](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/849/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28299506

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds » jclouds #603](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/603/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

[jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

Implementation of PATCH request to be available in the APIs You can merge this Pull Request by running: git pull https://github.com/sallum/jclouds 1.6.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/201 -- Commit Summary -- * [JCLOUDS-376]

Build failed in Jenkins: jclouds » jclouds #603

See Changes: [ignacio.mulas.viela] [JCLOUDS-263] Usage of internalURL services' endpoints [ignacio.mulas.viela] [JCLOUDS-376] PATCH HTTP request implementation -- [...truncated 3424 lin

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds-java-7-pull-requests #848](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/848/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28299086

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds-pull-requests #385](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/385/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28299091

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

Shall I reopen [JCLOUDS-213](https://issues.apache.org/jira/browse/JCLOUDS-213) and [JCLOUDS-373](https://issues.apache.org/jira/browse/JCLOUDS-373) or only the generic JCLOUDS-213 ? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-2

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

@nacx sorry but I'm not familiar with the entire process :( This PR is independent from #77 but it is needed as well on master (I thought it was already merged) - sorry Probably I need to cherry-pick #77 as well but I think we can put it after that. --- Reply to this email directly or view it on

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds » jclouds #602](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/602/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclou

Jenkins build is unstable: jclouds » jclouds #602

See

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

@andreaturli you didn't answer my question. Does this provider work without https://github.com/jclouds/jclouds/pull/77? In that case, shoudn't be a PR for that be opened before this one? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomme

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds-pull-requests #383](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/383/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28290923

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds-java-7-pull-requests #847](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/847/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28290948

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds-pull-requests #384](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/384/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28290937

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds-java-7-pull-requests #846](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/846/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28290949

Build failed in Jenkins: jclouds » jclouds #601

See Changes: [andrea.turli] JCLOUDS-373: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate -- [...truncated 24905 lines...] Results : Tests ru

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds » jclouds #601](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/601/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

Sorry @nacx, now it should be better --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28289768

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

Apart from the build failure, the commit message does not match the JIRA issue. Also, shouldn't the PR to add https://github.com/jclouds/jclouds/pull/77 be made before this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28289405

Jenkins build is back to normal : jclouds-1.6.x-branch » Apache jclouds #206

See

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds-pull-requests #382](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/382/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28288978

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

[jclouds-java-7-pull-requests #845](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/845/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/200#issuecomment-28288844

Re: [jclouds] Fix provider softlayer (#77)

@demobox I've created a new PR described at https://issues.apache.org/jira/browse/JCLOUDS-375 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/77#issuecomment-28288106

[jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

* Wrap getOrderTemplate in VirtualGuestToNodeMetadata.getImage with try/catch * Address comments from @nacx and @demobox: - remove the fields of the custom SoftLayerOrderItemDuplicateException and propagate the HttpResponseException - use of order = null instead of return null - extend Runti

Re: [jclouds] fix for JCLOUDS-373 (#199)

> jclouds-java-7-pull-requests #844 UNSTABLE Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/844/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThr

Re: [jclouds] Fix provider softlayer (#77)

> Should this be cherry-picked to master? @nacx: I'd prefer to see a new PR with some successful PR builds and, if possible, confirmation of a successful live test run..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/77#issuecomment-28287406

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds-pull-requests #381](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/381/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28287113

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds-java-7-pull-requests #844](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/844/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28287094

Re: [jclouds] fix for JCLOUDS-373 (#199)

Pushed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=6e781152954975a8e929576c6e4af49738cf35ea). In order to add this to master too, I think we first need to cherry-pick https://github.com/jclouds/jclouds/pull/77. @demobox? --- Reply to this email directly or view i

Re: [jclouds] Fix provider softlayer (#77)

@demobox Should this be cherry-picked to master? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/77#issuecomment-28286430

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds » jclouds #599](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/599/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment

Re: [jclouds] fix for JCLOUDS-373 (#199)

OK @nacx, done. Thanks all! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28285876

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

Please submit a PR for 1.6.x if we want to backport this... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/14#issuecomment-28285233

Re: [jclouds] fix for JCLOUDS-373 (#199)

@andreaturli Mind squashing the commits into a single one that properly references the issue and describes the fix? Thx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28285210

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=4e6892116819c320d7dd99d0708304b3e670ccd3). Thanks, @ahgittin! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/14#issuecomment-28285219

Re: [jclouds] fix for JCLOUDS-373 (#199)

LGTM too. Thanks all! Will merge this in a while. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28285159

Re: [jclouds] fix for JCLOUDS-373 (#199)

@andreaturli: thanks! New exception type works for me. @nacx: Still thoughts on passing the whole message to the exception? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28284664

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

[jclouds-labs-google-pull-requests #21](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/21/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/14#issuecomment-28284362

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

@demobox moved the impl detail comment out of javadoc --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/14#issuecomment-28284303

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

> @@ -78,7 +81,7 @@ protected void configure() { >// bit before the deadline to make sure there aren't session > expiration exceptions >sessionIntervalInSeconds = sessionIntervalInSeconds > 30 ? > sessionIntervalInSeconds - 30 : >sessionIntervalInSeconds; > -

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds-java-7-pull-requests #843](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/843/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28283892

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds-pull-requests #380](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/380/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28283826

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds » jclouds #598](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/598/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

> @@ -78,7 +81,7 @@ protected void configure() { >// bit before the deadline to make sure there aren't session > expiration exceptions >sessionIntervalInSeconds = sessionIntervalInSeconds > 30 ? > sessionIntervalInSeconds - 30 : >sessionIntervalInSeconds; > -

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

> @@ -66,8 +66,11 @@ protected void configure() { > } > > /** > -* Provides a cache for tokens. Cache is time based and expires after 59 > minutes (the maximum time a token is > -* valid is 60 minutes) > +* Provides a cache for tokens. Cache is time based and by default > ex

Re: [jclouds] fix for JCLOUDS-373 (#199)

> + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under t

Re: [jclouds] fix for JCLOUDS-373 (#199)

> + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under t

Re: [jclouds] fix for JCLOUDS-373 (#199)

> @@ -64,6 +65,8 @@ public void handleError(HttpCommand command, HttpResponse > response) { > exception = new ResourceNotFoundException(message, > exception); >} else if (message.indexOf("currently an active > transaction") != -1) { >

Re: [jclouds] fix for JCLOUDS-373 (#199)

@andreaturli, this looks better. A few considerations apart from my last comment: * Address @demobox comment. * Properly explain the change in the commit message. [Here](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) you have a few recommendations. * Do not squash the com

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds-java-7-pull-requests #842](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/842/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28281502

Re: [jclouds] fix for JCLOUDS-373 (#199)

[jclouds-pull-requests #379](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/379/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28281481

Re: [jclouds] fix for JCLOUDS-373 (#199)

> @@ -64,6 +65,8 @@ public void handleError(HttpCommand command, HttpResponse > response) { > exception = new ResourceNotFoundException(message, > exception); >} else if (message.indexOf("currently an active > transaction") != -1) { >

Re: [jclouds] fix for JCLOUDS-373 (#199)

@nacx @ahgittin @demobox I've committed a new version of the code. I'd appreciate to have your comments, thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/199#issuecomment-28280360

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

[jclouds » jclouds #597](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/597/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/196#issuecomment

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

[jclouds-java-7-pull-requests #841](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/841/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/196#issuecomment-28277103

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

[jclouds-pull-requests #378](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/378/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/196#issuecomment-28276927

Re: [jclouds] fix for JCLOUDS-373 (#199)

The 500 responses are handled in the [SoftLayerErrorHandler](https://github.com/jclouds/jclouds/blob/master/providers/softlayer/src/main/java/org/jclouds/softlayer/handlers/SoftLayerErrorHandler.java#L61-L67). Given the json from the wire logs, I think it would be good to also check if the `Soft

Re: [jclouds] fix for JCLOUDS-373 (#199)

hi @ahgittin @nacx @demobox thanks for your valuable feedbacks! Here is my proposal, following your advices: ```java try { order = client.getVirtualGuestClient().getOrderTemplate(guest.getId()); } catch (HttpResponseException e) { // this is a workaround because SoftLayer throws somethimes