Re: [jclouds-site] A guide on how to report a bug. (#18)

> + > +The Operating System Version you're using. > + > +E.G. Operating System Version: Mac OS X 10.7.5 > + > +## Java Version > + > +The Java Version you're using. > + > +E.G. java version "1.7.0_17" > + > +## Logs > + > +Sending us the stack trace from the exception is helpful but often the root

Re: [jclouds-site] A guide on how to report a bug. (#18)

> @@ -0,0 +1,97 @@ > +--- > +layout: jclouds > +title: Documentation > +--- > + > +# How to Report a Bug to Apache jclouds® > + > +If you run into a bug while using jclouds, we encourage you to report it. To > help you please collect as much of the following information as possible. If > you can'

Re: [jclouds-site] A guide on how to report a bug. (#18)

> @@ -0,0 +1,97 @@ > +--- > +layout: jclouds > +title: Documentation > +--- > + > +# How to Report a Bug to Apache jclouds® > + > +If you run into a bug while using jclouds, we encourage you to report it. To > help you please collect as much of the following information as possible. If > you can'

Re: [jclouds-site] Added Subscribe and Archive links for the mailing lists (#12)

> This will be fixed when we scrub incubator refs from the docs. OK, thanks! Is there a PR planned for that, by the way? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/12#issuecomment-28452179

Re: [jclouds-labs-openstack] The create and stream methods in the Message API for OpenStack Marconi. (#46)

> Where could you put a checkArgument? Can you give me an example? I think @nacx was going down the same path here, but luckily he knew what the actual way to have validation performed during the API call is ;-) I appreciate your point that that moves the error into a less useful position from a

Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)

Have you run the live tests? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28451237

Re: [jclouds] JCLOUDS-373: Fix SoftLayerOrderItemDuplicateException. (#204)

> @@ -16,7 +16,7 @@ > */ > package org.jclouds.softlayer.exceptions; > > -public class SoftLayerOrderItemDuplicateException extends RuntimeException { > +public class SoftLayerOrderItemDuplicateException extends > IllegalStateException { Same question as before on this: the [Javadoc for ISE

restarting the 1.6.3 release process on Friday

I plan to restart the 1.6.3 release process on Friday, 15 November. I believe we have sorted all the infra issues related to graduation that blocked me earlier. Does anyone have outstanding patches for this release or know of any blockers? -- Andrew Gaul http://gaul.org/

Re: [jclouds] JCLOUDS-373: Fix SoftLayerOrderItemDuplicateException. (#204)

[jclouds-java-7-pull-requests #859](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/859/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/204#issuecomment-28449666

Re: [jclouds] JCLOUDS-373: Fix SoftLayerOrderItemDuplicateException. (#204)

[jclouds-pull-requests #396](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/396/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/204#issuecomment-28449130

[jclouds] JCLOUDS-373: Fix SoftLayerOrderItemDuplicateException. (#204)

- SoftLayerOrderItemDuplicateException extends IllegalStateException for consistency and for Throwables2.propagateIfPossible You can merge this Pull Request by running: git pull https://github.com/andreaturli/jclouds fix/softlayer-exception Or you can view, comment on it, or merge it online at

Re: [jclouds-labs-openstack] The create and stream methods in the Message API for OpenStack Marconi. (#46)

@nacx I can see what you mean but I don't think that approach would be as helpful to developers. It's fail-slow, you can set an invalid value but you don't find out about it until just before the request is about to be sent and it's non-localized because the error would occur in the code calling

Re: Apache Package Naming

Oh, I just meant have 2 releases that are healthy at the same time. One with old package and the other with new (different branches, different minor nfnums). Otherwise, I would do it on "real" change like 2.0 as in a new codebase. This one is my preference, as otherwise the refactoring is more d

Re: Apache Package Naming

I think we should do the renaming in a major release (2.0), where users may expect that many existing code will break. Providing a command/whatever is a really nice thimg to send to the ML, but not all users are subscribed, so I think it is better to introduce such a breaker change in a major. Reg

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#203)

Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=6d7bde9676c03cf2f9e793746ce6a22955667a6c). Thanks, @sallum and @adriancole! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/203#issuecomment-28441014

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#203)

[jclouds » jclouds #613](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/613/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/203#issuecomment

Jenkins build is back to stable : jclouds » jclouds #613

See

Re: [jclouds-site] Added Subscribe and Archive links for the mailing lists (#12)

This will be fixed when we scrub incubator refs from the docs. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/12#issuecomment-28439627

Re: [jclouds-site] A guide on how to report a bug. (#18)

Huh. I always thought e.g. should be caps if it starts a sentence/line. Just Googling around it looks like I'm wrong. I'll fix this. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/18#issuecomment-28439378

Re: [jclouds-site] A guide on how to report a bug. (#18)

> + > +The Operating System Version you're using. > + > +E.G. Operating System Version: Mac OS X 10.7.5 > + > +## Java Version > + > +The Java Version you're using. > + > +E.G. java version "1.7.0_17" > + > +## Logs > + > +Sending us the stack trace from the exception is helpful but often the root

Re: [jclouds-site] A guide on how to report a bug. (#18)

> @@ -0,0 +1,97 @@ > +--- > +layout: jclouds > +title: Documentation > +--- > + > +# How to Report a Bug to Apache jclouds® > + > +If you run into a bug while using jclouds, we encourage you to report it. To > help you please collect as much of the following information as possible. If > you can'

Re: [jclouds-site] A guide on how to report a bug. (#18)

> @@ -0,0 +1,97 @@ > +--- > +layout: jclouds > +title: Documentation > +--- > + > +# How to Report a Bug to Apache jclouds® > + > +If you run into a bug while using jclouds, we encourage you to report it. To > help you please collect as much of the following information as possible. If > you can'

Re: [jclouds-site] Added Subscribe and Archive links for the mailing lists (#12)

Yep. These should be user-subscr...@jclouds.apache.org and dev-subscr...@jclouds.apache.org now. Both addresses work. I just tested them. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/12#issuecomment-28438317

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#203)

[jclouds-pull-requests #395](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/395/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/203#issuecomment-28438254

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#203)

[jclouds-java-7-pull-requests #858](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/858/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/203#issuecomment-28438304

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

This contains the pull request to master branch: #203 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28437396

Re: [jclouds-labs-openstack] The create and stream methods in the Message API for OpenStack Marconi. (#46)

[jclouds » jclouds-labs-openstack #616](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/616/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jcloud

Re: [jclouds-labs-openstack] The create and stream methods in the Message API for OpenStack Marconi. (#46)

[jclouds-labs-openstack-pull-requests #95](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/95/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/46#issuecomment-28437701

[jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#203)

Implementation of PATCH request to be available in the APIs You can merge this Pull Request by running: git pull https://github.com/sallum/jclouds patch-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/203 -- Commit Summary -- * [JCLOUD

Re: Project Lombok - Builders (and other annotations)

TL;DR For sake of discussion, there's less magical codegen available: write source. Probably not a silver bullet either. Tools like Dagger, Wire, and Google Auto generate readable source code. Also the test infra for how these work internally is getting super robust. https://github.com/google/aut

Re: Apache Package Naming

My 2p is to release any package rename dist simultaneously with equiv functionality dist on the old package names. That way, folks can do a 2 commit conversion, first to whatever is new and second to the new packages. I don't have a strong view on whether or not to rename, ^^ in the case it is bo

Re: PATCH requests

>From a jclouds code perspective, it's certainly possible to have multiple >versions in a module. I'm sure you've noticed the version identifier in the >package hierarchy. The tricky bit will be when an OpenStack provider actually exposes multiple versions of an API to give its users time to mi

Re: Apache Package Naming

We should change the names at some point to conform with other Apache projects. Doing this sooner rather than later will reduce overall frustration. If we can reduce the user pain to some simple command-line, e.g., find -name pom.xml -o -name \*.java | xargs sed -i 's/org.jclouds

Re: [jclouds-site] JCLOUDS-215 Adds autoscale documentation. (#32)

[jclouds-site-pull-requests #97](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/97/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/32#issuecomment-28427861

[jclouds-site] JCLOUDS-215 Adds autoscale documentation. (#32)

You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-site autoscale-docs Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/32 -- Commit Summary -- * JCLOUDS-215 Adds autoscale documentation. -- File

Re: Apache Package Naming

I'm not aware of any packages with apache in them yet. My take on it is to keep things consistent and *not* name the package with apache. When (If?) we do the package renaming we should do it as a big bang renaming coinciding with a major version change (2.0?). This is a huge backwards incompat

Apache Package Naming

Hey folks, I was just creating a package and realized that it might not necessarily be correct. What is our plan on package naming going forward? As a top level Apache project, I would expect this to change to "org.apache.jclouds.*". Most packages are currently under "org.jclouds.*". Should I b

Re: Project Lombok - Builders (and other annotations)

Thanks for all of the feedback here. It is good to get some additional perspective on this! /jd On Mon, Nov 11, 2013 at 2:54 PM, Andrew Phillips wrote: > Has anyone in the community ever looked at using Project Lombok[1] to help >> simplify our source code? I stumbled across this a couple of y

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds » jclouds-labs #586](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/586/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/3

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds-labs-pull-requests #93](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/93/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28419646

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@nacx what about now? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28419299

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

All fixes are in place except the Expect tests for the "page advance" (they can be found in the previous [style commit](https://github.com/cloudsigma/jclouds-labs/blob/5927d10dc30aa871934f3db9f60d512931df5d5f/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/CloudSigma2ApiExpectTest.java)). I do

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds » jclouds-labs #585](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/585/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/3

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds-labs-pull-requests #92](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/92/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28411960

Jenkins build became unstable: jclouds » jclouds #612

See

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@nacx Take a look. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28411590

Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)

[jclouds-labs-pull-requests #91](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/91/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28409530

[jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)

I've tested #28 for 1.6.3 and it failed 2 tests: ``` Failed tests: testNetworksAndFirewallDeletedWhenAllGroupNodesAreTerminated(org.jclouds.googlecomputeengine.compute.GoogleComputeEngineServiceExpectTest): expected [GET https://www.googleapis.com/compute/v1beta15/projects/myproject/global/net

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

I completely understand, but it is also important that commits are self-contained. Imagine a case where we had to revert, say, the style commit. We would leave the pagination feature without the fixes, and no one could predict that (it is not a realistic example just no note that not having sel

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@nacx Original "style" fix commit contained non-style fixes. That would be a lot of manual mangling of various chunks of code… --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28404276

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

> Create a new PR to port #201 ported to master, merge that one, and rebase and > start working again in this one. I would prefer this one, if possible? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28403709

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@Kentzo You are right, all fixes are there (I didn't look at the entire changes). The problem is that the points that I mentioned are contained in the "style" commit instead of being part of the commit that adds the pagination. There are two changes in this PR which should be self-contained: ad

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@nacx And PaginationOptions seems to be immutable: https://github.com/cloudsigma/jclouds-labs/blob/77beb27d9b5813ed022aa4a3350c3d83cced29dd/cloudsigma2/src/main/java/org/jclouds/cloudsigma2/options/PaginationOptions.java --- Reply to this email directly or view it on GitHub: https://github.com/jc

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds » jclouds-labs #581](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/581/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/3

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@nacx I also don't see the `@Nullable` annotation in `functions/internal`. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28402933

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

This PR seems to have become https://github.com/jclouds/jclouds/pull/201 ported to master. @demobox @everett-toews @sallum, how do you prefer to proceed? * Amend the commit message and the PR description to reflect the real issue being fixed, merge this PR, and then open a new one for the "inte

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@nacx I don't see the `@Inject` annotation in https://github.com/cloudsigma/jclouds-labs/blob/77beb27d9b5813ed022aa4a3350c3d83cced29dd/cloudsigma2/src/main/java/org/jclouds/cloudsigma2/options/PaginationOptions.java --- Reply to this email directly or view it on GitHub: https://github.com/jclouds

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds » jclouds #610](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/610/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds » jclouds-labs #580](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/580/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/3

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds-labs-pull-requests #90](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/90/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28401572

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

A few fixes seem to have escaped the squash: * The `@Nullable` annotations in the parsers are back again. * The `PaginatedCollection` has the `@Inject` annotation. * The `PaginationOptions` is again mutable and does not define the constant. Could you kindly bring those fixes back and re-squash? T

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds-labs-pull-requests #89](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/89/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28401561

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds-java-7-pull-requests #856](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/856/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28399712

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds-pull-requests #393](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/393/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28399677

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

@sallum: could you move 4d309dc into its own PR so that we can merge that independently of this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28396938

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds-java-7-pull-requests #855](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/855/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28395833

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

[jclouds-pull-requests #392](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/392/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28395798

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

Changes look good and I think it is good to merge, if no one else has something to add. Could you squash the commits in a way that the PR ends up with 2 commits: one with all the code style thing (as it is a general style refactor in the entire provider), and one that just adds the pagination?

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

@nacx I think we've addressed issues you mentioned. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28394565

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds » jclouds-labs #578](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/578/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/3

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds-labs-pull-requests #88](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/88/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28393882

Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate (#200)

Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=4e75e0a1e1323122499716bdb8b7bf19fe1768e2) under [JCLOUDS-373](https://issues.apache.org/jira/browse/JCLOUDS-373) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/2

Re: [jclouds-labs] backport of jclouds-372 fix from jclouds-labs-google (oauth cache expiry... (#34)

Committed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=53e63ab) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/34#issuecomment-28392439

Jenkins build is back to normal : jclouds-labs-google » Apache jclouds labs google #27

See

Re: [jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring inboundPort (#13)

Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=69756496bdb9e49fb69e802d97eadc1c17bc2af5). Thanks, @richardcloudsoft! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/13#issuecomment-2839

Re: [jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring inboundPort (#13)

Closed #13. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/13

Re: [jclouds-labs-google] JCLOUDS-367: GCE nodes n>1 ignoring inboundPort (#13)

Hi, can we get this reviewed and merged so that the Jira can be closed? It's the exact same fix that was done on the 1.6.x branch in https://github.com/jclouds/jclouds-labs/pull/33 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/13#issue

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

Committed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=d8ce79cecfce84c6df0118ee43f548f45a01e749). Thanks @sallum! Would you mind opening a pull request against master too? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pul

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-pull-requests #391](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/391/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28382268

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

[jclouds-java-7-pull-requests #854](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/854/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28382114

Re: PATCH requests

Thank you Everett for the welcome and the given hints! :) I will create a JIRA issue and put my code as soon as I have something working so you guys can see it asap. I would like to ask you something more about the version handling in Jclouds. I was wondering if for example it is possible to have

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

> + imageNameAlt, new > Function() { > + @Override > + public TemplateBuilderImpl apply(TemplateBuilderImpl input) > { > +return input.imageChooser(new Function extends Image>, Image>() { > + @Override > +

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

> @@ -111,16 +147,12 @@ public void > testLocationPredicateWhenComputeMetadataIsNotLocationBound() { > } > > @SuppressWarnings("unchecked") > - @Test > - public void testResolveImages() { > - > - > + protected void doTestResolveImages(Supplier> images, > Image expectedBest, >

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

> @@ -945,6 +975,15 @@ public TemplateBuilder imageMatches(Predicate > condition) { > * {@inheritDoc} > */ > @Override > + public TemplateBuilderImpl imageChooser(Function Image>,Image> imageChooser) { [minor] Missing space in `,Image` --- Reply to this email directly or view it

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

> > @Override > + protected String getProviderFormatId(String uniqueLabel) { > + return "us-east-1/"+uniqueLabel; > + } > + > + [minor] Remove blank line --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/202/files#r7621085

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

> @@ -168,6 +171,15 @@ > TemplateBuilder imageMatches(Predicate condition); > > /** > +* Configure this template with a specific preference function which > operates on > +* images which match the other criteria. > +* > +* If no function is supplied, jclouds will select

Re: [jclouds] [JCLOUDS-376] PATCH HTTP request implementation (#201)

@nacx Done! I misunderstood before putting a tab of size 3 spaces but now it is indented with 3 spaces directly. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/201#issuecomment-28380870

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

Great job here @Kentzo @shevchenator, this looks pretty good! It is not trivial to understand how the whole pagination thing works :) In order to merge this, it is important to add the expect tests I mentioned. To summarize the next steps: - [ ] Address minor review comments. - [ ] Add the "pag

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

> +} > +} > + > +@Test > +public void testListLicensesPaginatedCollection() throws Exception { > +CloudSigma2Api api = requestSendsResponse( > +getBuilder() > +.endpoint(endpoint + "licenses/?limit=3&offset=3") > +.

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

> +} > + > +public Builder offset(int offset){ > +this.offset = offset; > +return this; > +} > + > +public PaginationOptions build(){ > +return new PaginationOptions(limit, offset, 0); > +} > +} > + > +private int l

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

> + * limitations under the License. > + */ > +package org.jclouds.cloudsigma2.options; > + > +import org.jclouds.http.options.BaseHttpRequestOptions; > + > +import javax.inject.Named; > +import java.beans.ConstructorProperties; > + > +/** > + * @author Vladimir Shevchenko > + */ > +public class Pa

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

> +import org.jclouds.json.Json; > + > +import javax.inject.Inject; > +import javax.inject.Singleton; > +import java.beans.ConstructorProperties; > +import java.util.List; > + > +/** > + * @author Vladimir Shevchenko > + */ > +@Singleton > +public class ParseVLANs extends ParseJson { > +static

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

> +import com.google.common.base.Optional; > +import com.google.inject.Inject; > +import org.jclouds.cloudsigma2.options.PaginationOptions; > +import org.jclouds.collect.IterableWithMarker; > + > +import java.util.Iterator; > + > +/** > + * @author Vladimir Shevchenko > + */ > +public class Paginat

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

> +} > + > +public static class ToPagedIterable extends > ArgsToPagedIterable { > + > +private CloudSigma2Api api; > + > +@Inject > +public ToPagedIterable(CloudSigma2Api api) { > +this.api = api; > +} > + > +@Override > +protecte

Re: [jclouds-labs] Cloudsigma v2 API Pagination (#35)

[jclouds-labs-pull-requests #87](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/87/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28374511