Jenkins build became unstable: jclouds » jclouds-karaf #563

See

Build failed in Jenkins: jclouds » jclouds HP Cloud Compute provider #2397

See -- Nov 16, 2013 10:57:04 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO:

Build failed in Jenkins: jclouds-1.6.x-branch » jclouds Green House Data Element vCloud provider #211

See -- Nov 16, 2013 10:57:03 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO:

Re: [jclouds] applies tidies for imageChooser (JCLOUDS-331) as suggested in pull #202 (#207)

[jclouds-java-7-pull-requests #872](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/872/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/207#issuecomment-28637428

Re: [jclouds] applies tidies for imageChooser (JCLOUDS-331) as suggested in pull #202 (#207)

[jclouds-pull-requests #409](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/409/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/207#issuecomment-28637415

Re: [jclouds] applies tidies for imageChooser (JCLOUDS-331) as suggested in pull #202 (#207)

fixed the 3 inline whitespace code style items --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/207#issuecomment-28636936

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

@demobox if the whitespace warnings need attention can you give more details? i must have different settings as `git diff HEAD~1..HEAD` on this branch for me (and `HEAD~2..HEAD`) show nothing which looks odd -- certainly no red blocks but then i have no colouring at all, but no warnings or appa

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> @@ -362,6 +364,30 @@ public void testCreateTwoNodesWithRunScript() throws > Exception { >checkOsMatchesTemplate(node2); > } > > + @Test(enabled = true, dependsOnMethods = > "testCreateTwoNodesWithRunScript") > + public void testCreateTwoNodesWithOneSpecifiedName() throws Excep

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

>} > > + if (groupName.equals("")) { > + groupName = > nodeNamingConvention.groupInUniqueNameOrNull(from.getHostname()); > + } > + builder.group(groupName); See comment about perhaps initializing with `null` rather than the empty string above? --- Reply to this

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> @@ -180,6 +186,15 @@ protected > CreateNodesWithGroupEncodedIntoNameThenAddToSet( > */ > protected Set getNextNames(final String group, final Template > template, int count) { >Set names = newLinkedHashSet(); > + if (!template.getOptions().getNodeNames().isEmpty()) { > +

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> @@ -353,7 +355,7 @@ public void testCreateTwoNodesWithRunScript() throws > Exception { >NodeMetadata node2 = nodes.last(); >// credentials aren't always the same >// assertEquals(node1.getCredentials(), node2.getCredentials()); > - > + Unintentional space? --- Rep

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> } catch (IllegalArgumentException iae) { > // no op > } >} >builder.hostname(from.getName()); >builder.location(findLocationForResourceInVDC.apply(from.getVDC())); > - > builder.group(nodeNamingConvention.groupInUniqueNameOrNull(from.

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> @@ -100,8 +100,12 @@ public NodeMetadata apply(ServerInZone serverInZone) { >builder.hostname(from.getName()); >builder.location(from.getHostId() != null ? new > LocationBuilder().scope(LocationScope.HOST).id(from.getHostId()) > .description(from.getHostId()).parent(

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> + requestResponseMap.put(authorizeSecurityGroupIngressRequestGroup, > authorizeSecurityGroupIngressResponse); > + requestResponseMap.put(runInstancesRequest, runInstancesResponse); > + requestResponseMap.put(describeInstanceRequest, > describeNamedInstanceResponse); > + requ

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

>if (generateInstanceNames && !common.containsKey("Name")) { > for (Map.Entry entry : > instancesById.entrySet()) { > String id = entry.getKey(); > -NodeMetadata instance = entry.getValue(); > - > +String name; > +if (nameIter.hasN

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> @@ -153,8 +154,10 @@ protected EC2ComputeService(ComputeServiceContext > context, Map >if (client.getTagApiForRegion(region).isPresent()) { > Map common = > metadataAndTagsAsValuesOfEmptyString(template.getOptions()); > - if (common.size() > 0 || generateInstanceName

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

Yeah - I realized that after pushing. I'm dumb about remembering constants. =)

Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

> @@ -111,7 +111,11 @@ public NodeMetadata apply(Server from) { >builder.location(new > LocationBuilder().scope(LocationScope.HOST).id(from.getHostId()).description( > from.getHostId()).parent(location.get()).build()); >addMetadataAndParseTagsFromCommaDelimitedValue

Re: [jclouds] applies tidies for imageChooser (JCLOUDS-331) as suggested in pull #202 (#207)

@ahgittin: A couple of minor comments, but they shouldn't hold this one up. +1 - looks good to me, thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/207#issuecomment-28635134

Re: [jclouds] applies tidies for imageChooser (JCLOUDS-331) as suggested in pull #202 (#207)

> - } > -}); > - } > - }); > -} > - > + Function tbChooseAlternate = > new Function() { > + @Override > + public TemplateBuilderImpl apply(TemplateBuilderImpl input) { > +return input.imageC

Re: [jclouds] applies tidies for imageChooser (JCLOUDS-331) as suggested in pull #202 (#207)

> @@ -198,67 +215,68 @@ public int compare(Image left, Image right) { > > assertTrue(TemplateBuilderImpl.DEFAULT_IMAGE_ORDERING.compare(image64bit, > imageArchNull) < 0, "wrong default image ordering"); >assertTrue(sorterPreferringNonNullArch.compare(image64bit, > imageArchNull) >

Re: [jclouds] applies tidies for imageChooser (JCLOUDS-331) as suggested in pull #202 (#207)

> - imageNameAlt, new > Function() { > -@Override > -public TemplateBuilderImpl apply(TemplateBuilderImpl input) { > -return > input.imageChooser(input.imageChooserFromOrdering(new Ordering() { > -private int

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

> what command were you running when you got the whitespace warnings? Just looking for the red blocks in `git diff HEAD~1..HEAD` on the command line. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/202#issuecomment-28635038

Re: [jclouds] JCLOUDS-383. Adding c3 instance sizes. (#208)

+1 - looks good to me. Thanks, @abayer! > jclouds » jclouds #628 FAILURE Looks like something blew up in the workspace there, unrelated to this change. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/208#issuecomment-28634766

Re: [jclouds-labs-openstack] Refactored OpenStack pagination to use PaginationOptions. (#45)

Thanks for the follow-up, @everett-toews! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/45#issuecomment-28634511

Re: [jclouds-labs-openstack] Refactored OpenStack pagination to use PaginationOptions. (#45)

> @@ -76,7 +76,8 @@ protected ToPagedIterable(NeutronApi api) { > @SuppressWarnings("unchecked") > @Override > public IterableWithMarker apply(Object input) { > - return > IterableWithMarker.class.cast(networkApi.listInDetail(marker(input.toStri

Re: [jclouds-labs-openstack] Prefer Iterables.getOnlyElement(). Document checkNotNull(). (#50)

Closed #50. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/50

Re: [jclouds-labs-openstack] Added openstack-marconi and rackspace-cloudqueues-us. (#51)

Merged. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/51#issuecomment-28630587

Re: [jclouds-labs-openstack] Prefer Iterables.getOnlyElement(). Document checkNotNull(). (#50)

Merged. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/50#issuecomment-28630584

Re: [jclouds-labs-openstack] Added openstack-marconi and rackspace-cloudqueues-us. (#51)

[jclouds-labs-openstack-pull-requests #99](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/99/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/51#issuecomment-28630372

Re: [jclouds-labs-openstack] Prefer Iterables.getOnlyElement(). Document checkNotNull(). (#50)

[jclouds-labs-openstack-pull-requests #98](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/98/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/50#issuecomment-28630317

[jclouds-labs-openstack] Added openstack-marconi and rackspace-cloudqueues-us. (#51)

You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-openstack pom-queue Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-openstack/pull/51 -- Commit Summary -- * Added openstack-marconi and rackspa

Re: [jclouds-labs-openstack] The create and stream methods in the Message API for OpenStack Marconi. (#46)

> > - protected QueueStats(MessagesStats messages) { > - this.messages = messages; > + protected QueueStats(MessagesStats messageStats) { > + this.messages = checkNotNull(messageStats); Fixed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Re: [jclouds-labs-openstack] Refactored OpenStack pagination to use PaginationOptions. (#45)

> @@ -80,7 +84,15 @@ protected ToPagedIterable(GlanceApi api) { > @SuppressWarnings("unchecked") > @Override > public IterableWithMarker apply(Object input) { > - return > IterableWithMarker.class.cast(imageApi.list(marker(input.toString(; >

Re: [jclouds-labs-openstack] Refactored OpenStack pagination to use PaginationOptions. (#45)

> @@ -80,7 +84,15 @@ protected ToPagedIterable(GlanceApi api) { > @SuppressWarnings("unchecked") > @Override > public IterableWithMarker apply(Object input) { > - return > IterableWithMarker.class.cast(imageApi.listInDetail(marker(input.toString

[jclouds-labs-openstack] Prefer Iterables.getOnlyElement(). Document checkNotNull(). (#50)

You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-openstack pr45-fixes Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-openstack/pull/50 -- Commit Summary -- * Prefer Iterables.getOnlyElement().