Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-12-05 Thread Ilya Kulakov
@nacx :dart: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/41#issuecomment-29965958

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-12-05 Thread Andrew Phillips
> This is not just the test failing, but the equals method not being properly > implemented. Could you kindly fix that? Good catch, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/41#issuecomment-29961986

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-12-05 Thread Ignasi Barrera
Thanks @Kentzo ! I've executed the live tests and the calculator one throws a NPE. It is not about the test itself, but something that is wrong in the domain object definition (and we didn't find in previous reviews). When performing [this assertion](https://github.com/cloudsigma/jclouds-labs/

Re: [jclouds-labs-google] JCLOUDS-393. Move to GCE v1 API. (#17)

2013-12-05 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #26](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/26/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/17#issuecomment-29935718

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-12-05 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #115](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/115/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/41#issuecomment-29916688