Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread Andrew Phillips
Thanks for the updates, @eevans. Almost there, I think. Would this functionality be exercised by any of the existing live tests? If so, could you run those and add the results here? Just to ensure this works "in real life" too ;-) --- Reply to this email directly or view it on GitHub: https://g

Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread Andrew Phillips
> +import com.google.common.base.Charsets; > +import com.google.common.io.ByteStreams; > + > +@Test > +public class BasePayloadSlicerTest { > + > + @Test > + public void testIterableSliceExpectedSingle() throws IOException { > + PayloadSlicer slicer = new BasePayloadSlicer(); > + Stri

Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread Andrew Phillips
> @@ -105,4 +183,62 @@ protected Payload copyMetadataAndSetLength(Payload > input, Payload returnVal, lon >return returnVal; > } > > + @Override > + public Iterable slice(Payload input, long size) { > + checkNotNull(input); > + checkArgument(size >= 0, "length is negati

Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread Andrew Phillips
> +if ((read = input.read(content)) == -1) { > + return null; > +} > + } catch (IOException e) { > +throw Throwables.propagate(e); > + } > + > + return createPayload((content.length == read) ? content : > Arrays.copyOf(conte

Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread Andrew Phillips
> + return (nextPayload != null); > + } > + > + @Override > + public Payload next() { > + Payload payload; > + > + payload = nextPayload; > + nextPayload = getNextPayload(); > + > + return payload; > + } > + > + @Override > + pub

Re: [jclouds] JCLOUDS-394. Add note to ec2 README in re: live tests and new accounts (#221)

2013-12-06 Thread Andrew Phillips
Does http://jclouds.apache.org/documentation/userguide/using-ec2/ also need to be modified? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/221#issuecomment-30045097

Re: [jclouds] JCLOUDS-394. Add note to ec2 README in re: live tests and new accounts (#221)

2013-12-06 Thread Andrew Phillips
> @@ -4,3 +4,10 @@ > # TODO: Implementation status. > # TODO: Supported features. > # TODO: Usage example. > + > +NOTE: The live tests in apis/ec2 will *not* work against AWS EC2 with AWS > accounts created > +from December 04, 2013 and onward, due to those accounts only supporting VPC > and s

Re: [jclouds] JCLOUDS-394. Add note to ec2 README in re: live tests and new accounts (#221)

2013-12-06 Thread BuildHive
[jclouds » jclouds #664](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/664/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/221#issuecomment

Re: [jclouds] JCLOUDS-394. Add note to ec2 README in re: live tests and new accounts (#221)

2013-12-06 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #895](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/895/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/221#issuecomment-30043730

Re: [jclouds] JCLOUDS-394. Add note to ec2 README in re: live tests and new accounts (#221)

2013-12-06 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #432](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/432/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/221#issuecomment-30043708

Re: [jclouds-labs-google] JCLOUDS-393. Move to GCE v1 API. (#17)

2013-12-06 Thread BuildHive
[jclouds » jclouds-labs-google #549](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/549/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

[jclouds] JCLOUDS-394. Add note to ec2 README in re: live tests and new accounts (#221)

2013-12-06 Thread Andrew Bayer
You can merge this Pull Request by running: git pull https://github.com/abayer/jclouds-1 jclouds-394 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/221 -- Commit Summary -- * JCLOUDS-394. Add note to ec2 README in re: live tests and new ac

Re: [jclouds-labs-google] JCLOUDS-393. Move to GCE v1 API. (#17)

2013-12-06 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #27](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/27/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/17#issuecomment-30042927

Re: EC2-CLASSIC vs EC2-VPC

2013-12-06 Thread Jai M
Just wanted to add to this thread. We have been using jclouds for EC2 and did not have issues with the "default VPC" during instance creation (createNode api). The same code works without any issues in both older and newer accounts. On Fri, Dec 6, 2013 at 1:57 PM, Andrew Bayer wrote: > Ok, I'm fa

Re: EC2-CLASSIC vs EC2-VPC

2013-12-06 Thread Andrew Bayer
Ok, I'm fairly sure the issue only shows up when you use the ec2 API directly. When you go with aws-ec2, groupId is used instead of groupName and things work. That said, I've opened https://issues.apache.org/jira/browse/JCLOUDS-394 - I'd like to see us figure out exactly what to do with the ec2 API

Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #431](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/431/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/192#issuecomment-2293

Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #894](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/894/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/192#issuecomment-2322

Re: [jclouds] JCLOUDS-356 multipart uploads with InputStream payloads (#192)

2013-12-06 Thread Eric Evans
OK @demobox, hopefully my most recent push addresses the issues you raised. I had mistakenly rebased to master so had to force-push (none of the previous changesets have been rebased though). Hopefully this doesn't cause too many problems; Sorry about that --- Reply to this email directly or v