Re: jclouds-labs git commit: Avoid improper equality comparisons

2016-10-23 Thread Andrew Gaul
I ran error-prone 2.0.13 with a custom configuration[1] to discover these errors. Our pom.xml uses error-prone at 2.0.5 since newer versions require JDK 8 to run[2] so we miss out on a years worth of new checks. While we only require JDK 6 to run jclouds, I believe we require JDK 7 to compile the

Re: jclouds-labs git commit: Avoid improper equality comparisons

2016-10-23 Thread Ignasi Barrera
Thanks! Out of curiosity, how did you catch these using error prone? AFAIK we have it already configured [1] but I've never seen such errors (although I have to say I have no idea how error-prone works, so I may have missed them). [1] https://github.com/jclouds/jclouds/blob/master/project/pom.xm