[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user ehedgehog commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104688366 On 21 May 2015 at 11:03, Rob Vesse wrote: > +1 LGTM > > Pinging @Stephen-Allen and @ehedgehog >

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104704987 Generally looks good. I tried applying it as a patch and `TextIndexLuceneMultilingualAssembler` uses non-existent `TextDatasetFactory.createLuceneIndexMultilingual`. Is

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104720469 >I tried applying it as a patch and TextIndexLuceneMultilingualAssembler uses non-existent TextDatasetFactory.createLuceneIndexMultilingual . Is this PR dependent on a

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104755152 I'm working from the pull request (`.../64.patch`). Strange indeed : the `.diff` is good, the `.patch` is bad. The website is at https://svn.apache.org/repos/asf/jena/

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104758560 I see, the patch has several commits including files deletion. Applying it totally doesn't work ? --- If your project is set up for it, you can reply to this email

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104760829 The diff and patch are supposed to be the same end result, even if cumulative commits. The patch does not seem to have the later deletes. A bug(let) in github perhaps?

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104762759 I see deletion in /64.patch : Date: Tue, 19 May 2015 14:41:32 -0400 Subject: [PATCH 3/3] langField implementation to store lang tags of literals + refact

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104784383 "git apply" didn't see those! No matter - the PR is otherwise fine. When the `EntityDefinition` the migration constructor (which can be @Deprecated -- just trying to mi

[jira] [Updated] (JENA-380) Migrate core tests to junit4

[ https://issues.apache.org/jira/browse/JENA-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated JENA-380: --- Fix Version/s: Jena 3.0.0 > Migrate core tests to junit4 > > >

[jira] [Commented] (JENA-380) Migrate core tests to junit4

[ https://issues.apache.org/jira/browse/JENA-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557183#comment-14557183 ] ASF subversion and git services commented on JENA-380: -- Commit 6419caaf